Fixed
Status Update
No update yet.
Comments
zh...@gmail.com
Hi. Thanks for reporting this. Fixed in alpha-04
zh...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
il...@google.com
ra...@gmail.com
deleted
ap...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
jb...@google.com
This has been fixed internally and will be available in the Navigation 2.2.0-rc01 release.
ag...@gmail.com
Thank you very much!
jb...@google.com
This has actually been added to the Navigation 2.2.0-beta01 release.
ra...@gmail.com
This is not totally solved. If there is an image in the toolbar, the image still has the animation of "fade in"
ra...@gmail.com
How to reproduce.
- Unzip attached project
- Run app
- Go to toolbar options (top right menu)
- Go to Login or Settings
- Go back
(icon from toolbar is being animated)
- Unzip attached project
- Run app
- Go to toolbar options (top right menu)
- Go to Login or Settings
- Go back
(icon from toolbar is being animated)
jb...@google.com
Re #10 - please file a separate bug. If the issue you are mentioning is covered by https://issuetracker.google.com/issues/121078028 , feel free to +1.
ra...@gmail.com
It's not related with https://issuetracker.google.com/issues/121078028 .
It's relatedhttps://issuetracker.google.com/issues/140848160 , affecting > 2.0.0 versions. Before 2.0.0 was working without any toolbar animation, and currently (2.2.0-rc02, just toolbar title is fixed). Please have a look to the sample shared before
It's related
il...@google.com
Re #12 - if you're using the NavigationUI API, NavigationUI owns the navigation icon and title (including the animation between states, which are indeed working as intended with this change) and you should not be setting them yourself.
Of course, there's no requirement that you use the NavigationUI API - all of the underlying APIs it uses are public API themselves.
Of course, there's no requirement that you use the NavigationUI API - all of the underlying APIs it uses are public API themselves.
ra...@gmail.com
And why this animation was not applied before 2.0.0?
ra...@gmail.com
Ok. Any way to disable it? I couldn't find anything in the documentation
il...@google.com
Re #16 - No, when you use NavigationUI, it owns the updates to the Toolbar / CollapsingToolbarLayout and that includes the animations as per #13.
Description
Version used: 2.2.0-alpha02
Devices/Android versions reproduced on: LG Zero and on emulator
Issue: Animate toolbar title text if it's length exceed certain amount of pixels
Expected: No animation of toolbar title text
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related): attached