Toolbar animates text when transitioning between two top level destinations [140848160]

Fixed

Bug

Status Update

No update yet.

Description

ag...@gmail.com

created issue #1

Sep 11, 2019 02:54PM

Component used: Navigation
Version used: 2.2.0-alpha02
Devices/Android versions reproduced on: LG Zero and on emulator

Issue: Animate toolbar title text if it's length exceed certain amount of pixels
Expected: No animation of toolbar title text

If this is a bug in the library, we would appreciate if you could attach:

- Sample project to trigger the issue.

https://github.com/kaushalyap/toolbar-title-draw-issue

- A screenrecord or screenshots showing the issue (if UI related): attached

toolbar_title.gif

1.4 MB

View

Download

Comments

zh...@gmail.com <zh...@gmail.com> #2Sep 11, 2019 02:58PM

since these are in public API (:/) we need to do this in 1.2

zh...@gmail.com <zh...@gmail.com> #3Sep 11, 2019 03:00PM

since it is already marked as deprecated, we can probably do it by now.

il...@google.com <il...@google.com> Sep 11, 2019 07:47PM

Assigned to jb...@google.com.

ra...@gmail.com <ra...@gmail.com> #4Sep 18, 2019 04:31PM

Opening diff shortly

ap...@google.com <ap...@google.com> #5Oct 1, 2019 05:11PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

jb...@google.com <jb...@google.com> #6Oct 1, 2019 05:21PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.2.0-rc01 release.

ag...@gmail.com <ag...@gmail.com> #7Oct 2, 2019 01:34PM

Thank you very much!

jb...@google.com <jb...@google.com> #8Oct 7, 2019 06:58AM

This has actually been added to the Navigation 2.2.0-beta01 release.

ra...@gmail.com <ra...@gmail.com> #9Nov 18, 2019 04:13PM

This is not totally solved. If there is an image in the toolbar, the image still has the animation of "fade in"

ra...@gmail.com <ra...@gmail.com> #10Nov 18, 2019 05:46PM

How to reproduce.
- Unzip attached project
- Run app
- Go to toolbar options (top right menu)
- Go to Login or Settings
- Go back

(icon from toolbar is being animated)

navigation_components_example-master 2.zip

27 MB

Download

jb...@google.com <jb...@google.com> #11Nov 18, 2019 08:55PM

Re #10 - please file a separate bug. If the issue you are mentioning is covered by

https://issuetracker.google.com/issues/121078028, feel free to +1.

ra...@gmail.com <ra...@gmail.com> #12Nov 18, 2019 09:20PM

It's not related with

https://issuetracker.google.com/issues/121078028.
It's related

https://issuetracker.google.com/issues/140848160, affecting > 2.0.0 versions. Before 2.0.0 was working without any toolbar animation, and currently (2.2.0-rc02, just toolbar title is fixed). Please have a look to the sample shared before

il...@google.com <il...@google.com> #13Nov 18, 2019 09:37PM

Re #12 - if you're using the NavigationUI API, NavigationUI owns the navigation icon and title (including the animation between states, which are indeed working as intended with this change) and you should not be setting them yourself.

Of course, there's no requirement that you use the NavigationUI API - all of the underlying APIs it uses are public API themselves.

ra...@gmail.com <ra...@gmail.com> #14Nov 18, 2019 09:38PM

And why this animation was not applied before 2.0.0?

il...@google.com <il...@google.com> #15Nov 18, 2019 09:41PM

Re #14 - The animation was added in Navigation 2.1.0:

https://developer.android.com/jetpack/androidx/releases/navigation#2.1.0-beta01

ra...@gmail.com <ra...@gmail.com> #16Nov 18, 2019 09:43PM

Ok. Any way to disable it? I couldn't find anything in the documentation

il...@google.com <il...@google.com> #17Nov 18, 2019 09:44PM

Re #16 - No, when you use NavigationUI, it owns the updates to the Toolbar / CollapsingToolbarLayout and that includes the animations as per #13.