IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date:   Wed Sep 18 16:55:49 2019

    Change the way to detect mismatch between POJO and query
   
    This fixes cursor mismatch warnings with expandProjection.
   
    Bug: 140759491
    Test: QueryMethodProcessorTest
    Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M       room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M       room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
  Created: 2019-10-14 17:23:42.610596+00:00
  Changes: aosp/1123258
 

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date:   Thu Apr 16 16:47:05 2020

    Re-factor how errors are dismissed when query is re-written
   
    This CL changes how we handle errors/warnings if query is
    re-written.
    There was a bug in expandProjection where we would report warnings
    for things that Room already fixes automatically (b/140759491).
    The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
    solved it by deferring validating of columns until after re-write
    decision is made. Unfortunately, this required changing PojoRowAdapter
    to have a dummy mapping until it is validating, make it hard to use
    as it does have a non-null mapping which is not useful.
   
    This CL partially reverts that change and instead rely on the log
    deferring logic we have in Context. This way, we don't need to break
    the stability of PojoRowAdapter while still having the ability to
    drop warnings that room fixes. This will also play nicer when we
    have different query re-writing options that can use more information
    about the query results.
   
    Bug: 153387066
    Bug: 140759491
    Test: existing tests pass
    Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M       room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M       room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M       room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4c719b9872d95202271d7c02e8795c3fe8c34aa1
Author: Jeremy Woods <jbwoods@google.com>
Date:   Wed Sep 25 09:39:32 2019

    Only animate toolbar when removing an icon
   
    When animating the toolbar we also animate the bounds. This means if the
    toolbar title is long enough, it will transition in. That is okay when
    going from a destination with an icon, to destinations with no icon
    (top level destination). When going between two top level destinations,
    we should avoid animating the toolbar.
   
    Test: Tested visually in dev app, and navigation app
    BUG: 140848160
    Change-Id: I6b50438bcacbb43f6d9af205a4c88409fcbf6a97

M       navigation/navigation-ui/src/main/java/androidx/navigation/ui/CollapsingToolbarOnDestinationChangedListener.java
M       navigation/navigation-ui/src/main/java/androidx/navigation/ui/ToolbarOnDestinationChangedListener.java

https://android-review.googlesource.com/1128413
https://goto.google.com/android-sha1/4c719b9872d95202271d7c02e8795c3fe8c34aa1

This has been fixed internally and will be available in the Navigation 2.2.0-rc01 release.

Thank you very much!

This has actually been added to the Navigation 2.2.0-beta01 release.

This is not totally solved. If there is an image in the toolbar, the image still has the animation of "fade in"

How to reproduce.
- Unzip attached project
- Run app
- Go to toolbar options (top right menu)
- Go to Login or Settings
- Go back

(icon from toolbar is being animated)

Re #10 - please file a separate bug. If the issue you are mentioning is covered by https://issuetracker.google.com/issues/121078028, feel free to +1.

It's not related with https://issuetracker.google.com/issues/121078028.
It's related https://issuetracker.google.com/issues/140848160, affecting > 2.0.0 versions. Before 2.0.0 was working without any toolbar animation, and currently (2.2.0-rc02, just toolbar title is fixed). Please have a look to the sample shared before

Re #12 - if you're using the NavigationUI API, NavigationUI owns the navigation icon and title (including the animation between states, which are indeed working as intended with this change) and you should not be setting them yourself.

Of course, there's no requirement that you use the NavigationUI API - all of the underlying APIs it uses are public API themselves.

And why this animation was not applied before 2.0.0?

Re #14 - The animation was added in Navigation 2.1.0: https://developer.android.com/jetpack/androidx/releases/navigation#2.1.0-beta01

Ok. Any way to disable it? I couldn't find anything in the documentation

Re #16 - No, when you use NavigationUI, it owns the updates to the Toolbar / CollapsingToolbarLayout and that includes the animations as per #13.