Fixed
Status Update
Comments
lc...@gmail.com <lc...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
an...@seventhbeam.com <an...@seventhbeam.com> #3
since it is already marked as deprecated, we can probably do it by now.
au...@gmail.com <au...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
il...@google.com <il...@google.com> #6
We'll be releasing a dedicated navigation-testing
artifact in Navigation 2.3.0-alpha01
that provides additional testing specific APIs
This work includes:
https://android-review.googlesource.com/1180272 https://android-review.googlesource.com/1182957 https://android-review.googlesource.com/1187078
Among other changes.
Description
Version used: "2.2.0-alpha01"
Devices/Android versions reproduced on: API 27
When following this tutorial to test my fragment
However, due to limitations in the Android VM that we cannot mock final classes or final methods, the same test failed in instrumented test. (Sample project is attached)
Although we can break these limitation with using Mockk or dexmaker-mockito-inline and running test in API >= 28 devices, how to run instrumented test in older versions devices is still a problem.
Currently, instead of mocking the NavController and running tests in FragmentScenario, I just use an ActivityScenario with NavHostFragment and programmatically create NavGraph for testing.
Any better solutions here?
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).