Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 34a86296371931efb1997043acc40ec899264906
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 17 12:49:40 2019
Require FragmentContainerView with name has an id
FragmentContainerView would always need an ID if you were to ever use it
with replace(), add(), or with android:name. While we should still
support using FragmentContainerView programmatically, (as in the case of
NavHostFragment), when there is an android:name present to inflate a
Fragment, we should require an ID.
Test: Added test, Nav Fragment tests pass
BUG: 141177981
Change-Id: I802dd2240fa7097b421667f4ce586e0535345141
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerInflatedFragmentTest.kt
A fragment/fragment/src/androidTest/res/layout/fragment_container_view_no_id.xml
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
https://android-review.googlesource.com/1122961
https://goto.google.com/android-sha1/34a86296371931efb1997043acc40ec899264906
Branch: androidx-master-dev
commit 34a86296371931efb1997043acc40ec899264906
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Sep 17 12:49:40 2019
Require FragmentContainerView with name has an id
FragmentContainerView would always need an ID if you were to ever use it
with replace(), add(), or with android:name. While we should still
support using FragmentContainerView programmatically, (as in the case of
NavHostFragment), when there is an android:name present to inflate a
Fragment, we should require an ID.
Test: Added test, Nav Fragment tests pass
BUG: 141177981
Change-Id: I802dd2240fa7097b421667f4ce586e0535345141
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerInflatedFragmentTest.kt
A fragment/fragment/src/androidTest/res/layout/fragment_container_view_no_id.xml
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
jb...@google.com <jb...@google.com> #3
This has been fixed internally and will be available in the Fragment 1.2.0-alpha05 release.
Description