SavedStateHandleController: IllegalStateException: Already attached to lifecycleOwner [141225984]

Fixed

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Sep 18, 2019 06:26PM

Component used: lifecycle-viewmodel-savedstate
Version used: 2.2.0-alpha05
Devices/Android versions reproduced on: Android 10

AbstractSavedStateViewModelFactory throws an IllegalStateException when creating a ViewModel.

```
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.geekorum.ttrss.free/com.geekorum.ttrss.MainActivity}: java.lang.IllegalStateException: Already attached to lifecycleOwner
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3270)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3409)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2016)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7356)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)
Caused by: java.lang.IllegalStateException: Already attached to lifecycleOwner
at androidx.lifecycle.SavedStateHandleController.attachToLifecycle(SavedStateHandleController.java:43)
at androidx.lifecycle.AbstractSavedStateViewModelFactory.create(AbstractSavedStateViewModelFactory.java:67)
at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:177)
at androidx.lifecycle.ViewModelProvider.get(ViewModelProvider.java:145)
at androidx.lifecycle.ViewModelLazy.getValue(ViewModelProvider.kt:54)
at androidx.lifecycle.ViewModelLazy.getValue(ViewModelProvider.kt:41)
at com.geekorum.ttrss.BatteryFriendlyActivity.getNightViewModel(Unknown Source:7)
at com.geekorum.ttrss.BatteryFriendlyActivity.onCreate(BatteryFriendlyActivity.kt:51)
at com.geekorum.ttrss.InjectableBaseActivity.onCreate(CoreComponents.kt:70)
at com.geekorum.ttrss.MainActivity.onCreate(MainActivity.kt:36)
at android.app.Activity.performCreate(Activity.java:7802)
at android.app.Activity.performCreate(Activity.java:7791)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1306)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3245)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3409)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2016)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7356)
```

This is cause because the controller is attached to lifecycle twice during the creation.
Once in `SavedStateHandleController .create(SavedStateRegistry registry, Lifecycle lifecycle, key, Bundle defaultArgs)` when creating the controller. And a second time, in AbstractSavedStateViewModelFactory.create()` just after the controller is created:

``` AbstractSavedStateViewModelFactory.java

public final <T extends ViewModel> T create(@NonNull String key, @NonNull Class<T> modelClass) {
SavedStateHandleController controller = SavedStateHandleController.create(
mSavedStateRegistry, mLifecycle, key, mDefaultArgs);
controller.attachToLifecycle(mSavedStateRegistry, mLifecycle);
....
```

Comments

da...@gmail.com <da...@gmail.com> #2Sep 18, 2019 06:30PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

da...@gmail.com <da...@gmail.com> #3Sep 18, 2019 10:12PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

th...@gmail.com <th...@gmail.com> #4Sep 20, 2019 09:15AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

gd...@blissapplications.com <gd...@blissapplications.com> #5Sep 23, 2019 10:09AM

We get the same error when using: androidx.lifecycle:lifecycle-extensions:2.2.0-alpha05 (even while using savedstate:1.0.0-alpha04).

ap...@google.com <ap...@google.com> #6Sep 23, 2019 04:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dfe293ff54e20a5b497f63ef0f6cae349faf074c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Sep 23 12:59:08 2019

Fix IS exception AbstractSavedStateViewModelFactory

bug: 141225984
Test: expanded ViewModelsWithStateTest
Change-Id: Ia291bb1ee27a29ad826a30eec105ebae9517517d

M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/SavedStateFactoryTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/androidTest/java/androidx/lifecycle/viewmodel/savedstate/ViewModelsWithStateTest.kt
M lifecycle/lifecycle-viewmodel-savedstate/src/main/java/androidx/lifecycle/AbstractSavedStateViewModelFactory.java

https://android-review.googlesource.com/1127217

https://goto.google.com/android-sha1/dfe293ff54e20a5b497f63ef0f6cae349faf074c

se...@google.com <se...@google.com> Sep 23, 2019 04:33PM

Marked as fixed.

[Deleted User] <[Deleted User]> #7Sep 24, 2019 07:05AM

Can you please reveal what the expected date of release for this fix is?

il...@google.com <il...@google.com> #8Sep 24, 2019 06:21PM

Should be released ~next week.

[Deleted User] <[Deleted User]> #9Sep 27, 2019 11:34AM

Very nice, Thank you!

ih...@gmail.com <ih...@gmail.com> #10Oct 7, 2019 03:40PM

Any plans to release?)
Next weer finished))

il...@google.com <il...@google.com> #11Oct 9, 2019 05:17PM

It's out right now:

https://developer.android.com/jetpack/androidx/releases/lifecycle#viewmodel-savedstate-1.0.0-beta01

gd...@blissapplications.com <gd...@blissapplications.com> #12Oct 9, 2019 05:36PM

Just to confirm, its fixed.