Allow extra parameters in deep link URI [141482822]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Sep 23, 2019 08:00PM

https://b.corp.google.com/issues/133273839 deep link parameters were made optional if they had default values or were nullable. That change also required that all parameters of a deep link being matched be a subset of the original given deep link.

Instead of requiring the parameters be a subset, we should just ignore them, matching and parsing only the parameters that we know about.

Comments

ap...@google.com <ap...@google.com> #2Sep 23, 2019 09:20PM

Dany, I believe this is fixed in a new release of safeargs ?

jb...@google.com <jb...@google.com> #3Sep 23, 2019 09:34PM

Marked as fixed.

Safeargs still needs AndroidComponentsExtension to get the applicationID from the variants (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt;l=73). Did AGP 7.2.0-alpha05 remove the extension?

[Deleted User] <[Deleted User]> #4Oct 25, 2019 04:38PM

it moved to a different package : com.android.build.api.variant

il...@google.com <il...@google.com> #5Nov 4, 2019 08:44PM

Safeargs still relies on AGP 4.2. We need some of the BaseVariant APIs to have replacements before we can upgrade to 7.0+ (https://issuetracker.google.com/203557189).

Issue 141482822

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Sep 23, 2019 09:20PM

jb...@google.com <jb...@google.com> #3Sep 23, 2019 09:34PM

[Deleted User] <[Deleted User]> #4Oct 25, 2019 04:38PM

il...@google.com <il...@google.com> #5Nov 4, 2019 08:44PM

Add comment

Issue metadata