Fixed
Status Update
Comments
vi...@google.com <vi...@google.com> #2
Since this is happening in Tink, rather than in the AndroidX library, it would be best to open an
sa...@gmail.com <sa...@gmail.com> #3
es...@google.com <es...@google.com>
tn...@google.com <tn...@google.com> #4
Tink is the library that does the heavy lifting in Jetpack Security.
And yes, potentially raising that issue with the Tink team directly could help.
zh...@gmail.com <zh...@gmail.com> #5
@4 Well why didn't Google offer it there? Crashes are far more important than warning logs...
Here, created it there too:
https://github.com/google/tink/issues/535
Here, created it there too:
tn...@google.com <tn...@google.com> #6
Anyone here solved the issue? I have implemented the jetpack security and got the same crashes.
dr...@gmail.com <dr...@gmail.com> #7
same warning
de...@google.com <de...@google.com> #9
same warning for me
Description
I wanted to float an idea for a new lint check: An @OpenForTesting annotation in Kotlin, similar to the @VisibleForTesting annotation that exists currently. The idea being here to indicate that a class or method is marked as open so that it can be subclassed for testing (either manually or with Mockito), and should not be overridden or subclassed in production code. This would be beneficial for those writing android instrumentation tests, where mocking final methods and classes is not possible before Android P (
This change would consist of 2 parts:
1) A new annotation class to indicate this, such as @OpenForTesting
2) A new lint check to enforce that no methods are overridden or classes subclassed that contain this annotation. IDE highlighting would also be ideal.
Please let me know what you think about this idea!