[Android Lint Checks] Kotlin @OpenForTesting annotation & lint check [141539024]

Fixed

Feature Request

Reviewed (L1)

Status Update

No update yet.

Description

kk...@alumni.nd.edu

created issue #1

Sep 24, 2019 09:16PM

Hi Android lint team!

I wanted to float an idea for a new lint check: An @OpenForTesting annotation in Kotlin, similar to the @VisibleForTesting annotation that exists currently. The idea being here to indicate that a class or method is marked as open so that it can be subclassed for testing (either manually or with Mockito), and should not be overridden or subclassed in production code. This would be beneficial for those writing android instrumentation tests, where mocking final methods and classes is not possible before Android P (

https://medium.com/androiddevelopers/mock-final-and-static-methods-on-android-devices-b383da1363ad) and all methods and classes are final by default in kotlin.

This change would consist of 2 parts:
1) A new annotation class to indicate this, such as @OpenForTesting
2) A new lint check to enforce that no methods are overridden or classes subclassed that contain this annotation. IDE highlighting would also be ideal.

Please let me know what you think about this idea!

Comments

vi...@google.com <vi...@google.com> #2Sep 25, 2019 02:49AM

Assigned to tn...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

sa...@gmail.com <sa...@gmail.com> #3Dec 11, 2019 06:18AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

es...@google.com <es...@google.com> Apr 30, 2020 11:14PM

Reassigned to an...@google.com.

tn...@google.com <tn...@google.com> #4Aug 7, 2020 05:08PM

Accepted by tn...@google.com.

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

zh...@gmail.com <zh...@gmail.com> #5Aug 7, 2020 05:24PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

tn...@google.com <tn...@google.com> #6Aug 7, 2020 11:14PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

dr...@gmail.com <dr...@gmail.com> #7Aug 7, 2020 11:18PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

tn...@google.com <tn...@google.com> #8Jan 21, 2022 06:13PM

Marked as fixed.

Thank you, I'll try it and check.

de...@google.com <de...@google.com> #9Feb 10, 2022 10:54PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.