SwipeRefreshLayout as parent of VP2 interrupts page swipe gesture [141855018]

Fixed

Bug

Status Update

No update yet.

Description

je...@google.com

created issue #1

Sep 30, 2019 03:46PM

When ViewPager2 is a child of SwipeRefreshLayout, and you swipe to the next page of the VP2, SRL interrupts the gesture in favor of the swipe-to-refresh gesture if the vertical displacement in the swipe gesture is more then the touch slop.

Hierarchy:

Reproduction path:
1. Use this hierarchy:
<swiperefreshlayout>
<viewpager2 />
<swiperefreshlayout>
2. Set an adapter on VP2
3. Swipe left and/or right a few times. When the y distance between the swipe start and the current touch location is > touchSlop, the bug is triggered.

Workaround:
API >= 21: setNestedScrollingEnabled(true) on the direct child of the SRL
API < 21: Let the direct child of SRL implement NestedScrollingChild, and have it set isNestedScrollingEnabled to true. See attached SwipeRefreshChildLayout.kt as a reference implementation, which can be wrapped around the existing child of SRL.

SwipeRefreshChildLayout.kt

4.1 KB

Download

Comments

je...@google.com <je...@google.com> Jul 6, 2020 11:08AM

Accepted by je...@google.com.

ap...@google.com <ap...@google.com> #2Jul 9, 2020 10:41AM

Marked as fixed.

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

vi...@gmail.com <vi...@gmail.com> #3Aug 9, 2022 06:41PM

Comment has been deleted.

Message last modified on Aug 9, 2022 06:41PM

Issue 141855018

Description

Issue summary

Comments

je...@google.com <je...@google.com> Jul 6, 2020 11:08AM

ap...@google.com <ap...@google.com> #2Jul 9, 2020 10:41AM

vi...@gmail.com <vi...@gmail.com> #3Aug 9, 2022 06:41PM

Add comment

Issue metadata