Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
Please include a sample project that reproduces your issue.
ap...@google.com <ap...@google.com> #3
Here is the sample project.
Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;
With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.
Please suggest some workarounds or how to fix this issue?
Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;
With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.
Please suggest some workarounds or how to fix this issue?
jb...@google.com <jb...@google.com> #4
Hello, have you checked sample project? I hope it will help find the issue.
Description
Version used: 1.0.2
Devices/Android versions reproduced on: I did not reproduce it myself but I do have stack traces from Samsun/Huawei/Xiaomi Android 8 and 9
DialogInterface param of DialogFragment.onDismiss() function is marked as @NonNull
```
@Override
public void onDismiss(@NonNull DialogInterface dialog) {
if (!mViewDestroyed) {
// Note: we need to use allowStateLoss, because the dialog
// dispatches this asynchronously so we can receive the call
// after the activity is paused. Worst case, when the user comes
// back to the activity they see the dialog again.
dismissInternal(true);
}
}
```
...but I've seen crashes in my app with stack traces showing that this param was null
```
Fatal Exception: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method l.w.d.j.b, parameter dialog
at com.my.app.ui.dialog.MyCustomDialog.onDismiss + 88(MyCustomDialog.java:88)
at android.app.Dialog$ListenersHandler.handleMessage + 1503(Dialog.java:1503)
at android.os.Handler.dispatchMessage + 105(Handler.java:105)
at android.os.Looper.loop + 164(Looper.java:164)
at android.app.ActivityThread.main + 6944(ActivityThread.java:6944)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run + 327(Zygote.java:327)
at com.android.internal.os.ZygoteInit.main + 1374(ZygoteInit.java:1374)
```
Dialog source code shows that the DialogInterface can be indeed null
This is kind of problematic because the app written in Kotlin crashes and you can't really fix this without using Java code.
Kotlin does not allow us to mark DialogInterface as a nullable value.