AppCompatRatingBar incorrectly render <layer-list> drawables [142004509]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

he...@gmail.com

created issue #1

Oct 3, 2019 02:00PM

Artifact used:
androidx.appcompat:appcompat:1.1.0

Version used:
1.1.0

Theme used:
Irrelevant, but Theme.MaterialComponents.DayNight

Devices/Android versions reproduced on:
Android 5.1 and older

AppCompatRatingBar doesn't render <layer-list> drawables correctly when using android:left/android:right to position child <item> layers, see attached screenshots. The bug is likely caused by the tilefy() method in AppCompatProgressBarHelper:

https://github.com/aosp-mirror/platform_frameworks_support/blob/androidx-1.0-dev/appcompat/src/main/java/androidx/appcompat/widget/AppCompatProgressBarHelper.java#L79

Setting the drawable in code setProgressDrawable(), instead of android:progressDrawable thus bypassing the AppCompatProgressBarHelper "tiling", works as expected, even on Android 5.1. Using the same drawable in an AppCompatImageView also works without issue.

bugged.png

71 KB

View

Download

expected.png

69 KB

View

Download

rating_none_48dp.xml

764 B

Download

Comments

vi...@google.com <vi...@google.com> Oct 4, 2019 04:12AM

Assigned to vi...@google.com.

vi...@google.com <vi...@google.com> #2Oct 4, 2019 06:10AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

he...@gmail.com <he...@gmail.com> #3Oct 4, 2019 12:53PM

C'mon, i provided screenshots showing both the bugged and expected result, even pointing you to the likely cause.
Sigh, reporting on to this tracker is pointless.

vi...@google.com <vi...@google.com> #4Oct 15, 2019 09:25AM

Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

he...@gmail.com <he...@gmail.com> #5Oct 15, 2019 06:14PM

1. Import attached project
2. Install and run on Android 4.4 (KitKat) or older
3. See the AppCompatRatingBar not rendering properly

Bugs2.rar

133 KB

Download

vi...@google.com <vi...@google.com> #6Oct 18, 2019 10:41AM

Please check the attached project as we couldn't extract the files from it.

Screenshot from 2019-10-18 16-10-31.png

16 KB

View

Download

he...@gmail.com <he...@gmail.com> #7Oct 18, 2019 05:40PM

It's a RAR archive, there's no issue with it.
However you have problems extracting such, here's the same content as a ZIP archive.

Bugs2.zip

141 KB

Download

vi...@google.com <vi...@google.com> #8Oct 21, 2019 07:50AM

Reassigned to ki...@google.com.

deleted

Message last modified on Nov 8, 2019 10:03PM

ki...@google.com <ki...@google.com> Dec 7, 2020 04:55PM

Reassigned to al...@google.com.

al...@google.com <al...@google.com> #9Sep 1, 2021 08:57PM

Accepted by al...@google.com.

The AppCompat implementation is missing a platform fix that was added in early 2015.

al...@google.com <al...@google.com> #10Sep 1, 2021 09:01PM

... and there are no tests.

ap...@google.com <ap...@google.com> #11Sep 3, 2021 08:38PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 15526d18462248f73d41272073badf3a18ebe733
Author: Alan Viverette <alanv@google.com>
Date: Wed Sep 01 17:55:40 2021

Parity between platform and AppCompat handling of tileify

Relnote: "Fixed AppCompatProgressBar handling of layer-list progress bars"
Fixes: 142004509
Test: AppCompatProgressBarHelperTest
Change-Id: I6ece3fa57734308b3fbd8c8d704eaf5c79c5d5de

A appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatProgressBarHelperTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatProgressBarHelper.java

https://android-review.googlesource.com/1817101

he...@gmail.com <he...@gmail.com> #12Nov 2, 2022 04:50PM

Still doesn't work on Android 5.1 and lower. Looking at the AppCompatProgressBarHelper.java commit it seems the SDK_INT >= 23 condition is inverted.

al...@google.com <al...@google.com> Nov 2, 2022 04:55PM

Reassigned to an...@google.com.

Issue 142004509

Description

Issue summary

Comments

vi...@google.com <vi...@google.com> Oct 4, 2019 04:12AM

vi...@google.com <vi...@google.com> #2Oct 4, 2019 06:10AM

he...@gmail.com <he...@gmail.com> #3Oct 4, 2019 12:53PM

vi...@google.com <vi...@google.com> #4Oct 15, 2019 09:25AM

he...@gmail.com <he...@gmail.com> #5Oct 15, 2019 06:14PM

vi...@google.com <vi...@google.com> #6Oct 18, 2019 10:41AM

he...@gmail.com <he...@gmail.com> #7Oct 18, 2019 05:40PM

vi...@google.com <vi...@google.com> #8Oct 21, 2019 07:50AM

ki...@google.com <ki...@google.com> Dec 7, 2020 04:55PM

al...@google.com <al...@google.com> #9Sep 1, 2021 08:57PM

al...@google.com <al...@google.com> #10Sep 1, 2021 09:01PM

ap...@google.com <ap...@google.com> #11Sep 3, 2021 08:38PM

he...@gmail.com <he...@gmail.com> #12Nov 2, 2022 04:50PM

al...@google.com <al...@google.com> Nov 2, 2022 04:55PM

Add comment

Issue metadata