Fixed
Status Update
No update yet.
Comments
vi...@google.com
vi...@google.com
Alternatively, we could make all of the drawable compat classes public.
he...@gmail.com
Needs to wait until we're back to alpha.
Bugjuggler: wait until 2022-07-21
vi...@google.com
Hi. I've received your bug and will wait until 2022-07-21 00:00 -0400 EDT and then assign the bug to alanv@google.com.
he...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit de70044326e54d6a50f0745f481bd46927cb777a
Author: Alan Viverette <alanv@google.com>
Date: Thu Jul 28 13:03:36 2022
Move AppCompat's drawable compat classes to public API
Nullability is missing because the platform classes are also missing
nullability.
Relnote: "Move DrawableWrapper, DrawableContainer, and StateListDrawable
compat classes to public API."
Fixes: 227789566
Test: DrawableContainerCompatTest, AnimatedStateListDrawableCompatTest
Change-Id: I37f3e188d926628853c3ef37ce7a32f28afd2823
A appcompat/appcompat-resources/api/restricted_current.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableWrapperCompat.java
M appcompat/appcompat-resources/lint-baseline.xml
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableContainerCompat.java
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/AnimatedStateListDrawableCompat.java
M appcompat/appcompat-resources/api/api_lint.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/StateListDrawableCompat.java
M appcompat/appcompat-resources/src/androidTest/java/androidx/appcompat/graphics/drawable/DrawableContainerCompatTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appcompat/appcompat-resources/api/public_plus_experimental_current.txt
M appcompat/appcompat-resources/api/current.txt
M appcompat/appcompat-resources/api/restricted_current.txt
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/DrawableUtils.java
https://android-review.googlesource.com/2120177
Branch: androidx-main
commit de70044326e54d6a50f0745f481bd46927cb777a
Author: Alan Viverette <alanv@google.com>
Date: Thu Jul 28 13:03:36 2022
Move AppCompat's drawable compat classes to public API
Nullability is missing because the platform classes are also missing
nullability.
Relnote: "Move DrawableWrapper, DrawableContainer, and StateListDrawable
compat classes to public API."
Fixes: 227789566
Test: DrawableContainerCompatTest, AnimatedStateListDrawableCompatTest
Change-Id: I37f3e188d926628853c3ef37ce7a32f28afd2823
A appcompat/appcompat-resources/api/restricted_current.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableWrapperCompat.java
M appcompat/appcompat-resources/lint-baseline.xml
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/DrawableContainerCompat.java
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/AnimatedStateListDrawableCompat.java
M appcompat/appcompat-resources/api/api_lint.ignore
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/graphics/drawable/StateListDrawableCompat.java
M appcompat/appcompat-resources/src/androidTest/java/androidx/appcompat/graphics/drawable/DrawableContainerCompatTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appcompat/appcompat-resources/api/public_plus_experimental_current.txt
M appcompat/appcompat-resources/api/current.txt
M appcompat/appcompat-resources/api/restricted_current.txt
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/DrawableUtils.java
vi...@google.com
deleted
he...@gmail.com
deleted
ki...@google.com
al...@google.com
... and there are no tests.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 15526d18462248f73d41272073badf3a18ebe733
Author: Alan Viverette <alanv@google.com>
Date: Wed Sep 01 17:55:40 2021
Parity between platform and AppCompat handling of tileify
Relnote: "Fixed AppCompatProgressBar handling of layer-list progress bars"
Fixes: 142004509
Test: AppCompatProgressBarHelperTest
Change-Id: I6ece3fa57734308b3fbd8c8d704eaf5c79c5d5de
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatProgressBarHelperTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatProgressBarHelper.java
https://android-review.googlesource.com/1817101
Branch: androidx-main
commit 15526d18462248f73d41272073badf3a18ebe733
Author: Alan Viverette <alanv@google.com>
Date: Wed Sep 01 17:55:40 2021
Parity between platform and AppCompat handling of tileify
Relnote: "Fixed AppCompatProgressBar handling of layer-list progress bars"
Fixes: 142004509
Test: AppCompatProgressBarHelperTest
Change-Id: I6ece3fa57734308b3fbd8c8d704eaf5c79c5d5de
A appcompat/appcompat/src/androidTest/java/androidx/appcompat/widget/AppCompatProgressBarHelperTest.kt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatProgressBarHelper.java
he...@gmail.com
Still doesn't work on Android 5.1 and lower.
Looking at the AppCompatProgressBarHelper.java commit it seems the SDK_INT >= 23 condition is inverted.
Description
androidx.appcompat:appcompat:1.1.0
Version used:
1.1.0
Theme used:
Irrelevant, but Theme.MaterialComponents.DayNight
Devices/Android versions reproduced on:
Android 5.1 and older
AppCompatRatingBar doesn't render <layer-list> drawables correctly when using android:left/android:right to position child <item> layers, see attached screenshots. The bug is likely caused by the tilefy() method in AppCompatProgressBarHelper:
Setting the drawable in code setProgressDrawable(), instead of android:progressDrawable thus bypassing the AppCompatProgressBarHelper "tiling", works as expected, even on Android 5.1. Using the same drawable in an AppCompatImageView also works without issue.