IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e84f9f947bc507c1d785a310b4f3e2861e3f12c6
Author: Jeremy Woods <jbwoods@google.com>
Date:   Thu Oct 10 13:51:26 2019

    Ensure FragmentContainerView properly inflates Fragments
   
    When given a name, a FragmentContainerView should inflate a Fragment
    with the given name and add it to the appropriate FragmentManager. When
    the Fragment calls onInflate() the attributes passed from the
    FragmentContainerView must be the ones from when the
    FragmentContainerView is contructed, otherwise the attributes will be
    incorrect.
   
    This change uses a LayoutInflatorFactory to contruct the
    FragmentContainerView and pass in the right FragmentManager at
    construction time. This means that if a Fragment is created, it can call
    onInflate() with the proper AttributesSet.
   
    Test: Added test to mirror all test with the fragment tag. tested in app
    BUG: 142421837
    Change-Id: I65ff0030a975d3c9f9087660f5b9e4b0a5a6e24c

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerInflatedFragmentTest.kt
M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentFactoryTest.kt
M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.kt
M       fragment/fragment/src/androidTest/java/androidx/fragment/app/NestedInflatedFragmentTest.kt
M       fragment/fragment/src/androidTest/res/layout/inflated_fragment_container_view.xml
A       fragment/fragment/src/androidTest/res/layout/nested_inflated_fragment_container_parent.xml
A       fragment/fragment/src/androidTest/res/layout/nested_retained_inflated_fragment_container_parent.xml
M       fragment/fragment/src/androidTest/res/layout/nested_retained_inflated_fragment_parent.xml
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentContainerView.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java

https://android-review.googlesource.com/1138882
https://goto.google.com/android-sha1/e84f9f947bc507c1d785a310b4f3e2861e3f12c6

  The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/)
  Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/cherrypickHistory/all)
  Created: 2019-10-11 00:12:59.998116+00:00
  Changes: aosp/1138882
 

I have one question about FragmentContainerView flow for inflating Fragment. It inflate Fragment in onAttachedtoWindow, how do I find the Fragment in my Fragment lifecycle (callback)? I found that onAttachedtoWindow will be called after onActivityCreated.

That was actually part of the problem here. With the change above, instead of inflating in onAttachedToWindow we now inflate in FragmentContainerView's constructor. That way you get the onInflate() callback when setContentView() is called on the Activity.

This has been fixed internally, and will be available in the Fragment 1.2.0-beta02 release.

Sorry I don't get it. I saw that the Fragment still being added in onAttachedToWindow callback:
```
.add(getId(), mContainerFragment, mTag)
```

So that we still have to find Fragment via findFragmentByTag(mTag) after onAttachedToWindow.

Re #6 - please file a new issue with a sample project that reproduces your issue.

Re #7 - b/142520327