Fragment used only by FragmentContainerView android:name is removed by ProGuard [142601969]

Fixed

Bug

Status Update

No update yet.

Description

ia...@gmail.com

created issue #1

Oct 13, 2019 02:04PM

Component used: Fragment
Version used: 1.2.0-beta02
Devices/Android versions reproduced on: all

When the only reference to a Fragment is via a FragmentContainerView's android:name, it seems like ProGuard strips the class out, causing crashes in release builds. I expected it to work just like the <fragment> tag in that the class would automatically be kept.

Reproduction steps:
1) Check out Muzei's v3.3.0-beta2 tag
2) Add minifyEnabled true to the debug type in main/build.gradle
3) Build a debug APK / bundle
4) Inspect the dex output and note that the AutoAdvanceFragment (used in the choose_provider_fragment.xml layout) does not exist.

Switching back to <fragment> fixes the issue.

Comments

jb...@google.com <jb...@google.com> Oct 14, 2019 04:40PM

Assigned to jb...@google.com.

an...@google.com <an...@google.com> #2Oct 16, 2019 06:08PM

Please include a sample project that reproduces your issue.

il...@google.com <il...@google.com> #3Oct 16, 2019 10:11PM

Here is the sample project.

Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;

With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.

Please suggest some workarounds or how to fix this issue?

an...@google.com <an...@google.com> #4Oct 16, 2019 11:46PM

Hello, have you checked sample project? I hope it will help find the issue.

my...@gmail.com <my...@gmail.com> #5Jan 22, 2020 08:10PM

@3
I've described a weird workaround that I got, here:

https://issuetracker.google.com/issues/244854449#comment3
Sample:

https://issuetracker.google.com/issues/244854449#comment4

It probably has bugs of its own that I didn't think of.
Google please fix this.

ta...@gmail.com <ta...@gmail.com> #6Jan 22, 2020 08:26PM

Hello, any update please?

[Deleted User] <[Deleted User]> #7Jan 29, 2020 11:48AM

Hello I raised similar issue with this ticket https://issuetracker.google.com/issues/249247706

This makes the SearchView unusable/broken when fragments are changed (i.e base on searchView input query)

What can we do to fix this problem? What is the progress of work on solving this problem?

mi...@gmail.com <mi...@gmail.com> #8Jan 29, 2020 11:55AM

@7 Check @5 for a workaround.

[Deleted User] <[Deleted User]> #9Feb 4, 2020 08:30AM

Hi, i am also facing this issue after we dismiss a DialogFragment, the callback comes in the onPrepareOptionsMenu(), which is causing the issues for me.
Any idea on when it will be fixed?

ey...@gmail.com <ey...@gmail.com> #10Feb 27, 2020 01:22PM

Hello, any estimate please?

ap...@google.com <ap...@google.com> #11Mar 6, 2020 12:46AM

Facing a similar kind of issue when scrolling the fragments using a ViewPager.

https://issuetracker.google.com/issues/267677504

Can you update regarding any progress on this issue.

jb...@google.com <jb...@google.com> #12Mar 6, 2020 03:31PM

Marked as fixed.

I wonder if the new SearchBar has this issue:

https://material.io/blog/android-stable-release-1-8-0

my...@gmail.com <my...@gmail.com> #13Mar 6, 2020 04:03PM

Project: platform/frameworks/support
Branch: androidx-main

commit 50f098644adc703ae218b0b7e999629f516a0241
Author: sanura <sanura@google.com>
Date: Thu Mar 02 00:11:35 2023

Add check to only invalidate options menu when contributing menu items

FragmentManager previously appropriately only added
a MenuProvider when the host is a MenuHost **and**
we are at the root fragment that is providing the
menu items. This behavior should be mirrored when
removing a MenuProvider as well, so that only
components that directly contribute menu items will
invalidate the options menu.

Bug: 244336571
Test: all tests pass
Change-Id: I9404ee9fcc9ce6b80d70a93bea720fe4ccf583a0

M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerInflatedFragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/OptionsMenuFragmentTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/test/FragmentTestActivity.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/2465169

im...@google.com <im...@google.com> #14Mar 16, 2020 03:11PM

@13 Fixed when? On which version of which dependency?
Please show what to write on gradle file.

ka...@gmail.com <ka...@gmail.com> #15Jun 17, 2020 03:43PM

This has been fixed internally and will be available in the Fragment 1.6.0-alpha07 release.

e....@gmail.com <e....@gmail.com> #16Jun 17, 2020 05:03PM

@15 I've noticed I can avoid using the fragment dependency and still work fine with fragments. How come?
It's part of the material dependency, perhaps?

ga...@gtempaccount.com <ga...@gtempaccount.com> #17Nov 13, 2020 07:38PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.6.0-alpha07

il...@google.com <il...@google.com> #18Nov 15, 2020 11:10PM

@17 What if I don't use this dependency (probably imported automatically by material dependency) ? Use it, still?

bu...@gmail.com <bu...@gmail.com> #19Sep 15, 2023 07:31PM

@17 I wanted to try what you wrote on the sample I've provided (after I remove my workaround), and for some reason it doesn't let me.
It says "Duplicate class found".
The IDE doesn't provide any useful explanation of what is the class that is duplicated and what to do about it.
Please help.

bu...@gmail.com <bu...@gmail.com> #20Sep 15, 2023 07:35PM