Fixed
Status Update
No update yet.
Comments
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ra...@google.com
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 91a50b48e3d5c420493c607ff1b156acd6d5ae8b
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Nov 04 07:41:10 2019
Empty WorkContinuation node makes subsequent nodes the head node and replaces the chain.
* Enqueue runnable looks for a node with no pre-requisites to start a REPLACE
* When we insert an empty node in the middle of the chain, the next node
becomes the new head node, and previously inserted nodes are replaced.
* This fix just treats a then(emptyList) a no-op and returns the existing
WorkContinuation.
Fixes:
Test: Added unit tests. Ran integration tests.
Change-Id: Ib34badf0477771eb06a6bfe68c7d9f4ed664563b
M work/workmanager/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/workmanager/src/main/java/androidx/work/impl/WorkContinuationImpl.java
https://android-review.googlesource.com/1157051
Branch: androidx-master-dev
commit 91a50b48e3d5c420493c607ff1b156acd6d5ae8b
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Nov 04 07:41:10 2019
Empty WorkContinuation node makes subsequent nodes the head node and replaces the chain.
* Enqueue runnable looks for a node with no pre-requisites to start a REPLACE
* When we insert an empty node in the middle of the chain, the next node
becomes the new head node, and previously inserted nodes are replaced.
* This fix just treats a then(emptyList) a no-op and returns the existing
WorkContinuation.
Fixes:
Test: Added unit tests. Ran integration tests.
Change-Id: Ib34badf0477771eb06a6bfe68c7d9f4ed664563b
M work/workmanager/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/workmanager/src/main/java/androidx/work/impl/WorkContinuationImpl.java
Description
Version used: 2.2.0+
Devices/Android versions reproduced on: All manufacturers/Android 6 and higher
Basically adding an empty List<OneTimeWorkRequest> to a chain will break the chain. Example:
workContinuation.beginWith(someJob).then(workList1).then(emptyWorkList).then(workList2)....enqeue
The chain completely stops executing work when it reaches the "emptyWorkList" part of the chain. There is NO error message. The chain sort of hangs in limbo after that. Expected behaviour should be that it ignores that part of the chain and proceeds to the next continuation, I think.