Variable JPEG compression quality [142856426]

Fixed

Feature Request

Status Update

No update yet.

Description

g....@gmail.com

created issue #1

Oct 17, 2019 02:23PM

I noticed that the size of the output file can vary greatly depending on the device. I did some quick tests using a Google Pixel (12.3 MP) and a Huawei VNS-L31 (13 MP) and saw that the output file of the Huawei is on average 10 times bigger, averaging 8MB. I did these tests using the default configuration, without specifying any resolution.

I was not expecting to have the same output size, especially if we consider the different resolutions of the cameras, but I think the difference is in this case too much.

I see that CameraX is currently not specifying the compression quality, so I assume each device uses whatever the manufacturer defined. It would be great to have a way to define the compression quality not to have to manually compress the JPEG, which is can easily lead to OOM issues.

Related to this, I also noticed that in case the picture is cropped (which is not my case), the compression quality is set to 100, which may not be desired.

Comments

er...@google.com <er...@google.com> #2Oct 21, 2019 06:10PM

Reassigned to g....@gmail.com.

b/241974799 fixes #3, i.e. optimize for load once, query many

Perfetto trace shell processor now runs in http server mode.

g....@gmail.com <g....@gmail.com> #3Oct 22, 2019 10:22AM

Pulling back to 1.2 because there are many instances of external users blocked on this. Plan is to open up what we have as experimental in 1.2.

photo-pixel.jpg

692 KB

View

Download

photo-huawei.jpg

6.1 MB

View

Download

er...@google.com <er...@google.com> #4Oct 22, 2019 04:58PM

Reassigned to ca...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 80d9e8a14fae3015890c6ada4d6f72131cfd0d39
Author: Chris Craik <ccraik@google.com>
Date: Mon Feb 20 10:06:57 2023

Public experimental API for TraceProcessor

Bug:219851406
Test: ./gradlew bench:b-m:cC
Test: PerfettoTraceProcessorTest
Test: PerfettoTraceProcessorBenchmark
Relnote: "Added public experimental API for PerfettoTraceProcessor to
enable parsing trace content. This is a step toward fully custom
metrics based on Perfetto trace data."

Change-Id: I2659e84e85281f62f77abb6806f9c00bc2442f56

M benchmark/benchmark-macro/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro/build.gradle
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PerfettoTraceRuleTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AndroidxTracingTraceTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AudioUnderrunQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/BatteryDischargeQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureSweepTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkTraceTest.kt
D benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PowerQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/RowTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/AudioUnderrunQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/BatteryDischargeQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
D benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoTraceProcessor.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PowerQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StringHelper.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/ExperimentalPerfettoTraceProcessorApi.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/QueryResultIterator.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/Row.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/Slice.kt
M benchmark/benchmark/build.gradle
M benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/PerfettoTraceProcessorBenchmark.kt

https://android-review.googlesource.com/2447462

er...@google.com <er...@google.com> Nov 12, 2019 12:05AM

Reassigned to er...@google.com.

er...@google.com <er...@google.com> #5Nov 15, 2019 05:57PM

Reassigned to ca...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit a1afb0d256ee6bf1aafb0ffd2cd958ac09c1fadd
Author: Chris Craik <ccraik@google.com>
Date: Thu Mar 09 16:43:42 2023

Add Experimental TraceMetric for fully custom metrics from traces

Fixes: 219851406
Test: ./gradlew bench:b-m:cC
Relnote: "Added new experimental TraceMetric API for defining fully
custom metrics based on content of a Perfetto trace."

Along with opening up the metric, migrates Metric to more extensible
output types. This allows us to eventually add further per-submetric
customization (such as per-submetric strictness on presence in each
iteration, custom display in studio, etc.

Also now correctly propogates TraceProcessor errors (e.g. query syntax
errors) to Kotlin callers.

This change also removes the concept of timelineRange in metric
results / trace UiState, as it's no longer necessary after
optimizations to remove sleep()s at the beginning/end of trace
capture.

Change-Id: I4ce3147b5bd1a13ae6a500389abdae3df461cacd

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/UiState.kt
M benchmark/benchmark-macro/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro/build.gradle
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
A benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
D benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/IterationResult.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MetricResultExtensions.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/QueryResultIterator.kt

https://android-review.googlesource.com/2479937

mi...@gmail.com <mi...@gmail.com> #6Aug 9, 2021 05:54PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.2.0-alpha12

er...@google.com <er...@google.com> #7Aug 10, 2021 05:30PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.2.0-alpha13
androidx.benchmark:benchmark-macro:1.2.0-alpha13

wu...@google.com <wu...@google.com> Aug 11, 2021 08:13AM

Reassigned to sc...@google.com.

er...@google.com <er...@google.com> #8Aug 17, 2021 05:29PM

Update: @comment#6 - The team explored one option (camera2iterop) however this does not override the JPEG_QUALITY in still capture. The team will be exploring another alternative. We'll update when we're done with the exploration. Thanks!

sc...@google.com <sc...@google.com> #9Aug 18, 2021 02:20AM

Though currently apps cannot set the jpeg quality, ImageCapture CAPTURE_MODE_MINIMIZE_LATENCY mode will set the jpeg quality to 95 and CAPTURE_MODE_MAXIMIZE_QUALITY will set it to 100.
In our experiments, it does make a lot of differences in file size. We will continue to explore the possibility of adding new API to configure jpeg quality.

sc...@google.com <sc...@google.com> Aug 19, 2021 06:49AM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> Aug 26, 2021 08:55AM

Accepted by ch...@google.com.

ap...@google.com <ap...@google.com> #10Sep 2, 2021 05:30AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d5782ce903c98f3236ae1171effc34f506b5f17
Author: Charcoal Chen <charcoalchen@google.com>
Date: Wed Aug 25 14:54:24 2021

Compress the output image with the specified JPEG quality level for capture modes when cropping is needed

Relnote: "When cropping is needed for ImageCapture, compressing the output cropped image with the specified JPEG quality level according to the set capture mode. If the capture mode is CAPTURE_MODE_MINIMIZE_LATENCY, the JPEG compression quality will be 95. If the capture mode is CAPTURE_MODE_MAXIMIZE_QUALITY, the JPEG compression quality will be 100."

Bug: 142856426
Test: ./gradlew camera:camera-core:build && ./gradlew camera:camera-core:connectedAndroidTest
Change-Id: Ieb37cfede4173d165bd481b86a04545887b0d487

M camera/camera-core/src/androidTest/java/androidx/camera/core/ImageSaverTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageSaver.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/utils/ImageUtil.java
M camera/camera-core/src/test/java/androidx/camera/core/internal/utils/ImageUtilTest.java

https://android-review.googlesource.com/1810058

ch...@google.com <ch...@google.com> #11Oct 12, 2021 03:19AM

Marked as fixed.

aosp/1810060 has been merged to support ImageCapture.Builder#setJpegQuality(int) API. The new API will allow the developers to adjust the JPEG compression quality settings of the output images. Please stay tuned for CameraX's Nov release to have this API.

About the below issue mentioned in comment#1.

in case the picture is cropped (which is not my case), the compression quality is set to 100

The issue has been fixed by aosp/1810058 which has been included in camera-core 1.1.0-alpha09.

Bug Fixes
- When cropping is needed for ImageCapture, compressing the output cropped image with the specified JPEG quality level according to the set capture mode. If the capture mode is CAPTURE_MODE_MINIMIZE_LATENCY, the JPEG compression quality will be 95. If the capture mode is CAPTURE_MODE_MAXIMIZE_QUALITY, the JPEG compression quality will be 100.

After aosp/1810060 is merged, the output cropped image will be compressed by the value set via ImageCapture.Builder#setJpegQuality(int) API.

aa...@gmail.com <aa...@gmail.com> #12Oct 3, 2022 09:32AM

Hello,
I have 3 buttons to set different jpedQulity to image capture use case,
Low - 30 -> file obtained is of size 300KB
Medium - 50 -> 250KB
High - 100 -> 1MB

When I pass 50 as the value, ideally the image size should increase (I have put camera on a stand, so I am clicking same view) however it’s even less than the image captured with 30 as quality.
On keenly observing this, I saw that on changing the jpeg quality to 30, the preview gets zoomed out automatically.
Can anyone help here?
Is this the default behaviour that preview will zoom out on lowering the quality?

ch...@google.com <ch...@google.com> #13Oct 4, 2022 01:36AM

Hi,

Thanks for reporting this. I have created b/250731613 for tracking it.

aa...@gmail.com <aa...@gmail.com> #14Oct 31, 2022 06:30AM

Hi Google Team,

Thanks for raising a separate ticket for my issue.
I have replied to the asked questions on the same, please have a look.