Fixed
Status Update
No update yet.
Comments
jo...@gmail.com
Also, in case it helps, the target token points to com.android.car.media.localmediaplayer from Android 10, which is functioning correctly before I try this connection myself, and continues to run correctly regardless of my attempt crashing.
gy...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 05c46e7d27a361ae9eee34b908e329b56fda0461
Author: Jaewan Kim <jaewan@google.com>
Date: Thu Nov 28 02:37:59 2019
Fix MediaController crash with fwk MediaSession
Bug: 142925848
Test: ./gradlew media2:media2-session:connectedCheck
Change-Id: I7768565830cea5a2d9b2e9c1551968a4fcda8274
M media/version-compat-tests/current/client/src/androidTest/java/android/support/mediacompat/client/MediaControllerCompatCallbackTest.java
A media2/session/src/androidTest/java/androidx/media2/session/MediaController_FrameworkMediaSessionTest.java
M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
https://android-review.googlesource.com/1177663
Branch: androidx-master-dev
commit 05c46e7d27a361ae9eee34b908e329b56fda0461
Author: Jaewan Kim <jaewan@google.com>
Date: Thu Nov 28 02:37:59 2019
Fix MediaController crash with fwk MediaSession
Bug: 142925848
Test: ./gradlew media2:media2-session:connectedCheck
Change-Id: I7768565830cea5a2d9b2e9c1551968a4fcda8274
M media/version-compat-tests/current/client/src/androidTest/java/android/support/mediacompat/client/MediaControllerCompatCallbackTest.java
A media2/session/src/androidTest/java/androidx/media2/session/MediaController_FrameworkMediaSessionTest.java
M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
ja...@google.com
ja...@google.com
Sorry, fix above cuased regression.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4295f15a153c583a48aca2c0802c1a2c10232d60
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 07 14:16:22 2020
Don't notify session info via callbacks when the connection is made
This fixes the regression caused by my previous commit below
05c46e7d27 Fix MediaController crash with fwk MediaSession
Test had failed because onPlaybackStateChanged(),
onShuffleModeChanged(), onRepeatModeChanged(), and
onCaptioningEnabledChanged() are called to notify the session's
information when the connection is established.
Bug: 146467882, Bug: 142925848
Test: run version compat test
Change-Id: Iedb1aa52c96ee2c2f6a7c7a6f225155cecde6baa
M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
https://android-review.googlesource.com/1195030
Branch: androidx-master-dev
commit 4295f15a153c583a48aca2c0802c1a2c10232d60
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 07 14:16:22 2020
Don't notify session info via callbacks when the connection is made
This fixes the regression caused by my previous commit below
05c46e7d27 Fix MediaController crash with fwk MediaSession
Test had failed because onPlaybackStateChanged(),
onShuffleModeChanged(), onRepeatModeChanged(), and
onCaptioningEnabledChanged() are called to notify the session's
information when the connection is established.
Bug: 146467882, Bug: 142925848
Test: run version compat test
Change-Id: Iedb1aa52c96ee2c2f6a7c7a6f225155cecde6baa
M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
an...@google.com
jo...@gmail.com
Will this make it to the next release?
gy...@google.com
Yes, the issue will be fixed in media2-session 1.0.2.
Description
Code to connect:
if (sessionToken != null) {
mediaController = MediaController.Builder(activity)
.setSessionToken(sessionToken)
.setControllerCallback({ it.run() }, this)
.build()
}
Stacktrace:
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean androidx.media2.session.SessionCommandGroup.equals(java.lang.Object)' on a null object reference
at androidx.media2.session.MediaControllerImplLegacy$ControllerCompatCallback.onPlaybackStateChanged(MediaControllerImplLegacy.java:1201)
at android.support.v4.media.session.MediaControllerCompat$Callback$MediaControllerCallbackApi21.onPlaybackStateChanged(MediaControllerCompat.java:917)
at android.media.session.MediaController$MessageHandler.handleMessage(MediaController.java:1174)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.HandlerThread.run(HandlerThread.java:67)