NPE when connecting using a MediaController [142925848]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Oct 18, 2019 11:19AM

Using androidx.media2:media2-session:1.0.1.

Code to connect:

if (sessionToken != null) {
mediaController = MediaController.Builder(activity)
.setSessionToken(sessionToken)
.setControllerCallback({ it.run() }, this)
.build()
}

Stacktrace:

java.lang.NullPointerException: Attempt to invoke virtual method 'boolean androidx.media2.session.SessionCommandGroup.equals(java.lang.Object)' on a null object reference
at androidx.media2.session.MediaControllerImplLegacy$ControllerCompatCallback.onPlaybackStateChanged(MediaControllerImplLegacy.java:1201)
at android.support.v4.media.session.MediaControllerCompat$Callback$MediaControllerCallbackApi21.onPlaybackStateChanged(MediaControllerCompat.java:917)
at android.media.session.MediaController$MessageHandler.handleMessage(MediaController.java:1174)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.HandlerThread.run(HandlerThread.java:67)

Comments

jo...@gmail.com <jo...@gmail.com> #2Oct 18, 2019 11:21AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

gy...@google.com <gy...@google.com> Oct 21, 2019 02:07AM

Reassigned to gy...@google.com.

gy...@google.com <gy...@google.com> #3Oct 22, 2019 01:01AM

Reassigned to ja...@google.com.

Reproduction: aosp/1148396

ap...@google.com <ap...@google.com> #4Dec 9, 2019 03:24AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 05c46e7d27a361ae9eee34b908e329b56fda0461
Author: Jaewan Kim <jaewan@google.com>
Date: Thu Nov 28 02:37:59 2019

Fix MediaController crash with fwk MediaSession

Bug: 142925848
Test: ./gradlew media2:media2-session:connectedCheck
Change-Id: I7768565830cea5a2d9b2e9c1551968a4fcda8274

M media/version-compat-tests/current/client/src/androidTest/java/android/support/mediacompat/client/MediaControllerCompatCallbackTest.java
A media2/session/src/androidTest/java/androidx/media2/session/MediaController_FrameworkMediaSessionTest.java
M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java

https://android-review.googlesource.com/1177663

ja...@google.com <ja...@google.com> Dec 9, 2019 05:24AM

Marked as fixed.

ja...@google.com <ja...@google.com> #5Jan 7, 2020 01:49AM

Sorry, fix above cuased regression.

b/146467882

ap...@google.com <ap...@google.com> #6Jan 9, 2020 06:55AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4295f15a153c583a48aca2c0802c1a2c10232d60
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 07 14:16:22 2020

Don't notify session info via callbacks when the connection is made

This fixes the regression caused by my previous commit below
05c46e7d27 Fix MediaController crash with fwk MediaSession

Test had failed because onPlaybackStateChanged(),
onShuffleModeChanged(), onRepeatModeChanged(), and
onCaptioningEnabledChanged() are called to notify the session's
information when the connection is established.

Bug: 146467882, Bug: 142925848
Test: run version compat test
Change-Id: Iedb1aa52c96ee2c2f6a7c7a6f225155cecde6baa

M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java

https://android-review.googlesource.com/1195030

an...@google.com <an...@google.com> #7Jan 22, 2020 03:27AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6596470185525248/#/history/all)
Created: 2020-01-22 03:24:09.131281+00:00
Changes: aosp/1213554, aosp/1213551

jo...@gmail.com <jo...@gmail.com> #8Jan 24, 2020 08:17AM

Will this make it to the next release?

gy...@google.com <gy...@google.com> #9Jan 24, 2020 09:27AM

Yes, the issue will be fixed in media2-session 1.0.2.

ma...@gmail.com <ma...@gmail.com> #10Oct 4, 2022 08:09PM

https://issuetracker.google.com/issues/250610583

https://issuetracker.google.com/issues/250609756

https://issuetracker.google.com/issues/250609759

https://issuetracker.google.com/issues/250610272

https://issuetracker.google.com/issues/250610273

https://issuetracker.google.com/issues/250610276

https://issuetracker.google.com/issues/250610278

https://issuetracker.google.com/issues/250610593

https://issuetracker.google.com/issues/250610280

https://issuetracker.google.com/issues/250610923

https://issuetracker.google.com/issues/250610282

https://issuetracker.google.com/issues/250611106

https://issuetracker.google.com/issues/250610598

https://issuetracker.google.com/issues/250611463

https://issuetracker.google.com/issues/250611111

https://issuetracker.google.com/issues/250610933

https://issuetracker.google.com/issues/250610935

https://issuetracker.google.com/issues/250611113

https://issuetracker.google.com/issues/250610937

https://issuetracker.google.com/issues/250611116

https://issuetracker.google.com/issues/250611466

https://issuetracker.google.com/issues/250612724

https://issuetracker.google.com/issues/250612604

https://issuetracker.google.com/issues/250612726

https://issuetracker.google.com/issues/250611471

https://issuetracker.google.com/issues/250177858

https://issuetracker.google.com/issues/250172577

https://www.endezo-it.com/2022/10/the-dark-event-of-indonesian-football.html

https://www.49erssports.com/2022/10/kanjuruhan-tragedy-arema-fc-management.html

https://one-piece-red-full-movie-english.webflow.io/

https://documenter.getpostman.com/view/21828632/2s83tJGAat