Fixed
Status Update
No update yet.
Comments
jo...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
gy...@google.com
gy...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ja...@google.com
ja...@google.com
Sorry, fix above cuased regression.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4295f15a153c583a48aca2c0802c1a2c10232d60
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 07 14:16:22 2020
Don't notify session info via callbacks when the connection is made
This fixes the regression caused by my previous commit below
05c46e7d27 Fix MediaController crash with fwk MediaSession
Test had failed because onPlaybackStateChanged(),
onShuffleModeChanged(), onRepeatModeChanged(), and
onCaptioningEnabledChanged() are called to notify the session's
information when the connection is established.
Bug: 146467882, Bug: 142925848
Test: run version compat test
Change-Id: Iedb1aa52c96ee2c2f6a7c7a6f225155cecde6baa
M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
https://android-review.googlesource.com/1195030
Branch: androidx-master-dev
commit 4295f15a153c583a48aca2c0802c1a2c10232d60
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 07 14:16:22 2020
Don't notify session info via callbacks when the connection is made
This fixes the regression caused by my previous commit below
05c46e7d27 Fix MediaController crash with fwk MediaSession
Test had failed because onPlaybackStateChanged(),
onShuffleModeChanged(), onRepeatModeChanged(), and
onCaptioningEnabledChanged() are called to notify the session's
information when the connection is established.
Bug: 146467882, Bug: 142925848
Test: run version compat test
Change-Id: Iedb1aa52c96ee2c2f6a7c7a6f225155cecde6baa
M media2/session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
an...@google.com
jo...@gmail.com
Will this make it to the next release?
gy...@google.com
Yes, the issue will be fixed in media2-session 1.0.2.
Description
Code to connect:
if (sessionToken != null) {
mediaController = MediaController.Builder(activity)
.setSessionToken(sessionToken)
.setControllerCallback({ it.run() }, this)
.build()
}
Stacktrace:
java.lang.NullPointerException: Attempt to invoke virtual method 'boolean androidx.media2.session.SessionCommandGroup.equals(java.lang.Object)' on a null object reference
at androidx.media2.session.MediaControllerImplLegacy$ControllerCompatCallback.onPlaybackStateChanged(MediaControllerImplLegacy.java:1201)
at android.support.v4.media.session.MediaControllerCompat$Callback$MediaControllerCallbackApi21.onPlaybackStateChanged(MediaControllerCompat.java:917)
at android.media.session.MediaController$MessageHandler.handleMessage(MediaController.java:1174)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.HandlerThread.run(HandlerThread.java:67)