LifecycleRegistry should clear observers when it reaches State.DESTROYED [142925860]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Oct 18, 2019 08:41PM

Observation #1: State.DESTROYED is the final state and if I understand correctly there is no coming back from it. From JavaDoc: After this event, this Lifecycle will not dispatch any more events.

Observation #2: LifecycleRegistry.moveToState(next) immediately returns if next state == current state.

Therefore any observer remaining in LifecycleRegistry's mObserverMap is completely useless and will never be notified again after the LifecycleRegistry has reached State.DESTROYED.

Please clear mObserverMap when LifecycleRegistry reaches State.DESTROYED, allowing the observers to be garbage collected immediately.

Comments

[Deleted User] <[Deleted User]> #2Nov 29, 2019 02:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8d1b84a6aabbb17cfd026e9626c612bf64a49709
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Mar 25 15:41:47 2022

Call Processor.startWork() in `DelayMetCommandHandler` from serial executor

After this CL `Processor.startWork()` is always called from serial executor,
so there is now a guarantee for other work in the serial executor, that now new
work will be started in parallel. This is important for work updating feature because
we want to guarantee that if update was successful, then next worker execution will have
updated spec.

bug: 219446409
Test: ./gradlew :work:work-runtime:cC
Change-Id: Ic9ff9e0fdcc6524b12b3761b9976f328e834e95a

M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java

https://android-review.googlesource.com/2042710

il...@google.com <il...@google.com> Nov 18, 2021 10:12PM

Status: New

jb...@google.com <jb...@google.com> Feb 4, 2022 12:10AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Feb 7, 2022 02:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit 327311c283773ad6c7e3d0fdff05136df925f8ad
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:45:01 2022

Migrate enums to Kotlin

bug: 219446409
Test: NA
Change-Id: I6331453c65b372309ab2c7af17efa649c8feeb54

M work/work-runtime/src/main/java/androidx/work/ExistingWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/OutOfQuotaPolicy.kt
M work/work-runtime/src/main/java/androidx/work/NetworkType.kt
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/BackoffPolicy.kt

https://android-review.googlesource.com/2052912

il...@google.com <il...@google.com> #4Feb 7, 2022 06:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 12a144ae86997cb6a69545b1dd8f1cc559220772
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:38:59 2022

Move enum file from *.java -> *.kt

bug: 219446409
Test: NA
Change-Id: I0ce0df156dbc1c2820b62215fbfb0c0b07add20a

M work/work-runtime/src/main/java/androidx/work/ExistingWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/OutOfQuotaPolicy.kt
M work/work-runtime/src/main/java/androidx/work/NetworkType.kt
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/BackoffPolicy.kt

https://android-review.googlesource.com/2052911

Issue 142925860