LifecycleRegistry should clear observers when it reaches State.DESTROYED [142925860]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Oct 18, 2019 08:41PM

Observation #1: State.DESTROYED is the final state and if I understand correctly there is no coming back from it. From JavaDoc: After this event, this Lifecycle will not dispatch any more events.

Observation #2: LifecycleRegistry.moveToState(next) immediately returns if next state == current state.

Therefore any observer remaining in LifecycleRegistry's mObserverMap is completely useless and will never be notified again after the LifecycleRegistry has reached State.DESTROYED.

Please clear mObserverMap when LifecycleRegistry reaches State.DESTROYED, allowing the observers to be garbage collected immediately.

Comments

[Deleted User] <[Deleted User]> #2Nov 29, 2019 02:46AM

https://tazapropads.ru/?cnv_id=bd8628ruqoc1ma1a

il...@google.com <il...@google.com> Nov 18, 2021 10:12PM

Status: New

jb...@google.com <jb...@google.com> Feb 4, 2022 12:10AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Feb 7, 2022 02:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit 66bcb0e2ad3ed698318475f3c6147506207362cc
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Feb 03 16:11:45 2022

Clear ObserverMap with LifecycleRegistry is DESTROYED

After the LifecycleRegistry is DESTROYED it will not get anymore
callbacks so we should just clear our the Observers.

RelNote: "`LifecycleRegistry` will now clear their observers when they
reach the DESTROYED state."
Test: all existing tests pass
Bug: 142925860

Change-Id: I4f8ddff68b9daebbd89aaa6d9abe7d462081d45e

M lifecycle/lifecycle-runtime/src/main/java/androidx/lifecycle/LifecycleRegistry.java

https://android-review.googlesource.com/1972160

il...@google.com <il...@google.com> #4Feb 7, 2022 06:05PM

Marked as fixed.

This has been fixed internally and will be available in Lifecycle 2.5.0-alpha03.

Issue 142925860