LifecycleRegistry should clear observers when it reaches State.DESTROYED [142925860]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Oct 18, 2019 08:41PM

Observation #1: State.DESTROYED is the final state and if I understand correctly there is no coming back from it. From JavaDoc: After this event, this Lifecycle will not dispatch any more events.

Observation #2: LifecycleRegistry.moveToState(next) immediately returns if next state == current state.

Therefore any observer remaining in LifecycleRegistry's mObserverMap is completely useless and will never be notified again after the LifecycleRegistry has reached State.DESTROYED.

Please clear mObserverMap when LifecycleRegistry reaches State.DESTROYED, allowing the observers to be garbage collected immediately.

Comments

[Deleted User] <[Deleted User]> #2Nov 29, 2019 02:46AM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

il...@google.com <il...@google.com> Nov 18, 2021 10:12PM

Status: New

jb...@google.com <jb...@google.com> Feb 4, 2022 12:10AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Feb 7, 2022 02:12PM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

il...@google.com <il...@google.com> #4Feb 7, 2022 06:05PM

Marked as fixed.

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

Issue 142925860