Fixed
Status Update
Comments
le...@google.com <le...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019
API lint check for the MinMaxConstant is enabled for androidx
Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25
M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java
https://android-review.googlesource.com/1114511
https://goto.google.com/android-sha1/64f11e5722d8a574ccb72bfb042fa89f51129c68
Branch: androidx-master-dev
commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019
API lint check for the MinMaxConstant is enabled for androidx
Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25
M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java
ch...@google.com <ch...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019
API lint check for the SetterReturnsThis is enabled for androidx
Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
https://android-review.googlesource.com/1123398
https://goto.google.com/android-sha1/536a1ff3c3c7623ef60ef89b45266afd63ca748f
Branch: androidx-master-dev
commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019
API lint check for the SetterReturnsThis is enabled for androidx
Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019
API lint check for the PackageLayering is enabled for androidx
PackageLayering is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
https://android-review.googlesource.com/1126765
https://goto.google.com/android-sha1/8aecbea988804f4f702812f6e7f50bc60359eed1
Branch: androidx-master-dev
commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019
API lint check for the PackageLayering is enabled for androidx
PackageLayering is turned into an error in androidx configuration
Bug: 138602561
Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
Description
```
sealed class MyModel {
@androidx.compose.Model
data class A(var value: Int) : MyModel()
}
@androidx.compose.Model
data class B(var value: Int) : MyModel()
```
Observed behavior: the compilation fails only on class B with "Model objects do not support inheritance".
Expected behavior: the compilation fails for both A and B (or succeeds for both).
Q: Will inheritance be supported in the future?
Build: AI-192.6817.14.36.5959023, 201910230206,
AI-192.6817.14.36.5959023, JRE 1.8.0_212-release-1586-b4-5784211x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.15, screens 1280x800; Retina
AS: 4.0 Canary 1; Kotlin plugin: 1.3.60-eap-25; Android Gradle Plugin: 4.0.0-alpha01; Gradle: 5.6.1; NDK: from local.properties: (not specified), latest from SDK: (not found); LLDB: pinned revision 3.1 not found, latest from SDK: (package not found); CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)