Ambient reads from default parameters do not cause recompositions [143464846]

Fixed

Bug

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Oct 28, 2019 04:03PM

Assume the following:

```
@Composable
fun FooComponent(number: Int = +ambient(NumberAmbient)) {
...
}

NumberAmbient.Provider(someChangingValue) {
FooComponent()
}
```

When the ambient value changes, because the ambient is being consumed inside the default value it looks like we are not correctly generating the code / observing changes to this ambient, so when we go to compare parameters, (my assumption is that) we see that no parameters have changed, and hence do not recompose.

The workaround is explicitly adding the `+ambient` consumption to the function body, and not in the default value, but then this defeats the point of default values. This currently causes smaller components that contain only comparable parameters, such as ProgressIndicators, to not recompose when the colour in the theme changes.

Comments

ch...@google.com <ch...@google.com> #2Oct 29, 2019 10:45PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

lp...@google.com <lp...@google.com> #3Oct 29, 2019 11:02PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ch...@google.com <ch...@google.com> #4Oct 29, 2019 11:20PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

lp...@google.com <lp...@google.com> #5Oct 30, 2019 12:43AM

deleted

ch...@google.com <ch...@google.com> #6Oct 30, 2019 04:28PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ap...@google.com <ap...@google.com> #7Oct 30, 2019 08:44PM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

an...@gmail.com <an...@gmail.com> #8Oct 31, 2019 09:51AM

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

le...@google.com <le...@google.com> #9Jan 14, 2020 07:50PM

Reassigned to le...@google.com.

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭

le...@google.com <le...@google.com> Apr 22, 2020 08:31PM

Accepted by le...@google.com.

ap...@google.com <ap...@google.com> #10May 13, 2020 08:13PM

Works perfectly fine on the latest stable and alpha versions. Did you check in my second comment if you enabled everything?

le...@google.com <le...@google.com> May 13, 2020 08:34PM

Marked as fixed.

lp...@google.com <lp...@google.com> #11Jun 3, 2020 06:56PM

Status: Assigned (reopened)

I believe so?

I copied the modifier and then used

modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    )

on my text field.

tc...@google.com <tc...@google.com> #12Jun 3, 2020 08:30PM

The auto-filling works for me with the latest alpha version, but I'm never presented with the save dialog though.

ap...@google.com <ap...@google.com> #13Jun 8, 2020 11:33PM