Alert dialog with optional text [143682374]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Oct 31, 2019 12:59PM

It seems like sometimes we need only title in an alert dialog, even if material spec says it shouldn't be the case.

Personally, I know a lot of apps where they have only title and we have this use case for Rally app as well.

WE need to reconsider API choice for AlertDialog and probably make title optional as well.

Comments

ma...@google.com <ma...@google.com> Mar 18, 2020 04:39PM

Reassigned to pa...@google.com.

cl...@google.com <cl...@google.com> #2Jul 9, 2020 09:55AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

pa...@google.com <pa...@google.com> #3Jul 9, 2020 10:56AM

Reassigned to ma...@google.com.

Title was optional from day one. I think Matvei maybe meant that he would like to see the text to be optional?

ma...@google.com <ma...@google.com> #4Jul 9, 2020 12:03PM

Reassigned to pa...@google.com.

Yeah, sorry. What I meant is than many times only title is needed, so it might be nice to have text as optional

ap...@google.com <ap...@google.com> #5Aug 7, 2020 11:42AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 45ce3f31955f388e101fb7a93a469b43c0a69646
Author: Filip Pavlis <pavlis@google.com>
Date: Tue Aug 04 12:07:45 2020

Update AlertDialog APIs.

Changes
- Removed enum for buttons layout and integrated Flow layout
- Renamed onCloseRequest to onDismissRequest
- Added contentColor and backgroudColor
- Text is now optional

In order to test it properly with screenshot test I had to change the
bitmap capturing utility to support dialogs which required additional
semantics info that I merged with the isDialog property.

Fixes: 161809319
Fixes: 143682374
Test: Added
Relnote: "AlertDialog now uses FlowRow for buttons"
Change-Id: I00ec1052c1e452380cda3a95bdb3ae5b74c5511e

M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/samples/src/main/java/androidx/compose/ui/samples/DialogSample.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogUiTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/window/Dialog.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopDialog.kt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/compose/material/studies/rally/RallyAlertDialog.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/AlertDialogSample.kt
A ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogScreenshotTest.kt
A ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidAndroidTest/kotlin/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/AndroidBitmapHelpers.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/android/WindowCapture.kt
M ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Actions.kt
A ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Utils.kt

https://android-review.googlesource.com/1385870

Issue 143682374