Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
cl...@google.com <cl...@google.com> #2
title appears to be optional (and null by default) now, is this obsolete?
pa...@google.com <pa...@google.com> #3
Title was optional from day one. I think Matvei maybe meant that he would like to see the text to be optional?
ma...@google.com <ma...@google.com> #4
Yeah, sorry. What I meant is than many times only title is needed, so it might be nice to have text
as optional
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 45ce3f31955f388e101fb7a93a469b43c0a69646
Author: Filip Pavlis <pavlis@google.com>
Date: Tue Aug 04 12:07:45 2020
Update AlertDialog APIs.
Changes
- Removed enum for buttons layout and integrated Flow layout
- Renamed onCloseRequest to onDismissRequest
- Added contentColor and backgroudColor
- Text is now optional
In order to test it properly with screenshot test I had to change the
bitmap capturing utility to support dialogs which required additional
semantics info that I merged with the isDialog property.
Fixes: 161809319
Fixes: 143682374
Test: Added
Relnote: "AlertDialog now uses FlowRow for buttons"
Change-Id: I00ec1052c1e452380cda3a95bdb3ae5b74c5511e
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/samples/src/main/java/androidx/compose/ui/samples/DialogSample.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogUiTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/window/Dialog.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopDialog.kt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/compose/material/studies/rally/RallyAlertDialog.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/AlertDialogSample.kt
A ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogScreenshotTest.kt
A ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidAndroidTest/kotlin/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/AndroidBitmapHelpers.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/android/WindowCapture.kt
M ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Actions.kt
A ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Utils.kt
https://android-review.googlesource.com/1385870
Branch: androidx-master-dev
commit 45ce3f31955f388e101fb7a93a469b43c0a69646
Author: Filip Pavlis <pavlis@google.com>
Date: Tue Aug 04 12:07:45 2020
Update AlertDialog APIs.
Changes
- Removed enum for buttons layout and integrated Flow layout
- Renamed onCloseRequest to onDismissRequest
- Added contentColor and backgroudColor
- Text is now optional
In order to test it properly with screenshot test I had to change the
bitmap capturing utility to support dialogs which required additional
semantics info that I merged with the isDialog property.
Fixes: 161809319
Fixes: 143682374
Test: Added
Relnote: "AlertDialog now uses FlowRow for buttons"
Change-Id: I00ec1052c1e452380cda3a95bdb3ae5b74c5511e
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/samples/src/main/java/androidx/compose/ui/samples/DialogSample.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/compose/ui/window/DialogUiTest.kt
M ui/ui-core/src/androidMain/kotlin/androidx/compose/ui/window/AndroidDialog.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/compose/ui/window/Dialog.kt
M ui/ui-core/src/desktopMain/kotlin/androidx/compose/ui/window/DesktopDialog.kt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialDemos.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/compose/material/studies/rally/RallyAlertDialog.kt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/AlertDialogSample.kt
A ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogScreenshotTest.kt
A ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/AlertDialog.kt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_current.txt
M ui/ui-test/src/androidAndroidTest/kotlin/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/AndroidBitmapHelpers.kt
M ui/ui-test/src/androidMain/kotlin/androidx/ui/test/android/WindowCapture.kt
M ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Actions.kt
A ui/ui-test/src/commonMain/kotlin/androidx/ui/test/Utils.kt
Description
Personally, I know a lot of apps where they have only title and we have this use case for Rally app as well.
WE need to reconsider API choice for AlertDialog and probably make title optional as well.