Request: Expose maxLines param to TextField as well [143687793]

Fixed

Feature Request

Status Update

No update yet.

Description

ig...@gmail.com

created issue #1

Nov 1, 2019 01:53AM

The param `maxLines` is not available on the TextField, only on Text. Once the only way to communicate with TextDelegate is via the components, it would be good to limit the number of lines from a TextField.

Comments

ma...@google.com <ma...@google.com> Nov 1, 2019 11:51AM

Assigned to no...@google.com.

si...@google.com <si...@google.com> #2Apr 17, 2020 07:11PM

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

no...@google.com <no...@google.com> #3Apr 17, 2020 10:33PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

so...@google.com <so...@google.com> #4Apr 23, 2020 04:28PM

#2, yeah, that's the same issue.

no...@google.com <no...@google.com> #5May 27, 2020 10:09PM

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

si...@google.com <si...@google.com> Aug 3, 2020 05:16PM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> #6Sep 14, 2020 11:56PM

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

si...@google.com <si...@google.com> #7Oct 3, 2020 11:14PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-beta01
androidx.compose.foundation:foundation-android:1.8.0-beta01
androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

so...@google.com <so...@google.com> #8Oct 5, 2020 08:11AM

comment copied from b/167396627

FYI scrolling behaviour WIP CL https://android-review.googlesource.com/c/platform/frameworks/support/+/1394667. It's planned to be moved into CoreTextField or BaseTextField (I couldn't do it earlier because cursor was not in coretextfield). We discussed it a few syncs ago and I mentioned that one frame lag was not an issue in my prototype CL.

Please let me know if you're adding the scrolling behaviour, or whether I should continue working on my CL. As I don't want us to do the duplicate work :)

si...@google.com <si...@google.com> Oct 12, 2020 11:48PM

Accepted by si...@google.com.

ap...@google.com <ap...@google.com> #9Oct 15, 2020 09:24PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d13d11623ff9d16ae7fdfb97acbe59e18a0f22df
Author: Siyamed Sinir <siyamed@google.com>
Date: Wed Oct 14 21:21:47 2020

Add maxLines to CoreTextField

Defines the CoreTextField height in terms of maximum visible
lines. Even if the final Composable height is constrained with
maxLines, it does not clip the result and lets the modifiers to
clip to the boundaries.

Test: added tests
Test: ./gradlew compose:foundation:foundation-text:test
Test: ./gradlew compose:foundation:foundation-text:connectedAndroidTest
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Test: ./gradlew compose:material:material:test
Test: ./gradlew compose:material:material:connectedAndroidTest

RelNote: “Added maxLines to CoreTextField”

Bug: 143687793
Change-Id: Ibee58be1331d36bfce70a0b14e83ffb5c0cfa3a2

M compose/foundation/foundation-text/api/current.txt
M compose/foundation/foundation-text/api/public_plus_experimental_current.txt
M compose/foundation/foundation-text/api/restricted_current.txt
A compose/foundation/foundation-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/compose/foundation/text/demos/ComposeInputFieldMinMaxLines.kt
M compose/foundation/foundation-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/compose/foundation/text/demos/TextDemos.kt
A compose/foundation/foundation-text/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/CoreTextFieldMinMaxLineTest.kt
M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt

https://android-review.googlesource.com/1459290

si...@google.com <si...@google.com> Oct 16, 2020 07:16AM

Marked as fixed.