Support for variable fonts [143703328]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Oct 31, 2019 06:23PM

Font class used to have fontVariationSettings attribute. Removed this since the integration was not complete.

We need an API for variable fonts.

Comments

ap...@google.com <ap...@google.com> #2Oct 31, 2019 11:28PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

si...@google.com <si...@google.com> #3Jan 22, 2020 08:09PM

from dupped ticket

"CSS has font-variation-settings attribute
Also check if there are commonly used settings that we can add to the API.

Note:
Tracking ticket based on

https://docs.google.com/document/d/1MzK83egP-Jghc2ZW8IcIcJkud_vMM7jgDClCv4CkO_c/edit#bookmark=id.nyju92hr2ygw"

si...@google.com <si...@google.com> #4Feb 4, 2020 02:42AM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

si...@google.com <si...@google.com> #5Apr 14, 2021 06:30PM

discussion from aosp/1672420

variable font settings can be included during font creation (for Font() functions.)

there are two parts of the story:

This font is weight X
I want to render the text in weight Y (regardless of the font weight)

si...@google.com <si...@google.com> #6Dec 2, 2021 06:27PM

important for Material.

se...@google.com <se...@google.com> Jul 21, 2022 11:42PM

Accepted by se...@google.com.

ap...@google.com <ap...@google.com> #7Aug 3, 2022 04:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022

Add font variations to Android font constructors

On O+ this will allow configuring font variation settings.

Bug:

b/143703328

Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47

M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf

https://android-review.googlesource.com/2162835

ap...@google.com <ap...@google.com> #8Aug 3, 2022 04:26PM

Project: platform/frameworks/support
Branch: androidx-main

commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022

FontVariation definition

Bug:

b/143703328

Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5

M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2161039

ap...@google.com <ap...@google.com> #9Aug 3, 2022 11:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 80e8419233f7f46dbca44236c11df5a3692030c2
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Aug 03 11:01:22 2022

Add VariableFonts to ResourceFont

Add support on Android API26+

Test: New demo
Test: ./gradlew :com:ui:ui-text:cAT && ./gradlew :com:ui;ui-text:test

Relnote: "Resource Fonts now support setting font variation settings (API 26+)."
Bug:

b/143703328

Change-Id: I900dde1f539e580a66db9c14d389ada691377c91

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontLoader.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/Font.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/ResourceFontVariationSettingsTest.kt

https://android-review.googlesource.com/2172940

ap...@google.com <ap...@google.com> #10Aug 3, 2022 11:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 7ca15e8af5b4d7167667465d7f1a3e6f571526d0
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 10:36:57 2022

Add variable fonts to DeviceFontFamilyNameFont

Relnote: "Variable font support in DeviceFontFamilyNameFont"
Test: ./gradlew :compose:ui:ui-text:cAT
Bug:

b/143703328

Change-Id: Ic1279b2dcb1c29e75b8037791179853a9f828c02

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformTypefaces.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/PlatformTypefacesTest.kt
M compose/foundation/foundation/integration-tests/foundation-demos/build.gradle

https://android-review.googlesource.com/2167512

se...@google.com <se...@google.com> #11Aug 4, 2022 04:18PM

Assigned to bu...@google.com.

Bugjuggler: b/241016309

bu...@google.com <bu...@google.com> #12Aug 4, 2022 04:18PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait for

b/241016309

to be resolved and then assign the bug to seanmcq@google.com.

ap...@google.com <ap...@google.com> #13Aug 8, 2022 09:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5dece36170360d8171c45bae69b8722e2501dd83
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Aug 04 10:46:51 2022

FontVariation.Setting is sealed interface

This will allow clamping using exaustive when.

Bug:

b/143703328

Relnote: "FontVariation.Setting is a sealed interface, to allow future clamping APIs."
Test: ./gradlew :com:ui:ui-text:checkApi
Change-Id: I110218032f9128790bf2b27ac19cfafb057e37ce

M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2175845

bu...@google.com <bu...@google.com> Jan 3, 2023 06:20PM

Assigned to se...@google.com.

se...@google.com <se...@google.com> Jan 3, 2023 06:47PM

Marked as fixed.

Issue 143703328

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Oct 31, 2019 11:28PM

si...@google.com <si...@google.com> #3Jan 22, 2020 08:09PM

si...@google.com <si...@google.com> #4Feb 4, 2020 02:42AM

si...@google.com <si...@google.com> #5Apr 14, 2021 06:30PM

si...@google.com <si...@google.com> #6Dec 2, 2021 06:27PM

se...@google.com <se...@google.com> Jul 21, 2022 11:42PM

ap...@google.com <ap...@google.com> #7Aug 3, 2022 04:26PM

ap...@google.com <ap...@google.com> #8Aug 3, 2022 04:26PM

ap...@google.com <ap...@google.com> #9Aug 3, 2022 11:29PM

ap...@google.com <ap...@google.com> #10Aug 3, 2022 11:29PM

se...@google.com <se...@google.com> #11Aug 4, 2022 04:18PM

bu...@google.com <bu...@google.com> #12Aug 4, 2022 04:18PM

ap...@google.com <ap...@google.com> #13Aug 8, 2022 09:54PM

bu...@google.com <bu...@google.com> Jan 3, 2023 06:20PM

se...@google.com <se...@google.com> Jan 3, 2023 06:47PM

Add comment

Issue metadata