Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
si...@google.com <si...@google.com> #3
si...@google.com <si...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
si...@google.com <si...@google.com> #5
discussion from aosp/1672420
variable font settings can be included during font creation (for Font() functions.)
there are two parts of the story:
- This font is weight X
- I want to render the text in weight Y (regardless of the font weight)
si...@google.com <si...@google.com> #6
important for Material.
se...@google.com <se...@google.com>
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022
Add font variations to Android font constructors
On O+ this will allow configuring font variation settings.
Bug: b/143703328
Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf
https://android-review.googlesource.com/2162835
Branch: androidx-main
commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022
Add font variations to Android font constructors
On O+ this will allow configuring font variation settings.
Bug:
Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022
FontVariation definition
Bug: b/143703328
Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5
M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
https://android-review.googlesource.com/2161039
Branch: androidx-main
commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022
FontVariation definition
Bug:
Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5
M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 80e8419233f7f46dbca44236c11df5a3692030c2
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Aug 03 11:01:22 2022
Add VariableFonts to ResourceFont
Add support on Android API26+
Test: New demo
Test: ./gradlew :com:ui:ui-text:cAT && ./gradlew :com:ui;ui-text:test
Relnote: "Resource Fonts now support setting font variation settings (API 26+)."
Bug: b/143703328
Change-Id: I900dde1f539e580a66db9c14d389ada691377c91
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontLoader.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/Font.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/ResourceFontVariationSettingsTest.kt
https://android-review.googlesource.com/2172940
Branch: androidx-main
commit 80e8419233f7f46dbca44236c11df5a3692030c2
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Aug 03 11:01:22 2022
Add VariableFonts to ResourceFont
Add support on Android API26+
Test: New demo
Test: ./gradlew :com:ui:ui-text:cAT && ./gradlew :com:ui;ui-text:test
Relnote: "Resource Fonts now support setting font variation settings (API 26+)."
Bug:
Change-Id: I900dde1f539e580a66db9c14d389ada691377c91
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontLoader.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/Font.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/ResourceFontVariationSettingsTest.kt
ap...@google.com <ap...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-main
commit 7ca15e8af5b4d7167667465d7f1a3e6f571526d0
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 10:36:57 2022
Add variable fonts to DeviceFontFamilyNameFont
Relnote: "Variable font support in DeviceFontFamilyNameFont"
Test: ./gradlew :compose:ui:ui-text:cAT
Bug: b/143703328
Change-Id: Ic1279b2dcb1c29e75b8037791179853a9f828c02
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformTypefaces.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/PlatformTypefacesTest.kt
M compose/foundation/foundation/integration-tests/foundation-demos/build.gradle
https://android-review.googlesource.com/2167512
Branch: androidx-main
commit 7ca15e8af5b4d7167667465d7f1a3e6f571526d0
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 10:36:57 2022
Add variable fonts to DeviceFontFamilyNameFont
Relnote: "Variable font support in DeviceFontFamilyNameFont"
Test: ./gradlew :compose:ui:ui-text:cAT
Bug:
Change-Id: Ic1279b2dcb1c29e75b8037791179853a9f828c02
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformTypefaces.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/PlatformTypefacesTest.kt
M compose/foundation/foundation/integration-tests/foundation-demos/build.gradle
bu...@google.com <bu...@google.com> #12
Hi. I've received your bug and will wait for b/241016309 to be resolved and then assign the bug to seanmcq@google.com.
ap...@google.com <ap...@google.com> #13
Project: platform/frameworks/support
Branch: androidx-main
commit 5dece36170360d8171c45bae69b8722e2501dd83
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Aug 04 10:46:51 2022
FontVariation.Setting is sealed interface
This will allow clamping using exaustive when.
Bug: b/143703328
Relnote: "FontVariation.Setting is a sealed interface, to allow future clamping APIs."
Test: ./gradlew :com:ui:ui-text:checkApi
Change-Id: I110218032f9128790bf2b27ac19cfafb057e37ce
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
https://android-review.googlesource.com/2175845
Branch: androidx-main
commit 5dece36170360d8171c45bae69b8722e2501dd83
Author: Sean McQuillan <seanmcq@google.com>
Date: Thu Aug 04 10:46:51 2022
FontVariation.Setting is sealed interface
This will allow clamping using exaustive when.
Bug:
Relnote: "FontVariation.Setting is a sealed interface, to allow future clamping APIs."
Test: ./gradlew :com:ui:ui-text:checkApi
Change-Id: I110218032f9128790bf2b27ac19cfafb057e37ce
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
Description
We need an API for variable fonts.