Fixed
Status Update
No update yet.
Comments
jb...@google.com
ap...@google.com
since these are in public API (:/) we need to do this in 1.2
ap...@google.com
since it is already marked as deprecated, we can probably do it by now.
jb...@google.com
Opening diff shortly
jb...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
an...@google.com
The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/ )
Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6205454677704704/#/cherrypickHistory/all )
Created: 2019-11-16 01:24:35.655426+00:00
Changes: aosp/1158564, aosp/1157502
Release Track: (
Created: 2019-11-16 01:24:35.655426+00:00
Changes: aosp/1158564, aosp/1157502
st...@sieveo.com
Hi everyone
I encountered this bug even though I am on the Navigation 2.2.0-rc03 release - however only when I do a release build of my app with minification enabled.
During normal debug I did not encounter crashes, but when I turn on minification in my debug build I get this crash.
As I work around I changed my layout to use "fragment" instead of "FragmentContainerView" in my xml.
I encountered this bug even though I am on the Navigation 2.2.0-rc03 release - however only when I do a release build of my app with minification enabled.
During normal debug I did not encounter crashes, but when I turn on minification in my debug build I get this crash.
As I work around I changed my layout to use "fragment" instead of "FragmentContainerView" in my xml.
jb...@google.com
That issue is caused by a limitation of aapt2 and is being tracked by
Description
Version used: 2.2.0-r01
Devices/Android versions reproduced on: Android 9.0.0
If NavHostFragment is declared in FragmentContainerView it won't set its NavController's graph when it is recreated from configuration change. I believe the reason for this is that FragmentContainerView, unlike <fragment> tag, doesn't call fragment's onInflate() when it was recreated by FragmentManager, and NavHostFragment sets its mGraphId variable only in onInflate(). So when NavHostFragment is recreated its graph is lost.