Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit baaf6845487edfe94fb470730d35f1f9cfbae190
Author: Hai Zhang <zhanghai@google.com>
Date: Tue Oct 01 11:58:25 2019
Fix FastScroller when layout direction is RTL.
The canvas needs to be mirrored again to restore its scaling, and the
touchable width for RTL thumb should still be its full width instead
of only the left half.
Fixes: 143789932
Test: Manually verified
Change-Id: I89d3aa1945038d915d3c9f4ef5dd01120e6d0c3f
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/FastScroller.java
https://android-review.googlesource.com/1130438
Branch: androidx-master-dev
commit baaf6845487edfe94fb470730d35f1f9cfbae190
Author: Hai Zhang <zhanghai@google.com>
Date: Tue Oct 01 11:58:25 2019
Fix FastScroller when layout direction is RTL.
The canvas needs to be mirrored again to restore its scaling, and the
touchable width for RTL thumb should still be its full width instead
of only the left half.
Fixes: 143789932
Test: Manually verified
Change-Id: I89d3aa1945038d915d3c9f4ef5dd01120e6d0c3f
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/FastScroller.java
Description
In FastScroller.drawVerticalScrollbar() , it is calling Canvas.scale() .
canvas.scale(1, 1)
to restore the mirroring for RTL, however it should actually becanvas.scale(-1, 1)
, and the former one is a no-op according toMeanwhile, the touchable width of the scrollbar in RTL should still be its full width, so there's no need to divide it by 2 in FastScroller.isPointInsideVerticalThumb() .