Fixed
Status Update
Comments
ra...@google.com <ra...@google.com>
ra...@google.com <ra...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 60ae0eec2a32396c22ad92502cde952c80d514a0
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Mar 09 17:03:05 2020
Add the ability to query by using a `WorkQuery`.
Relnote: "Added the ability to query for `WorkInfo`s by using a `WorkQuery`.
This is useful when developers want to query `WorkInfo`s by a combination of
multiple attributes."
Test: Added RawWorkInfoDaoTest.
Fixes: b/143847546
Change-Id: Ie9f0f46f4c05fc1fd33db4d842d24d48e0a8a3b0
A work/workmanager/api/2.4.0-alpha02.ignore
M work/workmanager/api/2.4.0-alpha02.txt
M work/workmanager/api/current.txt
M work/workmanager/api/public_plus_experimental_2.4.0-alpha02.txt
M work/workmanager/api/public_plus_experimental_current.txt
A work/workmanager/api/restricted_2.4.0-alpha02.ignore
M work/workmanager/api/restricted_2.4.0-alpha02.txt
M work/workmanager/api/restricted_current.txt
M work/workmanager/src/androidTest/java/androidx/work/DatabaseTest.java
A work/workmanager/src/androidTest/java/androidx/work/RawWorkInfoDaoTest.kt
M work/workmanager/src/main/java/androidx/work/WorkManager.java
A work/workmanager/src/main/java/androidx/work/WorkQuery.java
M work/workmanager/src/main/java/androidx/work/impl/WorkDatabase.java
M work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java
A work/workmanager/src/main/java/androidx/work/impl/model/RawWorkInfoDao.java
A work/workmanager/src/main/java/androidx/work/impl/utils/RawQueries.java
M work/workmanager/src/main/java/androidx/work/impl/utils/StatusRunnable.java
https://android-review.googlesource.com/1253230
Branch: androidx-master-dev
commit 60ae0eec2a32396c22ad92502cde952c80d514a0
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Mon Mar 09 17:03:05 2020
Add the ability to query by using a `WorkQuery`.
Relnote: "Added the ability to query for `WorkInfo`s by using a `WorkQuery`.
This is useful when developers want to query `WorkInfo`s by a combination of
multiple attributes."
Test: Added RawWorkInfoDaoTest.
Fixes:
Change-Id: Ie9f0f46f4c05fc1fd33db4d842d24d48e0a8a3b0
A work/workmanager/api/2.4.0-alpha02.ignore
M work/workmanager/api/2.4.0-alpha02.txt
M work/workmanager/api/current.txt
M work/workmanager/api/public_plus_experimental_2.4.0-alpha02.txt
M work/workmanager/api/public_plus_experimental_current.txt
A work/workmanager/api/restricted_2.4.0-alpha02.ignore
M work/workmanager/api/restricted_2.4.0-alpha02.txt
M work/workmanager/api/restricted_current.txt
M work/workmanager/src/androidTest/java/androidx/work/DatabaseTest.java
A work/workmanager/src/androidTest/java/androidx/work/RawWorkInfoDaoTest.kt
M work/workmanager/src/main/java/androidx/work/WorkManager.java
A work/workmanager/src/main/java/androidx/work/WorkQuery.java
M work/workmanager/src/main/java/androidx/work/impl/WorkDatabase.java
M work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java
A work/workmanager/src/main/java/androidx/work/impl/model/RawWorkInfoDao.java
A work/workmanager/src/main/java/androidx/work/impl/utils/RawQueries.java
M work/workmanager/src/main/java/androidx/work/impl/utils/StatusRunnable.java
Description
`workManager.getWorkInfosForUniqueWorkLiveData(TAG)`
The pain point with this is that this gives you all the completed workers' workInfos as well. If the intention is only to observe the status of the currently running workers, it requires a call to pruneWork() which seems like an anti-pattern. A work around with the current apis would be to create unique tags for each work but then again that's a pain to maintain if you have a complicated use case.
What I propose is a builder method along with this api to be able to put in simple filters like status of the worker(BLOCKED, ENQUEUED, RUNNING, SUCCEEDED) to begin with. Have got a thumbs-up from Rahul Ravikumar from the Toolkit team on this.