Remove Surface can have only one child requirement [144488459]

Fixed

Bug

Status Update

No update yet.

Description

an...@google.com

created issue #1

Nov 14, 2019 02:41PM

We can probably use Stack inside Surface instead

Comments

le...@google.com <le...@google.com> #2Nov 14, 2019 06:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024

[M2 text field] Apply background to decoration box

...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.

Fixes:

b/307694651

Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/3046833

al...@gmail.com <al...@gmail.com> #3Nov 28, 2020 01:54AM

+1 I think at the very least it would be nice for Surface to use Box internally... unless there is some reason why the material design library wants to explicitly disallow stacking multiple children on top of each other in a Surface.

nu...@gmail.com <nu...@gmail.com> #4Nov 28, 2020 02:12AM

ps://ct.captcha-delivery.com/c.js"></script></body

nu...@gmail.com <nu...@gmail.com> #5Nov 28, 2020 02:13AM

https://issuetracker.google.com/issues/167690006

an...@google.com <an...@google.com> Dec 15, 2020 10:59AM

Reassigned to ma...@google.com.

po...@google.com <po...@google.com> Dec 15, 2020 02:10PM

Reassigned to po...@google.com.

ap...@google.com <ap...@google.com> #6Jan 15, 2021 05:34PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e3a2f689973488ea0e567a0575a421ebae1fdd51
Author: Mihai Popa <popam@google.com>
Date: Tue Dec 15 16:17:42 2020

Use Box in Surface

Relnote: Surface can now have multiple layout children.
Fixes: 144488459
Test: built and ran demos
Change-Id: I66a921f3963162ae62cdb498298e6aa4210cf602

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Surface.kt

https://android-review.googlesource.com/1544447