Lint's Gradle task hangs after update to AGP 3.6.0-beta04 [144513656]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

fk...@gmail.com

created issue #1

Nov 15, 2019 06:53AM

Studio Build: 3.6.0-beta04
Version of Gradle Plugin: 3.6.0-beta04 (same with beta03)
Version of Gradle: 6.0 (but also reproducible with 5.6.3)
Version of Java: OpenJDK8 build 1.8.0_222-ga
OS: Linux desktop 5.3.8 #1-NixOS SMP Tue Oct 29 08:22:48 UTC 2019 x86_64 GNU/Linux

Steps to Reproduce:
1. Run ./gradlew lintDebug

Result:
Task doesn't complete (or at least it doesn't complete for 30+ minutes)

Expected result:
Lint task should take roughly same time as with AGP 3.5.2

Additional information:
With AGP 3.5.2 it usually takes about 5-6 minutes to complete lintDebug on this project.
However lintVitalRelease task completes fine even with AGP 3.6.0-beta04.
Also if we disable all checks and enable only single one for example

lintOptions {
check 'NewApi'
}

then lintDebug task completes in less than 1 minute regardless of AGP version.

GradleDaemon.txt

106 KB

View

Download

GradleWrapperMain.txt

10 KB

View

Download

jps.txt

1 KB

View

Download

Comments

je...@google.com <je...@google.com> Nov 18, 2019 05:35PM

Assigned to ga...@google.com.

ga...@google.com <ga...@google.com> #2Nov 21, 2019 03:56PM

Reassigned to tn...@google.com.

Can you also share Android studio version and host operating system details.

fk...@gmail.com <fk...@gmail.com> #3Nov 21, 2019 04:31PM

Android Studio 3.3 Canary 11
Build #AI-182.4323.46.33.5012296, built on September 15, 2018
JRE: 1.8.0_152-release-1248-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 Pro 10.0

fk...@gmail.com <fk...@gmail.com> #4Dec 12, 2019 10:33AM

http://crash/browse?q=stable_signature='com.android.diagnostic.LoggerErrorMessage+at+com.android.tools.idea.sdk.progress.StudioLoggerProgressIndicator.logError-dccc3d70'

ga...@google.com <ga...@google.com> #5Dec 12, 2019 05:56PM

Pending ag/5854860.

fk...@gmail.com <fk...@gmail.com> #6Dec 13, 2019 02:35PM

Promoting to P1 as this affects all cases when a fallback repo source is being called into.

ga...@google.com <ga...@google.com> #7Dec 13, 2019 04:34PM

Reassigned to ra...@google.com.

Fixed how? (Starting in what version?)

tn...@google.com <tn...@google.com> #8Dec 21, 2019 11:02PM

It looks to me like probably 3.4 canary 10, since I believe that was the next build after the change (Ib0212be) and indeed I don't (yet?) see any reports of the error starting in 3.4.0.10.

tn...@google.com <tn...@google.com> #9Jan 18, 2020 12:54AM

Marked as fixed, reassigned to tn...@google.com.

I love it

fk...@gmail.com <fk...@gmail.com> #10Jan 20, 2020 10:14AM

So I'm getting this bug still in `Android Support` plugin that is bundled with IntelliJ:

```
java.lang.Throwable: Progress subrange out of bounds: 2.949999999999999
at com.intellij.openapi.diagnostic.Logger.error(Logger.java:145)
at com.android.tools.idea.sdk.progress.StudioLoggerProgressIndicator.logError(StudioLoggerProgressIndicator.java:47)
at com.android.repository.api.DelegatingProgressIndicator.lambda$logError$8(DelegatingProgressIndicator.java:103)
at java.util.concurrent.ConcurrentHashMap$KeySetView.forEach(ConcurrentHashMap.java:4649)
at com.android.repository.api.DelegatingProgressIndicator.logError(DelegatingProgressIndicator.java:103)
at com.android.repository.api.ProgressIndicator.createSubProgress(ProgressIndicator.java:124)
at com.android.repository.impl.manager.RemoteRepoLoaderImpl.processSource(RemoteRepoLoaderImpl.java:262)
at com.android.repository.impl.manager.RemoteRepoLoaderImpl.fetchPackages(RemoteRepoLoaderImpl.java:187)
at com.android.repository.impl.manager.RepoManagerImpl$LoadTask.run(RepoManagerImpl.java:553)
at com.android.repository.api.RepoManager$DummyProgressRunner.runSyncWithProgress(RepoManager.java:397)
at com.android.repository.impl.manager.RepoManagerImpl.load(RepoManagerImpl.java:365)
at com.android.repository.api.RepoManager.loadSynchronously(RepoManager.java:290)
at com.android.tools.idea.updater.SdkComponentSource.initIfNecessary(SdkComponentSource.java:74)
at com.android.tools.idea.updater.SdkComponentSource.getComponents(SdkComponentSource.java:141)
at com.android.tools.idea.updater.SdkComponentSource.getAvailableVersions(SdkComponentSource.java:122)
at com.intellij.openapi.updateSettings.impl.UpdateChecker.checkExternalUpdates(UpdateChecker.kt:296)
at com.intellij.openapi.updateSettings.impl.UpdateChecker.doUpdateAndShowResult(UpdateChecker.kt:139)
at com.intellij.openapi.updateSettings.impl.UpdateChecker.access$doUpdateAndShowResult(UpdateChecker.kt:50)
at com.intellij.openapi.updateSettings.impl.UpdateChecker$updateAndShowResult$1.run(UpdateChecker.kt:81)
at com.intellij.openapi.application.impl.ApplicationImpl$1.run(ApplicationImpl.java:311)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```

IntelliJ IDEA 2019.1 (Ultimate Edition)
Build #IU-191.6183.87, built on March 27, 2019
Licensed to Gareth Jones
Subscription is active until June 22, 2019
JRE: 1.8.0_202-release-1483-b39 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

It's been going on for quite a while. IntelliJ doesn't tell me what version of the plugin I've got.

Any chance of some more information about the state of this bug & its fix?

da...@spotify.com <da...@spotify.com> #11Jan 29, 2020 03:01PM

tn... ;) In your example that you gave jetbrains, ServerSettingsModelImpl, it's also similarly fast if you don't use an anonymous class, but rather make the lambda types explicit, e.g. (User user, List<String> locales) ->

js...@twitter.com <js...@twitter.com> #12Feb 5, 2020 10:01PM

We've encountered this issue in AGP 3.6-0-rc02. Will this be included in 3.6 as well?

tn...@google.com <tn...@google.com> #13Feb 5, 2020 10:16PM

Sorry, the fix is too risky for 3.6; it's a pretty massive change (with updates to a whole new stack of parsing libraries from IntelliJ and Kotlin, with parts of it based on the 193-branch of IntelliJ which is only compatible with Studio 4.0; 3.6 was based on 192.)

The fix is part of 4.0 canary 8 and later if switching to that is an option; it will be in beta soon. If not, one option is to use the workaround suggested by David in

comment #11

(thanks!) to rewrite your code with explicit lambda types. Another, if you mainly care about performance on the CI server, is to configure lint to run with its own version, e.g. something like this (where for your lint task on your CI server, you've set the given environment variable, and you're doing a separate job for lint than for regular release builds):

...
repositories {
google()
jcenter()
}
dependencies {
if ("true" == System.getenv("LINT_CI_JOB")) {
// Running lint on the CI server. Not for release builds.
classpath "com.android.tools.build:gradle:4.0.0-alpha08"
} else {
classpath "com.android.tools.build:gradle:3.6.0-rc02"
}
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"

Obviously for this your build would need to work on both versions (4.0-alpha08 and 3.6) so you'd need to for example use the latest Gradle version required by 4.0.

Message last modified on Feb 5, 2020 10:16PM

tn...@google.com <tn...@google.com> #14Feb 5, 2020 10:28PM

Actually, I was wrong, the performance fix isn't in canary 8, it's in beta 1. Should be released very soon now.

ey...@gmail.com <ey...@gmail.com> #15Feb 26, 2020 09:52PM

Not sure if this is related, but I've been using 3.6.0 RC and Lint is fine. I just tried with 4.0 Beta 1 and the run time more than doubled. I filed https://issuetracker.google.com/issues/150292219

dg...@lightricks.com <dg...@lightricks.com> #16Mar 4, 2020 08:24AM

Hi,
It is really important to put this in the list of known issues here:

https://developer.android.com/studio/releases/gradle-plugin. i wasted on the analysis of this issue one day and this is really a blocker for me to upgrade to android 3.6
Additionally it would be nice to have a workaround for this issue. I want to have view bindings. but this is not a must

Thanks

[Deleted User] <[Deleted User]> #17Apr 24, 2020 12:54PM

For one of the projects I'm contributing to using 4.0.0-beta05 appears to have resolved the issue with Lint taking a very long time.

tn...@google.com <tn...@google.com> #18Apr 24, 2020 01:48PM

Yes, that was the fix for issue 150292219 which went into 4.0 beta 5.

da...@gmail.com <da...@gmail.com> #19Jun 11, 2020 01:10AM

Now that 4.0 is out, I'm trying to update to this, but in a multi-module project I run the following command:

./gradlew ${module}:lint${flavor}Debug --debug

I get this as a continual output in the logcaat and the job never finishes:

${timeStamp} [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Completing Build operation 'Resolve files of :${module}:${flavor}DebugRuntimeClasspath'
${timeStamp} [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Build operation 'Resolve files of :${module}:${flavor}DebugRuntimeClasspath' completed
${timeStamp} [INFO] [org.gradle.api.internal.file.collections.DirectoryFileTree] file or directory '{$proectPath}/${dependentModule}/build/intermediates/lint_publish_jar/global/lint.jar', not found
${timeStamp} [INFO] [org.gradle.api.internal.file.collections.DirectoryFileTree] file or directory '${proectPath}/${dependentModule}/build/intermediates/lint_publish_jar/global/lint.jar', not found
${timeStamp} [org.gradle.api.internal.file.collections.DirectoryFileTree] file or directory '${proectPath}/${dependentModule}/build/intermediates/lint_publish_jar/global/lint.jar', not found
${timeStamp} [org.gradle.api.internal.file.collections.DirectoryFileTree] file or directory '${proectPath}/${dependentModule}/build/intermediates/lint_publish_jar/global/lint.jar', not found
${timeStamp} [org.gradle.api.internal.file.collections.DirectoryFileTree] file or directory '${proectPath}/${dependentModule}/build/intermediates/lint_publish_jar/global/lint.jar', not found
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] 
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire shared lock on daemon addresses registry.
${timeStamp} [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
202

It just sits there and cycles thru and thru.

I should say that each ${dependentModule} has lintChecks project(:customLint}, but even if I remove the lintChecks, it still get stuck in this loop.

Message last modified on Jun 11, 2020 01:14AM

Issue 144513656

Description

Issue summary

Comments

je...@google.com <je...@google.com> Nov 18, 2019 05:35PM

ga...@google.com <ga...@google.com> #2Nov 21, 2019 03:56PM

fk...@gmail.com <fk...@gmail.com> #3Nov 21, 2019 04:31PM

fk...@gmail.com <fk...@gmail.com> #4Dec 12, 2019 10:33AM

ga...@google.com <ga...@google.com> #5Dec 12, 2019 05:56PM

fk...@gmail.com <fk...@gmail.com> #6Dec 13, 2019 02:35PM

ga...@google.com <ga...@google.com> #7Dec 13, 2019 04:34PM

tn...@google.com <tn...@google.com> #8Dec 21, 2019 11:02PM

tn...@google.com <tn...@google.com> #9Jan 18, 2020 12:54AM

fk...@gmail.com <fk...@gmail.com> #10Jan 20, 2020 10:14AM

da...@spotify.com <da...@spotify.com> #11Jan 29, 2020 03:01PM

js...@twitter.com <js...@twitter.com> #12Feb 5, 2020 10:01PM

tn...@google.com <tn...@google.com> #13Feb 5, 2020 10:16PM

tn...@google.com <tn...@google.com> #14Feb 5, 2020 10:28PM

ey...@gmail.com <ey...@gmail.com> #15Feb 26, 2020 09:52PM

dg...@lightricks.com <dg...@lightricks.com> #16Mar 4, 2020 08:24AM

[Deleted User] <[Deleted User]> #17Apr 24, 2020 12:54PM

tn...@google.com <tn...@google.com> #18Apr 24, 2020 01:48PM

da...@gmail.com <da...@gmail.com> #19Jun 11, 2020 01:10AM

Add comment

Issue metadata