DocumentsActivity crashes with NullPointerException when selecting an SD Card using ACTION_OPEN_DOCUMENT_TREE [144667392]

Infeasible

Bug

Status Update

No update yet.

Description

ms...@gmail.com

created issue #1

Nov 18, 2019 07:37AM

We're trying to implement the new Documents framework in Lollipop for getting write access to an external SD Card. I launch an intent with Intent.ACTION_OPEN_DOCUMENT_TREE which opens up the Documents activity. After showing the SD Cards, it lists two storage locations, one which has an empty name and another named Internal storage. You can see this in the screenshot attached. If you choose the external sd card which shows up with no name, the Activity crashes and has to be forced closed with the following stacktrace:

01-20 16:20:08.998 29153-29153/? E/AndroidRuntime﹕ FATAL EXCEPTION: main
Process: com.android.documentsui, PID: 29153
java.lang.NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference
at android.text.SpannableStringBuilder.replace(SpannableStringBuilder.java:454)
at android.text.TextUtils.expandTemplate(TextUtils.java:912)
at com.android.documentsui.PickFragment.setPickTarget(PickFragment.java:85)
at com.android.documentsui.DocumentsActivity.onCurrentDirectoryChanged(DocumentsActivity.java:882)
at com.android.documentsui.DocumentsActivity.access$400(DocumentsActivity.java:94)
at com.android.documentsui.DocumentsActivity$PickRootTask.onPostExecute(DocumentsActivity.java:951)
at com.android.documentsui.DocumentsActivity$PickRootTask.onPostExecute(DocumentsActivity.java:927)
at android.os.AsyncTask.finish(AsyncTask.java:632)
at android.os.AsyncTask.access$600(AsyncTask.java:177)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:645)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:135)
at android.app.ActivityThread.main(ActivityThread.java:5240)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)

I would probably guess that this is occurring because the external SD Card doesn't seem to have a name or title.

This is occuring on an Nvidia SHIELD Tablet running android version 5.0.1

I'm also attaching the dump from adb bugreport

Comments

ve...@google.com <ve...@google.com> #2Nov 18, 2019 07:44AM

Assigned to ve...@google.com.

sgtm, we can add the same API for FileSpec:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/compiler-processing/src/main/java/androidx/room/compiler/processing/XFiler.kt;l=28?q=XFiler.kt&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

I recommend using github for a small checkout size: https://github.com/androidX/androidx

Looks like we do have kotlin poet in the repo: https://github.com/androidx/androidx/blob/androidx-main/buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt#L75

So just need to add it as an API dependency to the room-compiler-processing's build file.

If you can add a test to the generated code match test, that would be great: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/GeneratedCodeMatchTest.kt

lmk if you hit any blocker in getting started, thanks!

ve...@google.com <ve...@google.com> #3Nov 25, 2019 10:59AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4a2360456d817b3101f289aac55ea1f3f610cfef
Author: Gabriel Freitas Vasconcelos <gfreivasc@gmail.com>
Date: Thu Mar 11 14:54:53 2021

[GH] Adds KotlinPoet integration to Room Processing

## Proposed Changes

Adds `write()` method that accepts KotlinPoet's an instance of
`FileSpec`. Also adds KotlinPoet as an API dependency and an extension
function similar to that of JavaPoet.

## Testing

Test: ./gradlew test connectedCheck without benchmarks

## Fixes
Fixes: [

b/182195680

](

https://issuetracker.google.com/issues/182195680)

This is an imported pull request from

https://github.com/androidx/androidx/pull/137.

Resolves #137
Github-Pr-Head-Sha: 96dc315b7e0e417e6a5e3d8cd6a8adda5c1b6c6a
GitOrigin-RevId: c5e4de3ab28fed968982e572c47b5ff07d210af7
Change-Id: I9d3aaa0a752447d9ba3978ce3fb705c0e74b3d13

M room/compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt
M room/compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/Source.kt
M room/compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/GeneratedCodeMatchTest.kt
M room/compiler-processing/build.gradle
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/XFiler.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacFiler.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/javac/JavacProcessingEnv.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspFiler.kt
M room/compiler/src/test/kotlin/androidx/room/testing/test_util.kt

https://android-review.googlesource.com/1627560

tf...@gmail.com <tf...@gmail.com> #4Nov 26, 2019 02:33AM

All

ad...@google.com <ad...@google.com> Nov 28, 2019 06:42AM

Reassigned to vi...@google.com.

vi...@google.com <vi...@google.com> #5Dec 4, 2019 10:12AM

Status: Won't Fix (Infeasible)

We are closing this issue as we don't have enough actionable information. If you are still facing this problem, please open new issue and add the relevant information along with reference to earlier issue.

Issue 144667392