Memory leaks in Biometric library [144919472]

Fixed

Bug

Status Update

No update yet.

Description

dm...@gmail.com

created issue #1

Nov 21, 2019 07:38PM

Artifact used: androidx.biometric:biometric:1.0.0

Devices/Android versions reproduced on:
Emulator 25 API, X86 (behaves the same on all versions)
Android version 7.1.1

Code:

https://github.com/Dimezis/BiometricBugs

Steps:
Have a stored fingerprint on the device.
Launch the example app, see the fingerprint dialog.
Rotate the screen.
See 2 leaks in LeakCanary.

Frequency:
Each time on rotation.

Leak #1:

androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: NO (a class is never leaking)
│ GC Root: System class
│ ↓ static DeviceCredentialHandlerBridge.sInstance
│ ~~~~~~~~~
├─ androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: UNKNOWN
│ ↓ DeviceCredentialHandlerBridge.mAuthenticationCallback
│ ~~~~~~~~~~~~~~~~~~~~~~~
├─ com.eightbitlab.biometricbugs.MainActivity$onCreate$1
│ Leaking: UNKNOWN
│ Anonymous subclass of androidx.biometric.BiometricPrompt$AuthenticationCallback
│ ↓ MainActivity$onCreate$1.this$0

Leak #2:

┬
├─ androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: NO (a class is never leaking)
│ GC Root: System class
│ ↓ static DeviceCredentialHandlerBridge.sInstance
│ ~~~~~~~~~
├─ androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: UNKNOWN
│ ↓ DeviceCredentialHandlerBridge.mOnClickListener
│ ~~~~~~~~~~~~~~~~
├─ androidx.biometric.BiometricPrompt$1
│ Leaking: UNKNOWN
│ Anonymous class implementing android.content.DialogInterface$OnClickListener
│ ↓ BiometricPrompt$1.this$0
│ ~~~~~~
├─ androidx.biometric.BiometricPrompt
│ Leaking: UNKNOWN
│ ↓ BiometricPrompt.mFingerprintDialogFragment
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~
╰→ androidx.biometric.FingerprintDialogFragment
Leaking: YES (Fragment#mFragmentManager is null and ObjectWatcher was watching this)
key = 42dbc3ac-2321-40a0-bfd4-4f74044ca615
watchDurationMillis = 2137697
retainedDurationMillis = 2132696

Another leak, that is not reported by LeakCanary right now is a non-static child of Handler in FingerprintDialogFragment.
Lint gives you a warning:
This Handler class should be static or leaks might occur.

Comments

dm...@gmail.com <dm...@gmail.com> #2Nov 21, 2019 07:46PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019

API lint check for the MinMaxConstant is enabled for androidx

Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25

M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java

https://android-review.googlesource.com/1114511

https://goto.google.com/android-sha1/64f11e5722d8a574ccb72bfb042fa89f51129c68

[Deleted User] <[Deleted User]> #3Nov 27, 2019 10:09AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019

API lint check for the SetterReturnsThis is enabled for androidx

Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1123398

https://goto.google.com/android-sha1/536a1ff3c3c7623ef60ef89b45266afd63ca748f

[Deleted User] <[Deleted User]> #4Nov 27, 2019 10:35AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019

API lint check for the PackageLayering is enabled for androidx

PackageLayering is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126765

https://goto.google.com/android-sha1/8aecbea988804f4f702812f6e7f50bc60359eed1

mo...@gmail.com <mo...@gmail.com> #5Jan 21, 2020 05:11PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 7426c6889ba80df99b2589454d0f604e0efd7b78
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:39:30 2019

API lint check for the OverlappingConstants is enabled for androidx

OverlappingConstants is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I312b39963b0b64e06a3bd5933156dc88bff76a1c

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126766

https://goto.google.com/android-sha1/7426c6889ba80df99b2589454d0f604e0efd7b78

cu...@google.com <cu...@google.com> Jan 28, 2020 09:08PM

Reassigned to cu...@google.com.

ap...@google.com <ap...@google.com> #6Feb 4, 2020 10:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9108b6016c27854f67c529a98506f93ff3631a26
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:50:54 2019

API lint check for the IllegalStateException is enabled for androidx

IllegalStateException is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I025bd3b1ade7204b78b6c66b2b205a99ccc701cc

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126767

https://goto.google.com/android-sha1/9108b6016c27854f67c529a98506f93ff3631a26

ap...@google.com <ap...@google.com> #7Feb 4, 2020 10:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2f50846ff288d3e18f197cb9243b40c971438e7e
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 30 22:36:57 2019

API lint check for the PackageLayering is disabled for androidx

PackageLayering is moved to the
"// The list of checks that are hidden as they are not useful in androidx"
section in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ib9cfe9d0a64f9a19b1c28a28762f38da5fe61169

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1131079

https://goto.google.com/android-sha1/2f50846ff288d3e18f197cb9243b40c971438e7e

dk...@fundrise.com <dk...@fundrise.com> #8Mar 10, 2020 06:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 130035de9b227f0bedf6a4380f0a7dec89f41501
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 23 00:05:26 2019

API lint check for the ListenerLast is enabled for androidx

Existing issues are suppressed with updated baseline and the
ListenerLast is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ibc5ff8601a56c7d43793a1f0902d69468963c134

M appcompat/api/api_lint.ignore
M browser/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M media/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M ui/ui-foundation/api/api_lint.ignore

https://android-review.googlesource.com/1126768

https://goto.google.com/android-sha1/130035de9b227f0bedf6a4380f0a7dec89f41501

lo...@gmail.com <lo...@gmail.com> #9Apr 28, 2020 08:45AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a509937bc0bf65df2a6e62882c5dcec5015e5e37
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Sep 11 19:12:07 2019

API lint check for the MissingBuild is enabled for androidx

Existing issues are suppressed with updated baseline and the
MissingBuild is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I407b60c1f717b8ad1c8b1c5a17aa2aba68824305

M appcompat/api/api_lint.ignore
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M car/core/api/api_lint.ignore
M core/core/api/api_lint.ignore
M navigation/navigation-common-ktx/api/api_lint.ignore
A navigation/navigation-runtime/api/api_lint.ignore
M paging/rxjava2/api/api_lint.ignore
A palette/palette/api/api_lint.ignore
M slices/builders/api/api_lint.ignore
M sqlite/sqlite/api/api_lint.ignore
M ui/ui-animation-core/api/api_lint.ignore
M ui/ui-core/api/api_lint.ignore

https://android-review.googlesource.com/1119191

https://goto.google.com/android-sha1/a509937bc0bf65df2a6e62882c5dcec5015e5e37

ap...@google.com <ap...@google.com> #10Jul 31, 2020 09:16PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b472cbf0b66dda85bc2a176136f5a01c905be944
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Oct 07 22:43:56 2019

API lint check for the IntentBuilderName is commented

The IntentBuilderName is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I2e6e5cd63f0b126b1c9388885abfc00c8289c2c7

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1115101

https://goto.google.com/android-sha1/b472cbf0b66dda85bc2a176136f5a01c905be944

cu...@google.com <cu...@google.com> #11Jul 31, 2020 10:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 00d7cd7c0920cee6cc6c9674f524e8a8fc4432cf
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Mon Sep 09 23:54:22 2019

API lint check for the OnNameExpected is commented

The OnNameExpected is placed under
"// We should only treat these as warnings"
comment in the --hide section of the API_LINT_ARGS

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I07892f5fcc61f40db2d2b13e310e767831ab8c0f

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1116042

https://goto.google.com/android-sha1/00d7cd7c0920cee6cc6c9674f524e8a8fc4432cf

mi...@gmail.com <mi...@gmail.com> #12Aug 26, 2020 12:20AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 11c11aa2f9d391c3616900ef7edd882d49c8b2d7
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Thu Oct 17 23:11:48 2019

API lint check for the AbstractInner is enabled for androidx

AbstractInner is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I0a82569652a064f76cb84233fe865d17b9337d11

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1145728

https://goto.google.com/android-sha1/11c11aa2f9d391c3616900ef7edd882d49c8b2d7

na...@gmail.com <na...@gmail.com> #13Dec 10, 2020 08:01AM

Project: platform/tools/metalava
Branch: master

commit cbccc81cd841437d587360a423aa88afdcf5ce49
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Oct 22 13:03:22 2019

Indicate the methods that cause the requirements to implement AutoClosable

Method descriptions added to warning message

Bug: 138602561

Test: ./gradlew test
Change-Id: Ibb2b48b83c9b5170dc9b03b21038d652b094fb22

M src/main/java/com/android/tools/metalava/ApiLint.kt
M src/test/java/com/android/tools/metalava/ApiLintTest.kt

https://android-review.googlesource.com/1147767

https://goto.google.com/android-sha1/cbccc81cd841437d587360a423aa88afdcf5ce49