Memory leaks in Biometric library [144919472]

Fixed

Bug

Status Update

No update yet.

Description

dm...@gmail.com

created issue #1

Nov 21, 2019 07:38PM

Artifact used: androidx.biometric:biometric:1.0.0

Devices/Android versions reproduced on:
Emulator 25 API, X86 (behaves the same on all versions)
Android version 7.1.1

Code:

https://github.com/Dimezis/BiometricBugs

Steps:
Have a stored fingerprint on the device.
Launch the example app, see the fingerprint dialog.
Rotate the screen.
See 2 leaks in LeakCanary.

Frequency:
Each time on rotation.

Leak #1:

androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: NO (a class is never leaking)
│ GC Root: System class
│ ↓ static DeviceCredentialHandlerBridge.sInstance
│ ~~~~~~~~~
├─ androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: UNKNOWN
│ ↓ DeviceCredentialHandlerBridge.mAuthenticationCallback
│ ~~~~~~~~~~~~~~~~~~~~~~~
├─ com.eightbitlab.biometricbugs.MainActivity$onCreate$1
│ Leaking: UNKNOWN
│ Anonymous subclass of androidx.biometric.BiometricPrompt$AuthenticationCallback
│ ↓ MainActivity$onCreate$1.this$0

Leak #2:

┬
├─ androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: NO (a class is never leaking)
│ GC Root: System class
│ ↓ static DeviceCredentialHandlerBridge.sInstance
│ ~~~~~~~~~
├─ androidx.biometric.DeviceCredentialHandlerBridge
│ Leaking: UNKNOWN
│ ↓ DeviceCredentialHandlerBridge.mOnClickListener
│ ~~~~~~~~~~~~~~~~
├─ androidx.biometric.BiometricPrompt$1
│ Leaking: UNKNOWN
│ Anonymous class implementing android.content.DialogInterface$OnClickListener
│ ↓ BiometricPrompt$1.this$0
│ ~~~~~~
├─ androidx.biometric.BiometricPrompt
│ Leaking: UNKNOWN
│ ↓ BiometricPrompt.mFingerprintDialogFragment
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~
╰→ androidx.biometric.FingerprintDialogFragment
Leaking: YES (Fragment#mFragmentManager is null and ObjectWatcher was watching this)
key = 42dbc3ac-2321-40a0-bfd4-4f74044ca615
watchDurationMillis = 2137697
retainedDurationMillis = 2132696

Another leak, that is not reported by LeakCanary right now is a non-static child of Handler in FingerprintDialogFragment.
Lint gives you a warning:
This Handler class should be static or leaks might occur.

Comments

dm...@gmail.com <dm...@gmail.com> #2Nov 21, 2019 07:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

[Deleted User] <[Deleted User]> #3Nov 27, 2019 10:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

[Deleted User] <[Deleted User]> #4Nov 27, 2019 10:35AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

mo...@gmail.com <mo...@gmail.com> #5Jan 21, 2020 05:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

cu...@google.com <cu...@google.com> Jan 28, 2020 09:08PM

Reassigned to cu...@google.com.

ap...@google.com <ap...@google.com> #6Feb 4, 2020 10:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit 91f60f5adb619fc0a2ddc866c94670a2f046799a
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 16:59:43 2022

Convert OnBackPressedCallback to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: OnBackPressedCallback is now in Kotlin
Change-Id: Ide1b056e438b403c9b1888bc7dfedf283f1ff168

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288079

ap...@google.com <ap...@google.com> #7Feb 4, 2020 10:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit 324a9ebeb0c23ca0113a925c83a4b90a74c7dc54
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:57:01 2022

Rename OnBackPressedCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I3645ebd21c0ea9c243fad3007bdd3d2472806dcc

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288078

dk...@fundrise.com <dk...@fundrise.com> #8Mar 10, 2020 06:10PM

Project: platform/frameworks/support
Branch: androidx-main

commit a6ec8cc8df1fd6e8a4407ad15569d77914e9adb3
Author: Ian Lake <ilake@google.com>
Date: Wed Jan 25 00:05:20 2023

Move OnBackPressedDispatcher extension to main artifact

As the main activity artifact is automatically included
whenever a developer depends on activity-ktx and these are
in an atomic library group, we can move the Kotlin
extension from activity-ktx to activity itself now that
the class itself has been moved to Kotlin.

Relnote: n/a
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I13482de2e25bd6e084f4b299dddd43b2bcf7a4c7

A activity/activity-ktx/api/current.ignore
M activity/activity-ktx/api/current.txt
M activity/activity-ktx/api/public_plus_experimental_current.txt
A activity/activity-ktx/api/restricted_current.ignore
M activity/activity-ktx/api/restricted_current.txt
D activity/activity-ktx/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
D activity/activity-ktx/src/main/java/androidx/activity/OnBackPressedDispatcher.kt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/OnBackPressedDispatcherTest.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401943

lo...@gmail.com <lo...@gmail.com> #9Apr 28, 2020 08:45AM

Project: platform/frameworks/support
Branch: androidx-main

commit d54d4417476c5ddc37251a910bdf37e9d278357e
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:57:45 2023

Replace usages of Consumer with a lambda

Now that OnBackPressedCallback and
OnBackPressedDispatcher are both written in Kotlin,
we can convert the callback between the two to be a
lambda method, rather than using a Consumer<Boolean>.

Test: tests still pass
BUG: 257291701
Change-Id: I0e2e4a3e7e9d6a3aeab1b8d2283fff321d45f44f

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401942

ap...@google.com <ap...@google.com> #10Jul 31, 2020 09:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 453e6f7acd7b7a1310487fc912f78c0fd2e72dd3
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:43:12 2023

Convert OnBackPressedDispatcher to Kotlin

Relnote: "`OnBackPressedDispatcher` is now written in Kotlin."
Test: ./gradlew checkApi
BUG: 257291701
Change-Id: I18ac79d3cd20fc29159542b729935d3b8d2e4506

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401941

cu...@google.com <cu...@google.com> #11Jul 31, 2020 10:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 57dd231f03ef3f5d107f7c9be9b0f5dd200d7ec4
Author: Ian Lake <ilake@google.com>
Date: Tue Jan 24 23:01:48 2023

Rename OnBackPressedDispatcher.java to .kt

Test: n/a
BUG: 257291701
Change-Id: Id490de8b28b7d2a680c76c822f564fdadd5eb5f1

M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt

https://android-review.googlesource.com/2401940

mi...@gmail.com <mi...@gmail.com> #12Aug 26, 2020 12:20AM

Project: platform/frameworks/support
Branch: androidx-main

commit 76fcc8653339d275c9bfad10e4c68cd9c8ef0dfd
Author: Ian Lake <ilake@google.com>
Date: Fri Jan 27 00:45:07 2023

Update wear module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iaf4f466f38a23c5522de019d38080b04c9f7b7ff

M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/androidTest/kotlin/androidx/wear/compose/navigation/SwipeDismissableNavHostTest.kt

https://android-review.googlesource.com/2405513

na...@gmail.com <na...@gmail.com> #13Dec 10, 2020 08:01AM

Project: platform/frameworks/support
Branch: androidx-main

commit a63f1351aab5e387a829711f14de221274119bcd
Author: Ian Lake <ilake@google.com>
Date: Thu Jan 26 22:51:46 2023

Update navigation module with OnBackPressedDispatcherOwner

With the move of OnBackPressedDispatcherOwner to Kotlin,
implementations must now override a property rather
than implement a getter.

Test: ./gradlew bOS
BUG: 257291701
Change-Id: Iad795301ff2e6a16b42be6b85e6370ac399e43fd

M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt

https://android-review.googlesource.com/2404345