Fixed
Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
I change to fragment1.3.0 and navigation component 2.3.3, the popEnterAnim works fine. (I find the solution from the https://issuetracker.google.com/issues/182195688 example project).
bo...@gmail.com
Please include a sample project that reproduces your issue.
As per the navigate(), the enter and exit animations run.
bo...@gmail.com
Thanks, here it's the project and video.
jb...@google.com
I am also facing same issue exit animations does not work even if i set it from navigation graph and using Direction Classes
bo...@gmail.com
I also saw the same issue. I suspect two modules are involved.
If either of them is versioned up, the same issue occurs.
My Check Point
androidx.appcompat.appcompat:1.3.0-beta01 -> rc01
fragment-ktx:1.3.1 -> 1.3.2
appcompat:1.3.0-beta01 & fragment-ktx:1.3.1 ----> not issue
appcompat:1.3.0-beta01 & fragment-ktx:1.3.2 ----> issue
appcompat:1.3.0-rc01 & fragment-ktx:1.3.1 ----> issue
appcompat:1.3.0-rc01 & fragment-ktx:1.3.2 ----> issue
I apologize for the immature comment. check please :)
If either of them is versioned up, the same issue occurs.
My Check Point
androidx.appcompat.appcompat:1.3.0-beta01 -> rc01
fragment-ktx:1.3.1 -> 1.3.2
appcompat:1.3.0-beta01 & fragment-ktx:1.3.1 ----> not issue
appcompat:1.3.0-beta01 & fragment-ktx:1.3.2 ----> issue
appcompat:1.3.0-rc01 & fragment-ktx:1.3.1 ----> issue
appcompat:1.3.0-rc01 & fragment-ktx:1.3.2 ----> issue
I apologize for the immature comment. check please :)
jm...@gmail.com
I have the same issue:
When updating from androidx.appcompat.appcompat:1.3.0-beta01 to -rc01 or from fragment-ktx:1.3.1 to 1.3.2 popEnterAmin stops working.
When updating from androidx.appcompat.appcompat:1.3.0-beta01 to -rc01 or from fragment-ktx:1.3.1 to 1.3.2 popEnterAmin stops working.
il...@google.com
Same issue, reverting to version 1.3.1 of androidx.fragment:fragment-ktx fixes the problem
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7a15383997e42b427798e2208cad5cbcce607c59
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Apr 08 15:25:28 2021
Fix popEnter animations when popping setPrimaryNavFragment
When doing a FragmentTransactions, if you setCustomAnimations with a
popEnter animation, do an op that triggers an animation (i.e. add, replace, etc),
and then do setPrimaryNavFragment, when you pop that transaction, there will be
no popEnter animation. The reason for this is the setPrimaryNavFragment
Op clears all of the animations for the incoming fragment.
We should only change animations for operations that actually trigger
them.
RelNote: "PopEnter animations will now be present when popping a
setPrimaryNavFragment operation."
Test: FragmentAnimationTest
Bug: 183877426
Change-Id: I38c877ae34c825b3a451ab325b6f683de00a2457
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
https://android-review.googlesource.com/1670154
Branch: androidx-main
commit 7a15383997e42b427798e2208cad5cbcce607c59
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Apr 08 15:25:28 2021
Fix popEnter animations when popping setPrimaryNavFragment
When doing a FragmentTransactions, if you setCustomAnimations with a
popEnter animation, do an op that triggers an animation (i.e. add, replace, etc),
and then do setPrimaryNavFragment, when you pop that transaction, there will be
no popEnter animation. The reason for this is the setPrimaryNavFragment
Op clears all of the animations for the incoming fragment.
We should only change animations for operations that actually trigger
them.
RelNote: "PopEnter animations will now be present when popping a
setPrimaryNavFragment operation."
Test: FragmentAnimationTest
Bug: 183877426
Change-Id: I38c877ae34c825b3a451ab325b6f683de00a2457
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
jb...@google.com
I've created this issue, which is probably related:
jb...@google.com
This has been fixed internally and will be available as part of the Fragment version 1.3.3 release.
bo...@gmail.com
Thanks, that looks much better!
Description
Version used: 1.2.0-rc02
Devices/Android versions reproduced on: Android 8 & Android 10
In
When upgrading to 1.2.0-rc01 I noticed that the TRANSIT_FRAGMENT_OPEN ones now show a visual glitch. I've attached 3 videos:
1. before-1.2.0-rc02 show the default transition before upgrading.
2. after-1.2.0-rc02 shows the default transition after upgrading
3. rc02-with-cl-resources shows the transition when using set setCustomAnimations(R.anim.fragment_open_enter, R.anim.fragment_open_exit), copying over all the relevant resources from the CL to my own app.
What I expect to see after upgrading to 1.2.0-rc02 is the behaviour I see in the 3rd video. I fully understand that the animation changed and that for full control I should add my own, however I'm OK with the default ones as they generally are good enough for the apps I work on :)