Fixed
Status Update
No update yet.
Comments
ra...@google.com
Thanks for reporting the bug. We originally wanted to use tags to uniquely identify Notifications.
This will be fixed in the next WM release.
ra...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b29c1dea635756ffac6937388c42710a58398544
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Dec 04 12:20:34 2019
Add the ability to provide a `notificationId` as part of `ForegroundInfo`.
* We thought we could use notification tags, but tags are not plumbled through
when using startForeground() in a Service.
* We also need to be able to startForeground easily based on `id`s,
because 2 Workers could finish out of order, and then WorkManager
would transparently switch to the running Worker by calling startForeground()
again.
Fixes:
Test: Unit tests pass.
Change-Id: I1d68eace5222e4f53a2e2cae1f238e93e6bbcccb
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/ForegroundWorker.kt
A work/workmanager-gcm/api/2.3.0-beta02.txt
A work/workmanager-gcm/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-gcm/api/res-2.3.0-beta02.txt
A work/workmanager-gcm/api/restricted_2.3.0-beta02.txt
A work/workmanager-ktx/api/2.3.0-beta02.txt
A work/workmanager-ktx/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-ktx/api/res-2.3.0-beta02.txt
A work/workmanager-ktx/api/restricted_2.3.0-beta02.txt
A work/workmanager-rxjava2/api/2.3.0-beta02.txt
A work/workmanager-rxjava2/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-rxjava2/api/res-2.3.0-beta02.txt
A work/workmanager-rxjava2/api/restricted_2.3.0-beta02.txt
A work/workmanager-testing/api/2.3.0-beta02.txt
A work/workmanager-testing/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-testing/api/res-2.3.0-beta02.txt
A work/workmanager-testing/api/restricted_2.3.0-beta02.txt
A work/workmanager/api/2.3.0-beta02.ignore
A work/workmanager/api/2.3.0-beta02.txt
M work/workmanager/api/current.txt
A work/workmanager/api/public_plus_experimental_2.3.0-beta02.txt
M work/workmanager/api/public_plus_experimental_current.txt
A work/workmanager/api/res-2.3.0-beta02.txt
M work/workmanager/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/workmanager/src/androidTest/java/androidx/work/worker/StopAwareForegroundWorker.kt
M work/workmanager/src/androidTest/java/androidx/work/worker/TestForegroundWorker.kt
M work/workmanager/src/main/java/androidx/work/ForegroundInfo.java
M work/workmanager/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
https://android-review.googlesource.com/1181208
Branch: androidx-master-dev
commit b29c1dea635756ffac6937388c42710a58398544
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Dec 04 12:20:34 2019
Add the ability to provide a `notificationId` as part of `ForegroundInfo`.
* We thought we could use notification tags, but tags are not plumbled through
when using startForeground() in a Service.
* We also need to be able to startForeground easily based on `id`s,
because 2 Workers could finish out of order, and then WorkManager
would transparently switch to the running Worker by calling startForeground()
again.
Fixes:
Test: Unit tests pass.
Change-Id: I1d68eace5222e4f53a2e2cae1f238e93e6bbcccb
M buildSrc/src/main/kotlin/androidx/build/LibraryVersions.kt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/ForegroundWorker.kt
A work/workmanager-gcm/api/2.3.0-beta02.txt
A work/workmanager-gcm/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-gcm/api/res-2.3.0-beta02.txt
A work/workmanager-gcm/api/restricted_2.3.0-beta02.txt
A work/workmanager-ktx/api/2.3.0-beta02.txt
A work/workmanager-ktx/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-ktx/api/res-2.3.0-beta02.txt
A work/workmanager-ktx/api/restricted_2.3.0-beta02.txt
A work/workmanager-rxjava2/api/2.3.0-beta02.txt
A work/workmanager-rxjava2/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-rxjava2/api/res-2.3.0-beta02.txt
A work/workmanager-rxjava2/api/restricted_2.3.0-beta02.txt
A work/workmanager-testing/api/2.3.0-beta02.txt
A work/workmanager-testing/api/public_plus_experimental_2.3.0-beta02.txt
A work/workmanager-testing/api/res-2.3.0-beta02.txt
A work/workmanager-testing/api/restricted_2.3.0-beta02.txt
A work/workmanager/api/2.3.0-beta02.ignore
A work/workmanager/api/2.3.0-beta02.txt
M work/workmanager/api/current.txt
A work/workmanager/api/public_plus_experimental_2.3.0-beta02.txt
M work/workmanager/api/public_plus_experimental_current.txt
A work/workmanager/api/res-2.3.0-beta02.txt
M work/workmanager/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/workmanager/src/androidTest/java/androidx/work/worker/StopAwareForegroundWorker.kt
M work/workmanager/src/androidTest/java/androidx/work/worker/TestForegroundWorker.kt
M work/workmanager/src/main/java/androidx/work/ForegroundInfo.java
M work/workmanager/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c92f2a07d289752045ceadfc742d2f80ef37050a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Dec 04 14:51:02 2019
Allow multiple notifications from Workers running in the context of a
Foreground service.
Test: Added unit tests.
Fixes:
Change-Id: I091a5fb9c19000df4e6b859ee02862c23af302e4
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/ForegroundWorker.kt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/workmanager/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/workmanager/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/foreground/SystemForegroundService.java
M work/workmanager/src/main/java/androidx/work/impl/utils/WorkProgressUpdater.java
https://android-review.googlesource.com/1181216
Branch: androidx-master-dev
commit c92f2a07d289752045ceadfc742d2f80ef37050a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Dec 04 14:51:02 2019
Allow multiple notifications from Workers running in the context of a
Foreground service.
Test: Added unit tests.
Fixes:
Change-Id: I091a5fb9c19000df4e6b859ee02862c23af302e4
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/ForegroundWorker.kt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/workmanager/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/workmanager/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/foreground/SystemForegroundService.java
M work/workmanager/src/main/java/androidx/work/impl/utils/WorkProgressUpdater.java
Description
Version used:"2.3.0-beta01"
Devices/Android versions reproduced on: All devices
The same notification is getting changed when different coroutine-worker classes invoke "setForeground" method. I further went in and saw that the same notification id is used for all worker notifications.