Gradle build daemon disappeared unexpectedly [146217083]

Fixed

Bug

Status Update

No update yet.

Description

je...@google.com

created issue #1

Dec 13, 2019 08:32PM

https://android-build.googleplex.com/builds/pending/P10953326/androidx_host_tests_max_dep_versions/latest/view/logs/build_error.log failed with these error messages:

Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/recommendation/src/main/java/androidx/recommendation/app/ContentRecommendation.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/PagerSnapHelper.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/samples/SupportAnimationDemos/src/main/java/com/example/android/support/animation/SpringView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/customview/src/main/java/androidx/customview/widget/ExploreByTouchHelper.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
aidl E 12-11 21:06:47 6654 6654 aidl.cpp:581] refusing to generate code from aidl file defining parcelable

Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
The message received from the daemon indicates that the daemon has disappeared.
Build request sent: Build{id=8ff58aac-ca83-408e-8ee2-d0ffd3158072, currentDir=/usr/local/google/buildbot/src/android/androidx-master-dev}
Attempting to read last messages from the daemon log...
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/browser/src/test/java/androidx/browser/customtabs/CustomTabsIntentTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /usr/local/google/buildbot/src/android/androidx-master-dev/frameworks/support/enterprise/feedback/src/test/java/androidx/enterprise/feedback/DefaultKeyedAppStatesReporterTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Daemon pid: 5071
log file: /usr/local/google/buildbot/src/android/androidx-master-dev/out/.gradle/daemon/6.0/daemon-5071.out.log
----- Last 20 lines from daemon log file - daemon-5071.out.log -----

androidx.enterprise.feedback.KeyedAppStateTest > fromBundle_invalidBundle_throwsIllegalArgumentException[22] STANDARD_OUT
[Robolectric] androidx.enterprise.feedback.KeyedAppStateTest.fromBundle_invalidBundle_throwsIllegalArgumentException: sdk=22; resources=BINARY
Invalidating in-memory cache of /usr/local/google/buildbot/src/android/androidx-master-dev/out/.gradle/caches/6.0/javaCompile/jarAnalysis.bin

androidx.enterprise.feedback.KeyedAppStateTest > fromBundle_invalidBundle_throwsIllegalArgumentException[23] STANDARD_OUT
[Robolectric] androidx.enterprise.feedback.KeyedAppStateTest.fromBundle_invalidBundle_throwsIllegalArgumentException: sdk=23; resources=BINARY

androidx.camera.core.OptionTest > canCreateOption_fromGenericClass_andAssignFromNarrowClass[27] STANDARD_OUT
[Robolectric] androidx.camera.core.OptionTest.canCreateOption_fromGenericClass_andAssignFromNarrowClass: sdk=27; resources=BINARY
Created classpath snapshot for incremental compilation in 0.095 secs. 181 duplicate classes found in classpath (see all with --debug).

androidx.enterprise.feedback.KeyedAppStateTest > fromBundle_invalidBundle_throwsIllegalArgumentException[24] STANDARD_OUT
[Robolectric] androidx.enterprise.feedback.KeyedAppStateTest.fromBundle_invalidBundle_throwsIllegalArgumentException: sdk=24; resources=BINARY
Invalidating in-memory cache of /usr/local/google/buildbot/src/android/androidx-master-dev/out/.gradle/caches/journal-1/file-access.bin
Stored cache entry for task ':room:integration-tests:room-testapp:compileReleaseJavaWithJavac' with cache key 725e0d0f6c0b11c03357636d17b80034
Task :room:integration-tests:room-testapp:compileReleaseJavaWithJavac in ads-identifier Finished
:room:integration-tests:room-testapp:compileReleaseJavaWithJavac (Thread[Execution worker for ':' Thread 2,5,main]) completed. Took 2.393 secs.
:room:integration-tests:room-testapp:javaPreCompileReleaseUnitTest (Thread[Execution worker for ':' Thread 2,5,main]) started.
Task :room:integration-tests:room-testapp:javaPreCompileReleaseUnitTest in ads-identifier Starting
----- End of the daemon log -----

FAILURE: Build failed with an exception.

* What went wrong:
Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

Comments

je...@google.com <je...@google.com> #2Dec 13, 2019 08:33PM

Some movements happening on KAPT with regards to this:

https://github.com/JetBrains/kotlin/pull/2179

je...@google.com <je...@google.com> #3Dec 13, 2019 08:33PM

Yes, kapt incremental compilation support is available since 1.3.40-dev-795
Is there already some plan to add support to Room?

je...@google.com <je...@google.com> #4Dec 13, 2019 08:33PM

#3 incremental kapt is available in 1.3.30 released yesterday too.

ra...@google.com <ra...@google.com> #5Dec 18, 2019 09:58PM

Is there already some ETA?

Message last modified on Dec 18, 2019 09:58PM

ap...@google.com <ap...@google.com> #6Jan 7, 2020 12:12AM

We are working on it and aiming for Room 2.2

ap...@google.com <ap...@google.com> #7Jan 7, 2020 05:36PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e4fbb7fb77a4789ab40bff03cc131479779d3e69
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Apr 09 23:20:59 2019

Create integration test for Room that uses gradle test kit.

Useful for testing Room incremental annotation processing in Gradle.

Also consolidated some of the path definitions in various build.gradle
into methods in buildSrc/SupportConfig.

Bug: 112110217
Test: ./gradlew room:integration-tests:room-i-a-p:test
Change-Id: I34f6772675712c6edd500e9149ab7f21ade4f012

M buildSrc/src/main/kotlin/androidx/build/SupportConfig.kt
M lifecycle/integration-tests/incrementality/build.gradle
M navigation/safe-args-gradle-plugin/build.gradle
A room/integration-tests/incremental-annotation-processing/build.gradle
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/AndroidManifest.xml
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDao.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDatabase.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestEntity.java
A room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/CompileTest.kt
M settings.gradle

https://android-review.googlesource.com/941741

https://goto.google.com/android-sha1/e4fbb7fb77a4789ab40bff03cc131479779d3e69

je...@google.com <je...@google.com> #8Jan 8, 2020 10:25PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a68222dc929ae5e2a3445f9df69a63636854852e
Author: Hung Nguyen <hungnv@google.com>
Date: Fri Mar 29 11:39:50 2019

Prepare Room for incremental annotation processing.

In Java projects, with non-incremental annotation processing, the inputs
to an annotation processor includes only Java source files.

With incremental annotation processing, however, the inputs may include
both Java source files and class files (to avoid recompiling source
files that haven't changed).

Therefore, all Room annotations need to have retention policy CLASS or
RUNTIME (not SOURCE), so that Room can find the elements annotated with
those annotations from class files. This requirement is also stated at

https://docs.gradle.org/current/userguide/java_plugin.html#sec:incremental_annotation_processing.

Bug: 112110217
Test: Existing tests + New AnnotationRetentionPolicyTest
Change-Id: I1e3a433bf69503ef15cfc2e53cbe97616a6f13b8

M room/common/api/2.2.0-alpha01.txt
M room/common/api/current.txt
M room/common/build.gradle
M room/common/src/main/java/androidx/room/ColumnInfo.java
M room/common/src/main/java/androidx/room/ForeignKey.java
M room/common/src/main/java/androidx/room/OnConflictStrategy.java
M room/common/src/main/java/androidx/room/Update.java
A room/common/src/test/java/androidx/room/AnnotationRetentionPolicyTest.kt

https://android-review.googlesource.com/958284

https://goto.google.com/android-sha1/a68222dc929ae5e2a3445f9df69a63636854852e

je...@google.com <je...@google.com> #9Jan 27, 2020 07:20PM

Project: platform/prebuilts/jdk/jdk8
Branch: androidx-master-dev

commit fe743aa0d39ef9bab51c612a957acdd4588d069c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jun 05 14:03:32 2019

Update JDK prebuilts

This build contains fix for

https://bugs.openjdk.java.net/browse/JDK-8194268
which is needed for

b/112110217

(Room incremental annotation processing).

This JDK was taken from platform/prebuilts/studio/jdk in studio-master-dev
as it contains the cherry-picked fixes (ag/7057968).

Test: ./gradlew bOS
Bug: 134470119
Change-Id: I11e4ac20e8cca61ebff5640af7d9b535e5af4ba3

D darwin-x86/MODULE_LICENSE_GPL
M darwin-x86/THIRD_PARTY_README
M darwin-x86/bin/appletviewer
A darwin-x86/bin/clhsdb
M darwin-x86/bin/extcheck
A darwin-x86/bin/hsdb
M darwin-x86/bin/idlj
M darwin-x86/bin/jar
M darwin-x86/bin/jarsigner
M darwin-x86/bin/java
M darwin-x86/bin/javac
M darwin-x86/bin/javadoc
M darwin-x86/bin/javah
M darwin-x86/bin/javap
M darwin-x86/bin/jcmd
M darwin-x86/bin/jconsole
M darwin-x86/bin/jdb
M darwin-x86/bin/jdeps
M darwin-x86/bin/jhat
M darwin-x86/bin/jinfo
M darwin-x86/bin/jjs
M darwin-x86/bin/jmap
M darwin-x86/bin/jps
M darwin-x86/bin/jrunscript
M darwin-x86/bin/jsadebugd
M darwin-x86/bin/jstack
M darwin-x86/bin/jstat
M darwin-x86/bin/jstatd
M darwin-x86/bin/keytool
M darwin-x86/bin/native2ascii
M darwin-x86/bin/orbd
M darwin-x86/bin/pack200
M darwin-x86/bin/policytool
M darwin-x86/bin/rmic
M darwin-x86/bin/rmid
M darwin-x86/bin/rmiregistry
M darwin-x86/bin/schemagen
M darwin-x86/bin/serialver
M darwin-x86/bin/servertool
M darwin-x86/bin/tnameserv
M darwin-x86/bin/unpack200
M darwin-x86/bin/wsgen
M darwin-x86/bin/wsimport
M darwin-x86/bin/xjc
M darwin-x86/jre/THIRD_PARTY_README
A darwin-x86/jre/bin/clhsdb
A darwin-x86/jre/bin/hsdb
M darwin-x86/jre/bin/java
M darwin-x86/jre/bin/jjs
M darwin-x86/jre/bin/keytool
M darwin-x86/jre/bin/orbd
M darwin-x86/jre/bin/pack200
M darwin-x86/jre/bin/policytool
M darwin-x86/jre/bin/rmid
M darwin-x86/jre/bin/rmiregistry
M darwin-x86/jre/bin/servertool
M darwin-x86/jre/bin/tnameserv
M darwin-x86/jre/bin/unpack200
M darwin-x86/jre/lib/charsets.jar
M darwin-x86/jre/lib/ext/cldrdata.jar
M darwin-x86/jre/lib/ext/dnsns.jar
M darwin-x86/jre/lib/ext/jaccess.jar
M darwin-x86/jre/lib/ext/localedata.jar
M darwin-x86/jre/lib/ext/nashorn.jar
M darwin-x86/jre/lib/ext/sunec.jar
M darwin-x86/jre/lib/ext/sunjce_provider.jar
M darwin-x86/jre/lib/ext/sunpkcs11.jar
M darwin-x86/jre/lib/ext/zipfs.jar
M darwin-x86/jre/lib/fontconfig.bfc
M darwin-x86/jre/lib/fontconfig.properties.src
A darwin-x86/jre/lib/fonts/DroidSansFallbackFull.ttf
M darwin-x86/jre/lib/jce.jar
M darwin-x86/jre/lib/jli/libjli.dylib
M darwin-x86/jre/lib/jspawnhelper
M darwin-x86/jre/lib/jsse.jar
M darwin-x86/jre/lib/libAppleScriptEngine.dylib
M darwin-x86/jre/lib/libattach.dylib
M darwin-x86/jre/lib/libawt.dylib
M darwin-x86/jre/lib/libawt_lwawt.dylib
M darwin-x86/jre/lib/libdt_socket.dylib
M darwin-x86/jre/lib/libfontmanager.dylib
M darwin-x86/jre/lib/libfreetype.dylib.6
M darwin-x86/jre/lib/libhprof.dylib
M darwin-x86/jre/lib/libinstrument.dylib
M darwin-x86/jre/lib/libj2gss.dylib
M darwin-x86/jre/lib/libj2pcsc.dylib
M darwin-x86/jre/lib/libj2pkcs11.dylib
M darwin-x86/jre/lib/libjaas_unix.dylib
M darwin-x86/jre/lib/libjava.dylib
M darwin-x86/jre/lib/libjava_crw_demo.dylib
M darwin-x86/jre/lib/libjawt.dylib
M darwin-x86/jre/lib/libjdwp.dylib
M darwin-x86/jre/lib/libjpeg.dylib
M darwin-x86/jre/lib/libjsdt.dylib
M darwin-x86/jre/lib/libjsig.dylib
M darwin-x86/jre/lib/libjsound.dylib
M darwin-x86/jre/lib/liblcms.dylib
M darwin-x86/jre/lib/libmanagement.dylib
M darwin-x86/jre/lib/libmlib_image.dylib
M darwin-x86/jre/lib/libnet.dylib
M darwin-x86/jre/lib/libnio.dylib
M darwin-x86/jre/lib/libnpt.dylib
M darwin-x86/jre/lib/libosx.dylib
M darwin-x86/jre/lib/libosxapp.dylib
M darwin-x86/jre/lib/libosxkrb5.dylib
M darwin-x86/jre/lib/libosxui.dylib
M darwin-x86/jre/lib/libsaproc.dylib
M darwin-x86/jre/lib/libsplashscreen.dylib
M darwin-x86/jre/lib/libsunec.dylib
M darwin-x86/jre/lib/libunpack.dylib
M darwin-x86/jre/lib/libverify.dylib
M darwin-x86/jre/lib/libzip.dylib
M darwin-x86/jre/lib/management-agent.jar
M darwin-x86/jre/lib/resources.jar
M darwin-x86/jre/lib/rt.jar
M darwin-x86/jre/lib/security/java.security
M darwin-x86/jre/lib/security/policy/limited/US_export_policy.jar
M darwin-x86/jre/lib/security/policy/limited/local_policy.jar
M darwin-x86/jre/lib/security/policy/unlimited/US_export_policy.jar
M darwin-x86/jre/lib/security/policy/unlimited/local_policy.jar
M darwin-x86/jre/lib/server/libjsig.dylib
M darwin-x86/jre/lib/server/libjvm.dylib
M darwin-x86/jre/lib/tzdb.dat
M darwin-x86/lib/ct.sym
M darwin-x86/lib/dt.jar
M darwin-x86/lib/jconsole.jar
M darwin-x86/lib/sa-jdi.jar
M darwin-x86/lib/tools.jar
M darwin-x86/release
D darwin-x86/sample/README
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Kettle.xml
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Module.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/PluginChecker.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Require.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/RequireContainer.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/BoilerPlugin.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/ExtendedBoilerPlugin.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/TimerPlugin.java
D darwin-x86/sample/annotations/Validator/src/PositiveIntegerSupplier.java
D darwin-x86/sample/annotations/Validator/src/SupplierValidator.java
D darwin-x86/sample/annotations/Validator/src/Validate.java
D darwin-x86/sample/annotations/Validator/src/Validator.java
D darwin-x86/sample/annotations/index.html
D darwin-x86/sample/dtrace/README.txt
D darwin-x86/sample/dtrace/helpers/dtrace_helper.d
D darwin-x86/sample/dtrace/hotspot/README.txt
D darwin-x86/sample/dtrace/hotspot/class_loading_stat.d
D darwin-x86/sample/dtrace/hotspot/gc_time_stat.d
D darwin-x86/sample/dtrace/hotspot/hotspot_calls_tree.d
D darwin-x86/sample/dtrace/hotspot/method_compile_stat.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_stat.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_stat_filter.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_tree.d
D darwin-x86/sample/dtrace/hotspot/monitors.d
D darwin-x86/sample/dtrace/hotspot/object_allocation_stat.d
D darwin-x86/sample/dtrace/hotspot_jni/CriticalSection.d
D darwin-x86/sample/dtrace/hotspot_jni/CriticalSection_slow.d
D darwin-x86/sample/dtrace/hotspot_jni/README.txt
D darwin-x86/sample/dtrace/hotspot_jni/hotspot_jni_calls_stat.d
D darwin-x86/sample/dtrace/hotspot_jni/hotspot_jni_calls_tree.d
D darwin-x86/sample/forkjoin/mergesort/MergeDemo.java
D darwin-x86/sample/forkjoin/mergesort/MergeSort.java
D darwin-x86/sample/jmx/jmx-scandir/build.properties
D darwin-x86/sample/jmx/jmx-scandir/build.xml
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local-ant-run.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local-java-jar.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/remote-connection-failed.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/remote-connection.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-config.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-result.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-start.jpg
D darwin-x86/sample/jmx/jmx-scandir/index.html
D darwin-x86/sample/jmx/jmx-scandir/keystore
D darwin-x86/sample/jmx/jmx-scandir/logging.properties
D darwin-x86/sample/jmx/jmx-scandir/manifest.mf
D darwin-x86/sample/jmx/jmx-scandir/nbproject/file-targets.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/jdk.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/netbeans-targets.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/project.xml
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScanner.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScannerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManager.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManagerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirAgent.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirClient.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfigMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManager.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManagerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/DirectoryScannerConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/FileMatch.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultLogConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultRecord.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ScanManagerConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/XmlConfigUtils.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/package.html
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/package.html
D darwin-x86/sample/jmx/jmx-scandir/src/etc/access.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/management.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/password.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/testconfig.xml
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/DirectoryScannerTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanDirConfigTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanManagerTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/TestUtils.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/config/XmlConfigUtilsTest.java
D darwin-x86/sample/jmx/jmx-scandir/truststore
D darwin-x86/sample/lambda/BulkDataOperations/index.html
D darwin-x86/sample/lambda/BulkDataOperations/src/CSVProcessor.java
D darwin-x86/sample/lambda/BulkDataOperations/src/Grep.java
D darwin-x86/sample/lambda/BulkDataOperations/src/PasswordGenerator.java
D darwin-x86/sample/lambda/BulkDataOperations/src/WC.java
D darwin-x86/sample/lambda/DefaultMethods/ArrayIterator.java
D darwin-x86/sample/lambda/DefaultMethods/DiamondInheritance.java
D darwin-x86/sample/lambda/DefaultMethods/Inheritance.java
D darwin-x86/sample/lambda/DefaultMethods/MixIn.java
D darwin-x86/sample/lambda/DefaultMethods/Reflection.java
D darwin-x86/sample/lambda/DefaultMethods/SimplestUsage.java
D darwin-x86/sample/nbproject/project.xml
D darwin-x86/sample/nio/chatserver/ChatServer.java
D darwin-x86/sample/nio/chatserver/Client.java
D darwin-x86/sample/nio/chatserver/ClientReader.java
D darwin-x86/sample/nio/chatserver/DataReader.java
D darwin-x86/sample/nio/chatserver/MessageReader.java
D darwin-x86/sample/nio/chatserver/NameReader.java
D darwin-x86/sample/nio/chatserver/README.txt
D darwin-x86/sample/nio/file/AclEdit.java
D darwin-x86/sample/nio/file/Chmod.java
D darwin-x86/sample/nio/file/Copy.java
D darwin-x86/sample/nio/file/DiskUsage.java
D darwin-x86/sample/nio/file/FileType.java
D darwin-x86/sample/nio/file/WatchDir.java
D darwin-x86/sample/nio/file/Xdd.java
D darwin-x86/sample/nio/multicast/MulticastAddress.java
D darwin-x86/sample/nio/multicast/Reader.java
D darwin-x86/sample/nio/multicast/Sender.java
D darwin-x86/sample/nio/server/AcceptHandler.java
D darwin-x86/sample/nio/server/Acceptor.java
D darwin-x86/sample/nio/server/B1.java
D darwin-x86/sample/nio/server/BN.java
D darwin-x86/sample/nio/server/BP.java
D darwin-x86/sample/nio/server/ChannelIO.java
D darwin-x86/sample/nio/server/ChannelIOSecure.java
D darwin-x86/sample/nio/server/Content.java
D darwin-x86/sample/nio/server/Dispatcher.java
D darwin-x86/sample/nio/server/Dispatcher1.java
D darwin-x86/sample/nio/server/DispatcherN.java
D darwin-x86/sample/nio/server/FileContent.java
D darwin-x86/sample/nio/server/Handler.java
D darwin-x86/sample/nio/server/MalformedRequestException.java
D darwin-x86/sample/nio/server/N1.java
D darwin-x86/sample/nio/server/N2.java
D darwin-x86/sample/nio/server/README.txt
D darwin-x86/sample/nio/server/Reply.java
D darwin-x86/sample/nio/server/Request.java
D darwin-x86/sample/nio/server/RequestHandler.java
D darwin-x86/sample/nio/server/RequestServicer.java
D darwin-x86/sample/nio/server/Sendable.java
D darwin-x86/sample/nio/server/Server.java
D darwin-x86/sample/nio/server/StringContent.java
D darwin-x86/sample/nio/server/URLDumper.java
D darwin-x86/sample/scripting/scriptpad/README.txt
D darwin-x86/sample/scripting/scriptpad/build.properties
D darwin-x86/sample/scripting/scriptpad/build.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/file-targets.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/jdk.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/netbeans-targets.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/project.xml
D darwin-x86/sample/scripting/scriptpad/src/META-INF/manifest.mf
D darwin-x86/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java
D darwin-x86/sample/scripting/scriptpad/src/resources/Main.js
D darwin-x86/sample/scripting/scriptpad/src/resources/conc.js
D darwin-x86/sample/scripting/scriptpad/src/resources/gui.js
D darwin-x86/sample/scripting/scriptpad/src/resources/mm.js
D darwin-x86/sample/scripting/scriptpad/src/resources/scriptpad.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/README.txt
D darwin-x86/sample/scripting/scriptpad/src/scripts/browse.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/insertfile.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/linewrap.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/mail.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memmonitor.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.bat
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.sh
D darwin-x86/sample/scripting/scriptpad/src/scripts/textcolor.js
D darwin-x86/sample/try-with-resources/index.html
D darwin-x86/sample/try-with-resources/src/CustomAutoCloseableSample.java
D darwin-x86/sample/try-with-resources/src/Unzip.java
D darwin-x86/sample/try-with-resources/src/ZipCat.java
M darwin-x86/src.zip
D linux-x86/MODULE_LICENSE_GPL
M linux-x86/THIRD_PARTY_README
M linux-x86/bin/appletviewer
A linux-x86/bin/clhsdb
M linux-x86/bin/extcheck
A linux-x86/bin/hsdb
M linux-x86/bin/idlj
M linux-x86/bin/jar
M linux-x86/bin/jarsigner
M linux-x86/bin/java
M linux-x86/bin/javac
M linux-x86/bin/javadoc
M linux-x86/bin/javah
M linux-x86/bin/javap
M linux-x86/bin/jcmd
M linux-x86/bin/jconsole
M linux-x86/bin/jdb
M linux-x86/bin/jdeps
M linux-x86/bin/jhat
M linux-x86/bin/jinfo
M linux-x86/bin/jjs
M linux-x86/bin/jmap
M linux-x86/bin/jps
M linux-x86/bin/jrunscript
M linux-x86/bin/jsadebugd
M linux-x86/bin/jstack
M linux-x86/bin/jstat
M linux-x86/bin/jstatd
M linux-x86/bin/keytool
M linux-x86/bin/native2ascii
M linux-x86/bin/orbd
M linux-x86/bin/pack200
M linux-x86/bin/policytool
M linux-x86/bin/rmic
M linux-x86/bin/rmid
M linux-x86/bin/rmiregistry
M linux-x86/bin/schemagen
M linux-x86/bin/serialver
M linux-x86/bin/servertool
M linux-x86/bin/tnameserv
M linux-x86/bin/unpack200
M linux-x86/bin/wsgen
M linux-x86/bin/wsimport
M linux-x86/bin/xjc
M linux-x86/jre/THIRD_PARTY_README
A linux-x86/jre/bin/clhsdb
A linux-x86/jre/bin/hsdb
M linux-x86/jre/bin/java
M linux-x86/jre/bin/jjs
M linux-x86/jre/bin/keytool
M linux-x86/jre/bin/orbd
M linux-x86/jre/bin/pack200
M linux-x86/jre/bin/policytool
M linux-x86/jre/bin/rmid
M linux-x86/jre/bin/rmiregistry
M linux-x86/jre/bin/servertool
M linux-x86/jre/bin/tnameserv
M linux-x86/jre/bin/unpack200
M linux-x86/jre/lib/amd64/jli/libjli.so
M linux-x86/jre/lib/amd64/libattach.so
M linux-x86/jre/lib/amd64/libawt.so
M linux-x86/jre/lib/amd64/libawt_headless.so
M linux-x86/jre/lib/amd64/libawt_xawt.so
M linux-x86/jre/lib/amd64/libdt_socket.so
M linux-x86/jre/lib/amd64/libfontmanager.so
M linux-x86/jre/lib/amd64/libhprof.so
M linux-x86/jre/lib/amd64/libinstrument.so
M linux-x86/jre/lib/amd64/libj2gss.so
M linux-x86/jre/lib/amd64/libj2pcsc.so
M linux-x86/jre/lib/amd64/libj2pkcs11.so
M linux-x86/jre/lib/amd64/libjaas_unix.so
M linux-x86/jre/lib/amd64/libjava.so
M linux-x86/jre/lib/amd64/libjava_crw_demo.so
M linux-x86/jre/lib/amd64/libjawt.so
M linux-x86/jre/lib/amd64/libjdwp.so
M linux-x86/jre/lib/amd64/libjpeg.so
M linux-x86/jre/lib/amd64/libjsdt.so
M linux-x86/jre/lib/amd64/libjsig.so
M linux-x86/jre/lib/amd64/libjsound.so
M linux-x86/jre/lib/amd64/libjsoundalsa.so
M linux-x86/jre/lib/amd64/liblcms.so
M linux-x86/jre/lib/amd64/libmanagement.so
M linux-x86/jre/lib/amd64/libmlib_image.so
M linux-x86/jre/lib/amd64/libnet.so
M linux-x86/jre/lib/amd64/libnio.so
M linux-x86/jre/lib/amd64/libnpt.so
M linux-x86/jre/lib/amd64/libsaproc.so
M linux-x86/jre/lib/amd64/libsctp.so
M linux-x86/jre/lib/amd64/libsplashscreen.so
M linux-x86/jre/lib/amd64/libsunec.so
M linux-x86/jre/lib/amd64/libunpack.so
M linux-x86/jre/lib/amd64/libverify.so
M linux-x86/jre/lib/amd64/libzip.so
M linux-x86/jre/lib/amd64/server/libjsig.so
M linux-x86/jre/lib/amd64/server/libjvm.so
M linux-x86/jre/lib/charsets.jar
M linux-x86/jre/lib/ext/cldrdata.jar
M linux-x86/jre/lib/ext/dnsns.jar
M linux-x86/jre/lib/ext/jaccess.jar
M linux-x86/jre/lib/ext/localedata.jar
M linux-x86/jre/lib/ext/nashorn.jar
M linux-x86/jre/lib/ext/sunec.jar
M linux-x86/jre/lib/ext/sunjce_provider.jar
M linux-x86/jre/lib/ext/sunpkcs11.jar
M linux-x86/jre/lib/ext/zipfs.jar
A linux-x86/jre/lib/fonts/DroidSansFallbackFull.ttf
M linux-x86/jre/lib/jce.jar
M linux-x86/jre/lib/jexec
M linux-x86/jre/lib/jsse.jar
M linux-x86/jre/lib/management-agent.jar
M linux-x86/jre/lib/resources.jar
M linux-x86/jre/lib/rt.jar
M linux-x86/jre/lib/security/java.security
M linux-x86/jre/lib/security/policy/limited/US_export_policy.jar
M linux-x86/jre/lib/security/policy/limited/local_policy.jar
M linux-x86/jre/lib/security/policy/unlimited/US_export_policy.jar
M linux-x86/jre/lib/security/policy/unlimited/local_policy.jar
M linux-x86/jre/lib/tzdb.dat
M linux-x86/lib/amd64/jli/libjli.so
M linux-x86/lib/amd64/libjawt.so
M linux-x86/lib/ct.sym
M linux-x86/lib/dt.jar
M linux-x86/lib/jconsole.jar
M linux-x86/lib/jexec
M linux-x86/lib/sa-jdi.jar
M linux-x86/lib/tools.jar
M linux-x86/release
D linux-x86/sample/README
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Kettle.xml
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Module.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/PluginChecker.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Require.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/RequireContainer.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/BoilerPlugin.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/ExtendedBoilerPlugin.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/TimerPlugin.java
D linux-x86/sample/annotations/Validator/src/PositiveIntegerSupplier.java
D linux-x86/sample/annotations/Validator/src/SupplierValidator.java
D linux-x86/sample/annotations/Validator/src/Validate.java
D linux-x86/sample/annotations/Validator/src/Validator.java
D linux-x86/sample/annotations/index.html
D linux-x86/sample/forkjoin/mergesort/MergeDemo.java
D linux-x86/sample/forkjoin/mergesort/MergeSort.java
D linux-x86/sample/jmx/jmx-scandir/build.properties
D linux-x86/sample/jmx/jmx-scandir/build.xml
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local-ant-run.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local-java-jar.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/remote-connection-failed.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/remote-connection.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-config.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-result.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-start.jpg
D linux-x86/sample/jmx/jmx-scandir/index.html
D linux-x86/sample/jmx/jmx-scandir/keystore
D linux-x86/sample/jmx/jmx-scandir/logging.properties
D linux-x86/sample/jmx/jmx-scandir/manifest.mf
D linux-x86/sample/jmx/jmx-scandir/nbproject/file-targets.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/jdk.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/netbeans-targets.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/project.xml
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScanner.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScannerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManager.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManagerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirAgent.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirClient.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfigMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManager.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManagerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/DirectoryScannerConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/FileMatch.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultLogConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultRecord.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ScanManagerConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/XmlConfigUtils.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/package.html
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/package.html
D linux-x86/sample/jmx/jmx-scandir/src/etc/access.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/management.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/password.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/testconfig.xml
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/DirectoryScannerTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanDirConfigTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanManagerTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/TestUtils.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/config/XmlConfigUtilsTest.java
D linux-x86/sample/jmx/jmx-scandir/truststore
D linux-x86/sample/lambda/BulkDataOperations/index.html
D linux-x86/sample/lambda/BulkDataOperations/src/CSVProcessor.java
D linux-x86/sample/lambda/BulkDataOperations/src/Grep.java
D linux-x86/sample/lambda/BulkDataOperations/src/PasswordGenerator.java
D linux-x86/sample/lambda/BulkDataOperations/src/WC.java
D linux-x86/sample/lambda/DefaultMethods/ArrayIterator.java
D linux-x86/sample/lambda/DefaultMethods/DiamondInheritance.java
D linux-x86/sample/lambda/DefaultMethods/Inheritance.java
D linux-x86/sample/lambda/DefaultMethods/MixIn.java
D linux-x86/sample/lambda/DefaultMethods/Reflection.java
D linux-x86/sample/lambda/DefaultMethods/SimplestUsage.java
D linux-x86/sample/nbproject/project.xml
D linux-x86/sample/nio/chatserver/ChatServer.java
D linux-x86/sample/nio/chatserver/Client.java
D linux-x86/sample/nio/chatserver/ClientReader.java
D linux-x86/sample/nio/chatserver/DataReader.java
D linux-x86/sample/nio/chatserver/MessageReader.java
D linux-x86/sample/nio/chatserver/NameReader.java
D linux-x86/sample/nio/chatserver/README.txt
D linux-x86/sample/nio/file/AclEdit.java
D linux-x86/sample/nio/file/Chmod.java
D linux-x86/sample/nio/file/Copy.java
D linux-x86/sample/nio/file/DiskUsage.java
D linux-x86/sample/nio/file/FileType.java
D linux-x86/sample/nio/file/WatchDir.java
D linux-x86/sample/nio/file/Xdd.java
D linux-x86/sample/nio/multicast/MulticastAddress.java
D linux-x86/sample/nio/multicast/Reader.java
D linux-x86/sample/nio/multicast/Sender.java
D linux-x86/sample/nio/server/AcceptHandler.java
D linux-x86/sample/nio/server/Acceptor.java
D linux-x86/sample/nio/server/B1.java
D linux-x86/sample/nio/server/BN.java
D linux-x86/sample/nio/server/BP.java
D linux-x86/sample/nio/server/ChannelIO.java
D linux-x86/sample/nio/server/ChannelIOSecure.java
D linux-x86/sample/nio/server/Content.java
D linux-x86/sample/nio/server/Dispatcher.java
D linux-x86/sample/nio/server/Dispatcher1.java
D linux-x86/sample/nio/server/DispatcherN.java
D linux-x86/sample/nio/server/FileContent.java
D linux-x86/sample/nio/server/Handler.java
D linux-x86/sample/nio/server/MalformedRequestException.java
D linux-x86/sample/nio/server/N1.java
D linux-x86/sample/nio/server/N2.java
D linux-x86/sample/nio/server/README.txt
D linux-x86/sample/nio/server/Reply.java
D linux-x86/sample/nio/server/Request.java
D linux-x86/sample/nio/server/RequestHandler.java
D linux-x86/sample/nio/server/RequestServicer.java
D linux-x86/sample/nio/server/Sendable.java
D linux-x86/sample/nio/server/Server.java
D linux-x86/sample/nio/server/StringContent.java
D linux-x86/sample/nio/server/URLDumper.java
D linux-x86/sample/scripting/scriptpad/README.txt
D linux-x86/sample/scripting/scriptpad/build.properties
D linux-x86/sample/scripting/scriptpad/build.xml
D linux-x86/sample/scripting/scriptpad/nbproject/file-targets.xml
D linux-x86/sample/scripting/scriptpad/nbproject/jdk.xml
D linux-x86/sample/scripting/scriptpad/nbproject/netbeans-targets.xml
D linux-x86/sample/scripting/scriptpad/nbproject/project.xml
D linux-x86/sample/scripting/scriptpad/src/META-INF/manifest.mf
D linux-x86/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java
D linux-x86/sample/scripting/scriptpad/src/resources/Main.js
D linux-x86/sample/scripting/scriptpad/src/resources/conc.js
D linux-x86/sample/scripting/scriptpad/src/resources/gui.js
D linux-x86/sample/scripting/scriptpad/src/resources/mm.js
D linux-x86/sample/scripting/scriptpad/src/resources/scriptpad.js
D linux-x86/sample/scripting/scriptpad/src/scripts/README.txt
D linux-x86/sample/scripting/scriptpad/src/scripts/browse.js
D linux-x86/sample/scripting/scriptpad/src/scripts/insertfile.js
D linux-x86/sample/scripting/scriptpad/src/scripts/linewrap.js
D linux-x86/sample/scripting/scriptpad/src/scripts/mail.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memmonitor.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.bat
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.sh
D linux-x86/sample/scripting/scriptpad/src/scripts/textcolor.js
D linux-x86/sample/try-with-resources/index.html
D linux-x86/sample/try-with-resources/src/CustomAutoCloseableSample.java
D linux-x86/sample/try-with-resources/src/Unzip.java
D linux-x86/sample/try-with-resources/src/ZipCat.java
M linux-x86/src.zip

https://android-review.googlesource.com/978088

https://goto.google.com/android-sha1/fe743aa0d39ef9bab51c612a957acdd4588d069c

je...@google.com <je...@google.com> #10Jan 27, 2020 07:21PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f65f09de487c04fa40b4734d88b92a79fe2c545
Author: Hung Nguyen <hungnv@google.com>
Date: Wed May 08 15:49:58 2019

Make Room an isolating incremental annotation processor.

This CL introduces an annotation processor option called
`room.incremental`
which the user can set to try out incremental annotation processing with
Room. It is currently off by default.

The user can pass the option through the Android Gradle plugin's DSL,
for example:

android {
defaultConfig
javaCompileOptions {
annotationProcessorOptions {
argument 'room.incremental', 'true'
}
}
}
}

Caveat: There is a JDK bug

https://bugs.openjdk.java.net/browse/JDK-8007720 that prevents Room from
being incremental (details are discussed in the code comment).
Therefore, if the JDK version being used does not already have this fix,
Room cannot be incremental and we will print out a warning to ask the
user to use a JDK version having the fix.

Note that Room currently does not track the annotation processor option
`room.schemaLocation` properly as an @OutputDirectory, and this could
impact build correctness. However, this issue impacts both
non-incremental and incremental builds, and it already existed before,
so we will fix it separately (tracked at

bug 132245929

).

Additionally, Room is currently not using the
javax.annotation.processing.Filer API to let Gradle know the originating
element of a generated schema file, so the schema files may not get
deleted properly when certain source files are deleted (tracked at bug
134472065).

Bug: 112110217
Test: New RoomIncrementalAnnotationProcessingTest
Change-Id: I0076e596b1c05bcc51afea21a4f6a9a90fb6c7be

M room/compiler/src/main/kotlin/androidx/room/RoomProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/Context.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/compiler/src/main/kotlin/androidx/room/util/SimpleJavaVersion.kt
M room/compiler/src/main/kotlin/androidx/room/vo/Warning.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DatabaseWriter.kt
A room/compiler/src/main/resources/META-INF/gradle/incremental.annotation.processors
M room/compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt
A room/compiler/src/test/kotlin/androidx/room/util/SimpleJavaVersionTest.kt
M room/compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Dao1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Dao2.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Database1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Database2.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Entity1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Entity2.java
D room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/CompileTest.kt
A room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/RoomIncrementalAnnotationProcessingTest.kt

https://android-review.googlesource.com/958285

https://goto.google.com/android-sha1/6f65f09de487c04fa40b4734d88b92a79fe2c545

au...@google.com <au...@google.com> #11Jan 27, 2020 07:22PM

Room 2.2.0 will be an incremental annotation processing when enabled via the option 'room.incremental = true'

ap...@google.com <ap...@google.com> #12Jan 28, 2020 07:45PM

When will be some alpha or at least snapshot build with this support, please?

je...@google.com <je...@google.com> #13Jan 29, 2020 07:28PM

in a couple of weeks, we should have it.

je...@google.com <je...@google.com> #14Jan 30, 2020 03:33PM

I updated to 2.2.0 stable release and added the option "room.incremental = true" to my gradle properties.
But I am still seeing this warning:
w: [kapt] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: androidx.room.RoomProcessor (DYNAMIC).

je...@google.com <je...@google.com> #15Jan 30, 2020 03:34PM

Accepted by je...@google.com.

Sorry about my last comment. I just saw I configured it wrong. It is not supposed to be se tin the gradle.properties, but in the annotationProcessorOptions.

android {
...
defaultConfig {
...
javaCompileOptions {
annotationProcessorOptions {
arguments = [
"room.schemaLocation":"$projectDir/schemas".toString(),
"room.incremental":"true",
"room.expandProjection":"true"]
}
}
}
}

je...@google.com <je...@google.com> #16Jan 30, 2020 07:06PM

@Yigit Will a future version of room have this enabled by default?

ap...@google.com <ap...@google.com> #17Jan 30, 2020 08:14PM

yes, it will be but we are looking for some feedback before we make the switch just to be safe and not break other people.

ap...@google.com <ap...@google.com> #18Jan 30, 2020 09:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2715143f2b6f2b74a088b242b39c9841d2d8dcf2
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Jun 18 09:54:58 2020

Make room.incremental default be true

Relnote: Room's incremental annotation processing option is now ON by default.
Bug: 112110217
Test: :room:integration-tests:room-i-a-p:test
Change-Id: If46d955da45d985543ab982bd0e9d27bbd961517

M room/compiler/src/main/kotlin/androidx/room/processor/Context.kt

https://android-review.googlesource.com/1343816

je...@google.com <je...@google.com> #19Jan 31, 2020 04:03PM

Is it switched on by default in 2.2.5? Because I still got the message got a warning from kapt

[WARN] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: androidx.room.RoomProcessor (DYNAMIC).

Solved to adding "room.incremental"="true" in the annotation params.

Message last modified on Jan 31, 2020 04:16PM

ap...@google.com <ap...@google.com> #20Feb 4, 2020 07:38PM

Oops, spoke too soon. First appears in the release notes for 2.3.0:

https://developer.android.com/jetpack/androidx/releases/room#2.3.0-alpha02

je...@google.com <je...@google.com> #21Feb 5, 2020 09:23PM

KNOWN ISSUE: Note that incremental Room is currently broken in some cases (Issue 159501719), so we may need to revert this change or send out a patch to at least provide workarounds to users. https://issuetracker.google.com//159501719#comment18 lists the possible fixes.

je...@google.com <je...@google.com> #22Feb 5, 2020 09:25PM

Sorry there was a typo, correction: https://issuetracker.google.com/159501719#comment18

au...@google.com <au...@google.com> #23Feb 5, 2020 09:32PM

I'm not sure if we can blame :room:integration-tests:room-testapp without more evidence. It might just show up as it is a fairly large project that depends on leaf node projects.

je...@google.com <je...@google.com> #24Feb 5, 2020 09:39PM

Yeah, I agree that it's probably not specifically the ":room:integration-tests:room-testapp" project since the longest common prefix is ":room:integration-tests:room-testapp" rather than ":room:integration-tests:room-testapp:" (it's not even always that specific project that has a running task at the time the daemon dies)

ow...@google.com <ow...@google.com> #25Feb 6, 2020 12:04PM

I'm getting some other room:integration-tests:room-testapp (happened in both room-testapp and room-testapp-autovalue) compile-time flakes here:

b/146128216

Room seems to concurrently start up a sqlite server or something, flakily. I tend to blame all flakes on concurrency, so it seems plausible that another flaky concurrent thing room is doing could be related to this.

Message last modified on Feb 6, 2020 12:05PM

je...@google.com <je...@google.com> #26Feb 6, 2020 05:55PM

Another build that failed with an unexpectedly missing gradle daemon and that fortunately had fewer running tasks at the end of its build:

https://android-build.googleplex.com/builds/submitted/6187363/androidx/latest/view/logs/build_error.log failed

and according to

https://android-build.googleplex.com/builds/submitted/6187363/androidx/latest/view/logs/build.log , the currently running tasks at the end of the build were:

- Show quoted text -

je...@google.com <je...@google.com> #27Feb 6, 2020 06:01PM

Also weird is that I'm not observing an hs_err_pid file, though (aosp/1227540 is supposed to copy those into the dist/ dir although

https://android-build.googleplex.com/builds/pending/P11938477/androidx_max_dep_versions/latest/view/logs/build_error.log failed too and doesn't have one in its dist/ dir). Maybe that suggests that the daemon was killed rather than crashing?

ap...@google.com <ap...@google.com> #28Feb 6, 2020 06:21PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 061234a6803c5e8561e5fa0455db9cb19e3f9d88
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Wed Feb 05 16:53:30 2020

Hopefully copying hs_err_pid files into the dist dir when the Gradle daemon dies

In case these files exist and have any helpful information

Bug: 146217083
Change-Id: Icd0903bd6d0fa8b2eadc4a1990c637199c31a3e0

M gradlew

https://android-review.googlesource.com/1227540

ap...@google.com <ap...@google.com> #29Feb 6, 2020 10:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit aa8a55ab9ff6f5ed30db4a3afd4ceedfed8fe488
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Thu Feb 06 15:29:08 2020

Showing the contents of the out/ dir in build server builds

To rule out the possibility of any files in it persisting across builds

Bug: 146217083
Bug: 148102969

Test: DIST_DIR=../../out/dist ./busytown/androidx.sh # and see that the contents of the out/ dir are displayed
Change-Id: Ic0656682358c015bee9a894850dcd906f3873608

M busytown/impl/build.sh

https://android-review.googlesource.com/1228342

ap...@google.com <ap...@google.com> #30Feb 7, 2020 12:17AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2f1967d22757ae11cc0283cc1bfcbf1a4c5df9e0
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Thu Feb 06 17:55:53 2020

Checking for system messages when the gradle daemon dies

In case the daemon is being killed by something

Bug: 146217083
Change-Id: Ibfdb818bf8fbf42ffcaa08e3a5cd01226f35a1c4

M gradlew

https://android-review.googlesource.com/1228347

ap...@google.com <ap...@google.com> #31Feb 10, 2020 10:54PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f27b98274038ccb5b1ec32f0945331893a5c4efe
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Mon Feb 10 15:51:34 2020

Increasing javac verbosity on build server in room projects

in an effort to identify why the gradle daemon has been crashing more often recently

Bug: 146217083
Test: ./gradlew :room:integration-tests:room-testapp-noappcompat:mergeDebugAndroidTestNativeLibs # see that no extra output is shown
Test: DIST_DIR=../../out/dist ./gradlew :room:integration-tests:room-testapp-noappcompat:mergeDebugAndroidTestNativeLibs # see that extra output is shown
Change-Id: Ie11e35b669508d6cf82c6e159db793d299fbdbd1

M buildSrc/src/main/kotlin/androidx/build/AndroidXPlugin.kt

https://android-review.googlesource.com/1231406

je...@google.com <je...@google.com> #32Feb 11, 2020 07:01PM

I observe (only) two new build failures logs with more info after adding "--verbose" to javac invocations in room projects on the build server:

https://android-build.googleplex.com/builds/submitted/6198046/androidx_test_changed_apks/latest/view/logs/build_error.log

https://android-build.googleplex.com/builds/pending/P12053301/androidx_test_dependent_apks/latest/view/logs/build_error.log

If anybody has any ideas that would be great (it looks suspicious to me that I see the text "last round: false" in the javac output and don't see a subsequent "last round: true", but I'm not sure if that's just an indication that Gradle crashed while it happened to be compiling)

Otherwise I think my plan is to wait for a couple days (to see if this lower error rate persists) and then maybe try forking those javac invocations (

https://docs.gradle.org/current/dsl/org.gradle.api.tasks.compile.CompileOptions.html#org.gradle.api.tasks.compile.CompileOptions:fork(java.util.Map) ) in hopes of more clearly determining whether javac is crashing and if so, which invocations

yb...@google.com <yb...@google.com> #33Feb 11, 2020 07:21PM

do we have the daemon logs as well from those machines?

/buildbot/src/android/androidx-master-dev/out/.gradle/daemon/6.1/daemon-21733.out.log

je...@google.com <je...@google.com> #34Feb 11, 2020 07:45PM

Yeah, the daemon logs are now copied into out/dist/gradle-daemon

That is, for build_error of

https://android-build.googleplex.com/builds/submitted/6198046/androidx_test_changed_apks/latest/view/logs/build_error.log ,
the daemon log is

https://android-build.googleplex.com/builds/pending/P12053301/androidx_test_dependent_apks/latest/view/gradle-daemon/6.1/daemon-21733.out.log

and for build_error of

https://android-build.googleplex.com/builds/submitted/6198046/androidx_test_changed_apks/latest/view/logs/build_error.log ,
the daemon log is

https://android-build.googleplex.com/builds/submitted/6198046/androidx_test_changed_apks/latest/view/gradle-daemon/6.1/daemon-15111.out.log

au...@google.com <au...@google.com> #35Feb 11, 2020 11:11PM

https://android-build.googleplex.com/builds/pending/P12082996/androidx_host_tests_max_dep_versions/latest/view/logs/build_error.log

another flake

yb...@google.com <yb...@google.com> #36Feb 12, 2020 02:36AM

Both of those seems to have crashed after compilation finished.

[wrote RegularFileObject[/buildbot/src/android/androidx-master-dev/out/androidx/room/integration-tests/room-testapp-noappcompat/build/intermediates/javac/debugAndroidTest/classes/androidx/room/integration/noappcompat/BareRelationDatabaseTest_RelationDatabase_Impl.class]]
[total 5402ms]
2 warnings
Stream closed

[wrote RegularFileObject[/buildbot/src/android/androidx-master-dev/out/androidx/room/integration-tests/room-testapp-noappcompat/build/intermediates/javac/debugAndroidTest/classes/androidx/room/integration/noappcompat/BareRelationDatabaseTest_RelationDatabase_Impl.class]]
[total 1853ms]
2 warnings
Stream closed

Unfortunately this does not say much.

Daemons were created with:

2020-02-10T21:04:19.191+0000 [DEBUG] [org.gradle.launcher.daemon.bootstrap.DaemonMain] Assuming the daemon was started with following jvm opts: [-Xms8g, -Xmx8g, -Dfile.encoding=UTF-8, -Djava.io.tmpdir=/buildbot/src/android/androidx-master-dev/out, -Duser.country=US, -Duser.language=en, -Duser.variant]
2020-02-10T21:04:19.446+0000 [INFO] [org.gradle.launcher.daemon.server.Daemon] start() called on daemon - DefaultDaemonContext[uid=a344b928-f14a-43b3-93dd-f3e50070e0ca,javaHome=/buildbot/src/android/androidx-master-dev/prebuilts/jdk/jdk8/linux-x86,daemonRegistryDir=/buildbot/src/android/androidx-master-dev/out/.gradle/daemon,pid=21733,idleTimeout=120000,priority=NORMAL,daemonOpts=-Xms8g,-Xmx8g,-Dfile.encoding=UTF-8,-Djava.io.tmpdir=/buildbot/src/android/androidx-master-dev/out,-Duser.country=US,-Duser.language=en,-Duser.variant]

Maybe there is a way to make it have more verbose logging as well?

je...@google.com <je...@google.com> #37Feb 13, 2020 10:47PM

I got a couple of Gradle crashes on my computer this time, and they each left an hs_err_pid file:

https://paste.googleplex.com/5897681769594880 and

https://paste.googleplex.com/5835538323996672

je...@google.com <je...@google.com> #38Feb 13, 2020 11:08PM

From the heap dumps it looks like it could be

https://bugs.openjdk.java.net/browse/JDK-8175970 , maybe that's more of a reason for us to upgrade to Java 9 or later

ap...@google.com <ap...@google.com> #39Feb 14, 2020 01:01AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d54930d757b136c0b20118dd0d96b14ea696d51e
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Thu Feb 13 17:25:02 2020

Fixing copying hs_err_pid files when Gradle crashes

Bug: 146217083
Change-Id: Ic80f6421877380bc8ac002f5756503eec3d2bbd6

M gradlew

https://android-review.googlesource.com/1235502

je...@google.com <je...@google.com> #40Feb 18, 2020 06:33PM

We got another daemon crash at

https://android-build.googleplex.com/builds/submitted/6216217/androidx_test_changed_apks/latest/view/logs/build_error.log and now we have an hs_err_pid file at

https://android-build.googleplex.com/builds/submitted/6216217/androidx_test_changed_apks/latest/view/hs_err_pid20279.log

I see a line that says:

androidx.room.verifier.DatabaseVerifier$Companion.create

but I don't also notice anything nearby about libzip.so , so maybe the error we're getting on the build servers is different than

comment #37

.

Yigit, do you have any ideas based on this hs_err_pid file?

yb...@google.com <yb...@google.com> #41Feb 18, 2020 07:27PM

It is when we try to open a connection to SQLite which requires loadinga native library. java.lang.System.load(Ljava/lang/String;)V+7

Btw, there are 800+ threads in that dump, is that normal? may this be something leaking and creating more pressure on the system and maybe we just crash when we fail to allocate native memory? I know this is a super un-founded guess but seeing a memory dump might help us understand it better?

je...@google.com <je...@google.com> #42Feb 18, 2020 08:41PM

That (the fact that there are 800 threads in that hs_err_pid file) is interesting

Also interesting is when I run `./androidx.sh` and wait for the androidx build to be running, and then run `pstree -l -a $gradlePid` several times, it seems to me that the number of threads maxes out at higher than 834 threads spawned by the Gradle Daemon, judging by the output at the bottom of this comment.

I can look into getting a memory dump anyway

pstree output:

java -DLINT_API_DATABASE=/usr/local/google/workspace/aosp-androidx-git/frameworks/support/../../prebuilts/fullsdk-linux/platform-tools/api/api-versions.xml -Dorg.gradle.appname=gradlew -Djava.io.tmpdir=/usr/local/google/workspace/aosp-androidx-git/out -classpath /usr/local/google/workspace/aosp-androidx-git/frameworks/support/gradle/wrapper/gradle-wrapper.jar org.gradle.wrapper.GradleWrapperMain -Duser.home=/usr/local/google/workspace/aosp-androidx-git/out/.gradle -Djava.io.tmpdir=/usr/local/google/workspace/aosp-androidx-git/out -Dorg.gradle.jvmargs=-Xms8g -Xmx8g -p frameworks/support --no-daemon buildOnServer -PverifyUpToDate --profile
├─java -Xms8g -Xmx8g -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/usr/local/google/workspace/aosp-androidx-git/out -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/out/.gradle/wrapper/dists/gradle-6.1-bin/cg7pocs5by3iq3djslf99cdom/gradle-6.1/lib/gradle-launcher-6.1.jar org.gradle.launcher.daemon.bootstrap.GradleDaemon 6.1
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─aapt2 m
│ ├─java -cp /usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-compiler-embeddable/1.3.60/kotlin-compiler-embeddable-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-reflect/1.3.60/kotlin-reflect-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-stdlib/1.3.60/kotlin-stdlib-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-script-runtime/1.3.60/kotlin-script-runtime-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-daemon-embeddable/1.3.60/kotlin-daemon-embeddable-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/intellij/deps/trove4j/1.0.20181211/trove4j-1.0.20181211.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-stdlib-common/1.3.60/kotlin-stdlib-common-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/annotations/13.0/annotations-13.0.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/jdk/jdk8/linux-x86/lib/tools.jar -Djava.awt.headless=true -Djava.rmi.server.hostname=127.0.0.1 -Xmx8g -Dkotlin.environment.keepalive -ea org.jetbrains.kotlin.daemon.KotlinCompileDaemon --daemon-runFilesPath /usr/local/google/workspace/aosp-androidx-git/out/.gradle/.kotlin/daemon --daemon-autoshutdownIdleSeconds=7200 --daemon-compilerClasspath /usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-compiler-embeddable/1.3.60/kotlin-compiler-embeddable-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-reflect/1.3.60/kotlin-reflect-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-stdlib/1.3.60/kotlin-stdlib-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-script-runtime/1.3.60/kotlin-script-runtime-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-daemon-embeddable/1.3.60/kotlin-daemon-embeddable-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/intellij/deps/trove4j/1.0.20181211/trove4j-1.0.20181211.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/kotlin/kotlin-stdlib-common/1.3.60/kotlin-stdlib-common-1.3.60.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/org/jetbrains/annotations/13.0/annotations-13.0.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/jdk/jdk8/linux-x86/lib/tools.jar
│ │ └─184*[{java}]
│ ├─java -Djava.security.manager=worker.org.gradle.process.internal.worker.child.BootstrapSecurityManager -Xmx512m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/out/.gradle/caches/6.1/workerMain/gradle-worker.jar worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Worker Daemon 1'
│ │ └─64*[{java}]
│ ├─java -Djava.security.manager=worker.org.gradle.process.internal.worker.child.BootstrapSecurityManager -Xmx512m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/out/.gradle/caches/6.1/workerMain/gradle-worker.jar worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Worker Daemon 2'
│ │ └─64*[{java}]
│ ├─java -Djava.security.manager=worker.org.gradle.process.internal.worker.child.BootstrapSecurityManager -Xmx512m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/out/.gradle/caches/6.1/workerMain/gradle-worker.jar worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Worker Daemon 3'
│ │ └─64*[{java}]
│ ├─java -Djava.security.manager=worker.org.gradle.process.internal.worker.child.BootstrapSecurityManager -Xmx512m -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/out/.gradle/caches/6.1/workerMain/gradle-worker.jar worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Worker Daemon 4'
│ │ └─64*[{java}]
│ ├─java -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/com/android/metalava/1.3.0/metalava-1.3.0-shadow.jar com.android.tools.metalava.Driver --no-banner --hide HiddenSuperclass --classpath /usr/local/google/workspace/aosp-androidx-git/prebuilts/fullsdk-linux/platforms/android-29/android.jar:/usr/local/google/workspace/aosp-androidx-git/out/androidx/collection/collection/build/libs/collection-1.2.0-alpha01.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/internal/androidx/annotation/annotation/1.1.0/annotation-1.1.0.jar --source-path /usr/local/google/workspace/aosp-androidx-git/frameworks/support/remotecallback/src/main/java --format=v3 --output-kotlin-nulls=yes --api /usr/local/google/workspace/aosp-androidx-git/out/androidx/remotecallback/build/api/current.txt --hide-annotation androidx.annotation.experimental.Experimental --hide-annotation kotlin.Experimental --hide-meta-annotation androidx.annotation.experimental.Experimental --hide-meta-annotation kotlin.Experimental --hide-annotation androidx.annotation.RestrictTo --show-unannotated --api-lint --hide Enum, CallbackInterface, ProtectedMember, ManagerLookup, ManagerConstructor, RethrowRemoteException, PackageLayering, UserHandle, ParcelableList, GetterSetterNames, StaticUtils, AllUpper, StartWithLower, BuilderSetStyle, ExecutorRegistration, NotCloseable, UseIcu, SamShouldBeLast, MissingJvmStatic, IntentBuilderName, OnNameExpected, UserHandleName --error MinMaxConstant, TopLevelBuilder, MissingBuild, SetterReturnsThis, OverlappingConstants, IllegalStateException, ListenerLast, StreamFiles, AbstractInner, ArrayReturn, MethodNameTense, NoByteOrShort, CommonArgsFirst --baseline /usr/local/google/workspace/aosp-androidx-git/frameworks/support/remotecallback/api/api_lint.ignore --error DeprecationMismatch --error ReferencesDeprecated
│ │ └─61*[{java}]
│ ├─java -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/com/android/metalava/1.3.0/metalava-1.3.0-shadow.jar com.android.tools.metalava.Driver --no-banner --hide HiddenSuperclass --classpath /usr/local/google/workspace/aosp-androidx-git/prebuilts/fullsdk-linux/platforms/android-29/android.jar:/usr/local/google/workspace/aosp-androidx-git/out/androidx/collection/collection/build/libs/collection-1.2.0-alpha01.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/internal/androidx/annotation/annotation/1.1.0/annotation-1.1.0.jar --source-path /usr/local/google/workspace/aosp-androidx-git/frameworks/support/remotecallback/src/main/java --format=v3 --output-kotlin-nulls=yes --api /usr/local/google/workspace/aosp-androidx-git/out/androidx/remotecallback/build/api/restricted_current.txt --show-annotation androidx.annotation.RestrictTo(androidx.annotation.RestrictTo.Scope.LIBRARY_GROUP_PREFIX) --show-unannotated --hide-annotation androidx.annotation.RestrictTo(androidx.annotation.RestrictTo.Scope.LIBRARY_GROUP) --hide-annotation androidx.annotation.experimental.Experimental --hide-annotation kotlin.Experimental --hide-meta-annotation androidx.annotation.experimental.Experimental --hide-meta-annotation kotlin.Experimental --hide DeprecationMismatch --hide UnhiddenSystemApi --hide ReferencesHidden --hide ReferencesDeprecated
│ │ └─61*[{java}]
│ ├─java -Dfile.encoding=UTF-8 -Duser.country=US -Duser.language=en -Duser.variant -cp /usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/external/com/android/metalava/1.3.0/metalava-1.3.0-shadow.jar com.android.tools.metalava.Driver --no-banner --hide HiddenSuperclass --classpath /usr/local/google/workspace/aosp-androidx-git/prebuilts/fullsdk-linux/platforms/android-29/android.jar:/usr/local/google/workspace/aosp-androidx-git/out/androidx/collection/collection/build/libs/collection-1.2.0-alpha01.jar:/usr/local/google/workspace/aosp-androidx-git/prebuilts/androidx/internal/androidx/annotation/annotation/1.1.0/annotation-1.1.0.jar --source-path /usr/local/google/workspace/aosp-androidx-git/frameworks/support/remotecallback/src/main/java --format=v3 --output-kotlin-nulls=yes --api /usr/local/google/workspace/aosp-androidx-git/out/androidx/remotecallback/build/api/public_plus_experimental_current.txt --api-lint --hide Enum, CallbackInterface, ProtectedMember, ManagerLookup, ManagerConstructor, RethrowRemoteException, PackageLayering, UserHandle, ParcelableList, GetterSetterNames, StaticUtils, AllUpper, StartWithLower, BuilderSetStyle, ExecutorRegistration, NotCloseable, UseIcu, SamShouldBeLast, MissingJvmStatic, IntentBuilderName, OnNameExpected, UserHandleName --error MinMaxConstant, TopLevelBuilder, MissingBuild, SetterReturnsThis, OverlappingConstants, IllegalStateException, ListenerLast, StreamFiles, AbstractInner, ArrayReturn, MethodNameTense, NoByteOrShort, CommonArgsFirst --baseline /usr/local/google/workspace/aosp-androidx-git/frameworks/support/remotecallback/api/api_lint.ignore --error DeprecationMismatch --error ReferencesDeprecated
│ │ └─61*[{java}]
│ ├─javadoc @/usr/local/google/workspace/aosp-androidx-git/out/androidx/build/tmp/publicDocsTask/javadoc.options -J-Xmx1280m
│ │ └─60*[{javadoc}]
│ └─834*[{java}]
└─64*[{java}]

je...@google.com <je...@google.com> #43Feb 18, 2020 09:30PM

Looking into the hs_err_pid file in more detail, it says the error is SIGBUS

https://stackoverflow.com/a/56069999 suggests that it could be caused by an mmapped file being truncated due to a race condition.

It does seem believable to me that calling DatabaseVerifier$Companion.create from multiple threads at once (in particular, multiple Gradle projects) could cause multiple parallel calls to System.load or to JDBC.createConnection

Do we have an idea of whether these methods and/or DatabaseVerifier are threadsafe? I wonder if that relates to

b/146061836

where we were encountering other errors to load sqlite

je...@google.com <je...@google.com> #44Feb 19, 2020 03:58PM

Another failure occurred, its hs_err_pid file is

https://android-build.googleplex.com/builds/submitted/6217975/androidx_host_tests/latest/view/hs_err_pid33825.log

and seems to me to be similar to the previous in

comment #40

yb...@google.com <yb...@google.com> #45Feb 19, 2020 04:51PM

i'm not sure how the isolation work for native code in JVM / gradle but a processor would never call this in parallel. I wonder if this could be related to multiple parallel compilations running on the same JVM.

Another possibility is that, we use tmp folder for the iso file. Could it be the OS somehow thinking that it is not used anymore and delete it?

Nevertheless, since there is an effort to move to Java11, should we wait for it first ?

je...@google.com <je...@google.com> #46Feb 25, 2020 12:47AM

Multiple java compilations should happen in parallel in the same java process, unless we enable forking of compilations (

comment #32

).

Alternatively it also seems reasonable to me to add some logging around copyNativeLibs to see if it's getting called. It does look to me like multiple compilations within the same JVM can cause the value of sqliteNativeLibDir to be modified while other compilations are using it:

https://android.googlesource.com/platform/frameworks/support/+/ecdf94f415983cc332eec5578b93206ea063f5d5/room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt#122

Is room-compiler a jar that might be used by client applications? Is it possible for this error to affect them too?
If we think that the only place where this occurs is in building AndroidX itself then waiting for the upgrade to Java11 and then reevaluating does seem acceptable to me now that the crash rate is lower ( also

comment #32

yb...@google.com <yb...@google.com> #47Feb 25, 2020 02:03AM

we've not recently seen this being an issue. like a year ago or so, we had a similar problem which why we have the reloading logic in database verifier. we've not heard back any issues after that.

ow...@google.com <ow...@google.com> #48Feb 25, 2020 12:27PM

I don't think this is exclusive to androidx.

I have been seeing b/146128216 in local builds with the daemon off, with low probability, but when I run the build in an infinite loop it is almost always the error that breaks it. This error may be the local equivalent of the daemon disappearing error, when the build is run with --no-daemon.

This error pops up in room test apps, which are client applications of room. It seems like if you simultaneously compile multiple client apps of room, they can cause SQLite connection failures. It is possible though unlikely for external clients to do this.

ap...@google.com <ap...@google.com> #49Feb 25, 2020 09:55PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4c6402f2509972b7332e0091528cadade07121bc
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Tue Feb 25 13:45:46 2020

Sychronizing DatabaseVerifier.copyNativeLibs

To avoid one DatabaseVerifier modifying org.sqlite.tmpdir while another one is using sqlite

Bug: 146217083

Test: Comment out the added synchronization and the calls to "reusePreviousSqliteTempdir" and run this a couple of times:

./gradlew --rerun-tasks :room:integration-tests:room-testapp:assembleAndroidTest \
:room:integration-tests:room-testapp-noappcompat:assembleAndroidTest \
:room:integration-tests:room-testapp-autovalue:assembleAndroidTest \
:room:integration-tests:room-testapp:assembleAndroidTest \
:room:integration-tests:room-testapp-kotlin:assembleAndroidTest

and observe that ConcurrentModificationException often gets thrown

Change-Id: I9f8b0d42021e75289f9e56c65076e048353df1b5

M room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt

https://android-review.googlesource.com/1242998

au...@google.com <au...@google.com> #50Feb 25, 2020 09:56PM

Can we now follow up and remove most of the debug statements we left behind in gradlew and other places?

je...@google.com <je...@google.com> #51Feb 25, 2020 10:05PM

Interestingly enough I'm finding that although I was able to remove one class of error, running room/stress-test-room.sh still sometimes fails and I'm looking into it some more

Also interesting is that the debug statements themselves seem to lower the error rate (

comment #32

)

ap...@google.com <ap...@google.com> #52Feb 25, 2020 11:55PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d998b6d4f5b8fc053a8de290b310e62c9da1bae1
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Tue Feb 25 17:36:14 2020

Synchronizing DatabaseVerifier.copyNativeLibs on System.getProperties()

It seems that each DatabaseVerifier.companion has its own classloader and isn't sufficient to use for synchronization

Bug: 146217083
Test: add "Thread.sleep(10000L)" into copyNativeLibs and run this:

./gradlew --rerun-tasks :room:integration-tests:room-testapp:assembleAndroidTest \
:room:integration-tests:room-testapp-noappcompat:assembleAndroidTest \
:room:integration-tests:room-testapp-autovalue:assembleAndroidTest \
:room:integration-tests:room-testapp:assembleAndroidTest \
:room:integration-tests:room-testapp-kotlin:assembleAndroidTest

and see that this still passes
Test: ./room/stress-test-room.sh

Change-Id: I0f074d7ca03a0773d8a687d036d1656122b255e9

M room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt

https://android-review.googlesource.com/1244048

ap...@google.com <ap...@google.com> #53Feb 26, 2020 01:30AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 464b672f035155dfff241f5df4d48bafcf2de223
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Tue Feb 25 18:49:34 2020

Synchronizing DatabaseVerifier's calls to JDBC.createConnection

Our hs_err_pid files are indicating that System.loadLibrary is not threadsafe.
Presumably JDBC.createConnection is calling System.loadLibrary and is also not threadsafe.
Note that when we synchronize these calls, JDBC.createConnection seems to stop throwing UnsatisfiedLinkError

Bug: 146217083

Test: ./room/stress-test-room.sh
Test: Comment out the catch blocks "unsatisfied: UnsatisfiedLinkError" and "ex: Exception" and run:

./room/stress-test-room.sh

and see that even without those catches enabled, the stress test still passes

Change-Id: I14ec25d3266135fe14638ce30156d4e3207c17fe

M room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt

https://android-review.googlesource.com/1244049

ya...@google.com <ya...@google.com> #54Feb 26, 2020 02:30AM

Hi, I'm getting a presubmit error for

http://aosp/1242673
Is it related to this issue?

The error log is here.

https://android-build.googleplex.com/builds/pending/P12427553/androidx/latest/view/logs/build_error.log

--- LOG ---
Caused by: java.lang.UnsatisfiedLinkError: Native Library /buildbot/src/android/androidx-master-dev/out/room-9c489b03-ce24-4b34-8846-142719f950a6/

sqlite-3.25.2-6c245ba4-9ceb-4ebc-b6ec-f95eac14a1ef-libsqlitejdbc.so already loaded in another classloader
at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1907)
at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1824)
at java.lang.Runtime.load0(Runtime.java:809)
at java.lang.System.load(System.java:1086)
at androidx.room.verifier.DatabaseVerifier$Companion.create(DatabaseVerifier.kt:109)
...

je...@google.com <je...@google.com> #55Feb 26, 2020 03:08AM

Re #54, I think it's related, yeah. Does it seem to be happening consistently?

ya...@google.com <ya...@google.com> #56Feb 26, 2020 03:09AM

So far, I ran it twice and both failed with the same error.

yb...@google.com <yb...@google.com> #57Feb 26, 2020 03:18AM

I've already commented on the CL but i don't think https://android-review.googlesource.com/1244049 solves the issue, in fact it probably makes it worse when multiple daemons run as they'll share the folder where a) room versions might be different b) earlier daemon will delete it, possibly while the next one is using it.

ya...@google.com <ya...@google.com> #58Feb 26, 2020 03:43AM

It seems my CL passed. Third time lucky.

il...@google.com <il...@google.com> #59Feb 26, 2020 06:07PM

Looks like all of the recent builds of go/ab/aosp-androidx-master-dev have been failing with this error.

ni...@google.com <ni...@google.com> #60Feb 26, 2020 06:42PM

Started today at ab/6238666

Message last modified on Feb 26, 2020 06:42PM

ap...@google.com <ap...@google.com> #61Feb 26, 2020 08:26PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit cb263614074e9df530535eb2c00693946f474ede
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Feb 26 11:32:09 2020

Use System.class as mutex

Use a bootstrap loaded class such as System.class as mutex for loading
the sqlite jdbc native library since the Properties instance be swapped
via System.setProperties()

Bug: 146217083
Test: Hopefully androidx.sh will succeed on the build servers.
Change-Id: I9e7d0d6711ec1ad796aa9ca299e9fea2f32d2627

M room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt

https://android-review.googlesource.com/1244606

ap...@google.com <ap...@google.com> #62Feb 27, 2020 09:57PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b818451a8d5037a4bade810ec7fa2591483d6b90
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Wed Feb 26 14:16:57 2020

Temporarily disabling DatabaseVerifier's check for concurrent changes to com.sqlite.tmpdir

This check has been triggering a bunch lately
Disabling it for now should help to unblock people

Bug: 146217083
Test: hopefully androidx.sh will succeed on the build servers more often

Change-Id: I2a94ee9eb41eafb547fc4fee4b2ec03598bb51d4

M room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt

https://android-review.googlesource.com/1244546

ap...@google.com <ap...@google.com> #63Mar 2, 2020 05:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 38f16b8e3a6aa2679044f2a8df8d435e4eb9b898
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Thu Feb 27 14:07:58 2020

Refactor DatabaseVerifier native library load logic.

This CL goes back to basics and removes the various workarounds
that have been placed around for loading the native sqlite lib.
Specifically, it removes the retry logic and the manual load call.

The SQLite JDBC library used (

https://github.com/xerial/sqlite-jdbc)
already has logic in SQLiteJDBCLoader to avoid multiple class loader
conflicts and has processor isolation by extracting the library using
a filename that is versioned, contains a UUID and a platform prefix.
The SQLiteJDBCLoader static methods that perform the loading are
synchronized and use the class instance as mutex but the Gradle
daemon will parallelize workers along with javac invocations and
these use isolated class loaders, meaning the SQLiteJDBCLoader.class
is not safe across threads doing other javac work and running Room.

To avoid the issues above Room will synchronize using the
java.lang.System class that should be loaded by the bootstrap class
loader and is shared across all other class loaders. Additionally,
Room will avoid manipulating the System properties and instead will
just verify them, erroring if they are not suitable for Room. More
specifically, checking for a valid temp folder.

Bug: 146217083
Test: ./room/stress-test-room.sh
Change-Id: I063043e148ada1ac69bcefd9cfca0134a9f9200d

M room/compiler/src/main/kotlin/androidx/room/verifier/DatabaseVerifier.kt
M room/stress-test-room.sh

https://android-review.googlesource.com/1246567

an...@google.com <an...@google.com> #64Mar 2, 2020 09:36PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/history/all)
Created: 2020-03-02 21:32:38.901846+00:00
Changes: aosp/1244048, aosp/1246567, aosp/1244606, aosp/1242998, aosp/1244049, aosp/1244546

ap...@google.com <ap...@google.com> #65Mar 3, 2020 05:51PM

Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev

commit c16c45fb0ca4b92ef3db660b512e450131ca7fc3
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Mar 03 08:52:57 2020

Import Room 2.2.5

Bug: 146217083
Test: n/a
Change-Id: I00b061b36d95f54a72e23d01c220daa37a87a553

A androidx/room/room-common/2.2.5/room-common-2.2.5-sources.jar
A androidx/room/room-common/2.2.5/room-common-2.2.5-sources.jar.md5
A androidx/room/room-common/2.2.5/room-common-2.2.5-sources.jar.sha1
A androidx/room/room-common/2.2.5/room-common-2.2.5.jar
A androidx/room/room-common/2.2.5/room-common-2.2.5.jar.md5
A androidx/room/room-common/2.2.5/room-common-2.2.5.jar.sha1
A androidx/room/room-common/2.2.5/room-common-2.2.5.pom
A androidx/room/room-common/2.2.5/room-common-2.2.5.pom.md5
A androidx/room/room-common/2.2.5/room-common-2.2.5.pom.sha1
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5-sources.jar
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5-sources.jar.md5
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5-sources.jar.sha1
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5.jar
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5.jar.md5
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5.jar.sha1
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5.pom
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5.pom.md5
A androidx/room/room-compiler/2.2.5/room-compiler-2.2.5.pom.sha1
A androidx/room/room-guava/2.2.5/room-guava-2.2.5-sources.jar
A androidx/room/room-guava/2.2.5/room-guava-2.2.5-sources.jar.md5
A androidx/room/room-guava/2.2.5/room-guava-2.2.5-sources.jar.sha1
A androidx/room/room-guava/2.2.5/room-guava-2.2.5.aar
A androidx/room/room-guava/2.2.5/room-guava-2.2.5.aar.md5
A androidx/room/room-guava/2.2.5/room-guava-2.2.5.aar.sha1
A androidx/room/room-guava/2.2.5/room-guava-2.2.5.pom
A androidx/room/room-guava/2.2.5/room-guava-2.2.5.pom.md5
A androidx/room/room-guava/2.2.5/room-guava-2.2.5.pom.sha1
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5-sources.jar
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5-sources.jar.md5
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5-sources.jar.sha1
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5.aar
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5.aar.md5
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5.aar.sha1
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5.pom
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5.pom.md5
A androidx/room/room-ktx/2.2.5/room-ktx-2.2.5.pom.sha1
A androidx/room/room-migration/2.2.5/room-migration-2.2.5-sources.jar
A androidx/room/room-migration/2.2.5/room-migration-2.2.5-sources.jar.md5
A androidx/room/room-migration/2.2.5/room-migration-2.2.5-sources.jar.sha1
A androidx/room/room-migration/2.2.5/room-migration-2.2.5.jar
A androidx/room/room-migration/2.2.5/room-migration-2.2.5.jar.md5
A androidx/room/room-migration/2.2.5/room-migration-2.2.5.jar.sha1
A androidx/room/room-migration/2.2.5/room-migration-2.2.5.pom
A androidx/room/room-migration/2.2.5/room-migration-2.2.5.pom.md5
A androidx/room/room-migration/2.2.5/room-migration-2.2.5.pom.sha1
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5-sources.jar
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5-sources.jar.md5
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5-sources.jar.sha1
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5.aar
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5.aar.md5
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5.aar.sha1
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5.pom
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5.pom.md5
A androidx/room/room-runtime/2.2.5/room-runtime-2.2.5.pom.sha1
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5-sources.jar
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5-sources.jar.md5
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5-sources.jar.sha1
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5.aar
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5.aar.md5
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5.aar.sha1
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5.pom
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5.pom.md5
A androidx/room/room-rxjava2/2.2.5/room-rxjava2-2.2.5.pom.sha1
A androidx/room/room-testing/2.2.5/room-testing-2.2.5-sources.jar
A androidx/room/room-testing/2.2.5/room-testing-2.2.5-sources.jar.md5
A androidx/room/room-testing/2.2.5/room-testing-2.2.5-sources.jar.sha1
A androidx/room/room-testing/2.2.5/room-testing-2.2.5.aar
A androidx/room/room-testing/2.2.5/room-testing-2.2.5.aar.md5
A androidx/room/room-testing/2.2.5/room-testing-2.2.5.aar.sha1
A androidx/room/room-testing/2.2.5/room-testing-2.2.5.pom
A androidx/room/room-testing/2.2.5/room-testing-2.2.5.pom.md5
A androidx/room/room-testing/2.2.5/room-testing-2.2.5.pom.sha1

https://android-review.googlesource.com/1248853

ap...@google.com <ap...@google.com> #66Mar 3, 2020 05:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 7ce837660c516cc73e0253696458c29cf9452def
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Mar 03 09:01:51 2020

Import Room 2.2.5

This version includes fixes for parallel builds in androidx.

Bug: 146217083
Test: n/a
Change-Id: If25fb963e9aa3328bd7f860c5953fd830216d219

M paging/integration-tests/testapp/build.gradle
M work/integration-tests/testapp/build.gradle
M work/workmanager-gcm/build.gradle
M work/workmanager/build.gradle

https://android-review.googlesource.com/1248199

ap...@google.com <ap...@google.com> #67Mar 3, 2020 05:59PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fb21fa7e96cda2dec50c3028efb0ed9f9e343801
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Tue Mar 03 11:50:20 2020

Revert "Increasing javac verbosity on build server in room projects"

This reverts commit f27b98274038ccb5b1ec32f0945331893a5c4efe.

We haven't been observing the Gradle Daemon to be dying recently, so we probably don't need this extra logging anymore

Bug: 146217083
Test: Treehugger runs busytown/androidx.sh
Change-Id: I0f3773dd5a49aa9c1adf50e9ca6dc1c9db724d69

M buildSrc/src/main/kotlin/androidx/build/AndroidXPlugin.kt

https://android-review.googlesource.com/1247352

ap...@google.com <ap...@google.com> #68Mar 3, 2020 08:42PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1971cc5104921a879c373640cfcb829974ab3d4b
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Tue Mar 03 11:54:03 2020

Removing dmesg and ps diagnostics after build server build failure

We haven't been observing the Gradle Daemon to be dying recently, so we probably don't need this extra logging anymore

Bug: 146217083
Test: ./busytown/androidx.sh nonexistentTask # and see that no output from dmesg or ps gets displayed
Change-Id: I47342de71fa4f149d61c89844033d9e3f2f36c96

M gradlew

https://android-review.googlesource.com/1247952

ap...@google.com <ap...@google.com> #69Mar 9, 2020 10:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 564a16b6fd004103b6bd8e96de6124add37d31f5
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Mon Mar 09 20:55:00 2020

Revert "Telling the build server to kill java processes from other builds before starting the androidx builds"

This reverts commit 1965b01730af670017b8faeea17b6388a172e87d.

Reason for revert: Not needed anymore now that the builds are passing

Bug: 146217083
Test: treehugger runs busytown/androidx.sh

Change-Id: Idc035deb00a76d19be51cbf2d816517bf192eda2

M busytown/impl/build.sh

https://android-review.googlesource.com/1253913

ap...@google.com <ap...@google.com> #70Mar 23, 2020 11:54PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 04bf7dec2446480e85efb6b7baf42ccdd9a969b8
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Thu Feb 13 19:21:09 2020

Adding --no-daemon into validateRefactor.sh to make extra sure to avoid sharing state

Leaving the daemon running seems to be causing errors reading zip files

Bug: 146217083
Bug: 148450617
Test: BUILD_DOKKA=true ./development/validateRefactor.sh external/dokka:HEAD^
Change-Id: I24b78d49f5f6a863e16568aa30a0ae44317baa52

M development/validateRefactor.sh

https://android-review.googlesource.com/1261204

je...@google.com <je...@google.com> #71Mar 26, 2020 08:19PM

Marked as fixed.

I haven't heard any reports of this lately - I think that means it's fixed

hu...@google.com <hu...@google.com> #72Mar 27, 2020 11:04AM

Hi Jeff, can you maybe sum up 1 or 2 key takeaways from this (regarding the root cause, any mistakes, any lessons)? That'll benefit us all when we run into this problem again (not just this specific issue but the generic "Gradle build daemon disappear unexpectedly" issue). Thanks!

je...@google.com <je...@google.com> #73Mar 27, 2020 03:27PM

I think the main takeaway is to look harder for an hs_err_pid file when the daemon disappears

Now with

https://github.com/gradle/gradle/issues/12345 , Gradle should tell users where to find these files in the future.

I also compiled a longer summary of the story of this bug into go/diagnosing-androidx-gradle-daemon-disappearing but I forgot to mention it on this bug, sorry about that.

Thanks

ap...@google.com <ap...@google.com> #74Aug 28, 2020 07:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit fc943b6962353e2200f0c3a8835e5b39bf69dc47
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Fri Aug 28 09:28:59 2020

No longer having the build server builds list their out/ dirs

We're no longer having confusing problems where we need to rule out the possibility of inconsistent starting state
Now this is unneeded and a little distracting

Bug: 146217083
Bug: 140635374

Change-Id: Ie83ccab6c2b016dc723ebd866ff2d23dd23cf882

M busytown/impl/build.sh

https://android-review.googlesource.com/1413682

ap...@google.com <ap...@google.com> #75May 21, 2021 09:58PM

Project: platform/frameworks/support
Branch: androidx-main

commit 449de9fe40ce40a2d8374b6428a2dc4799c892ee
Author: Jeff Gaston <jeffrygaston@google.com>
Date: Tue May 18 15:41:15 2021

no longer copying daemon logs on failure

We haven't been observing daemons dying in a while

Bug: 146217083
Test: Treehugger runs busytown/*.sh

Change-Id: I31250a6c484f415efc6e133531fd380e3363dc13

M gradlew

https://android-review.googlesource.com/1714017

Issue 146217083

Description

Issue summary

Comments

je...@google.com <je...@google.com> #2Dec 13, 2019 08:33PM

je...@google.com <je...@google.com> #3Dec 13, 2019 08:33PM

je...@google.com <je...@google.com> #4Dec 13, 2019 08:33PM

ra...@google.com <ra...@google.com> #5Dec 18, 2019 09:58PM

ap...@google.com <ap...@google.com> #6Jan 7, 2020 12:12AM

ap...@google.com <ap...@google.com> #7Jan 7, 2020 05:36PM

je...@google.com <je...@google.com> #8Jan 8, 2020 10:25PM

je...@google.com <je...@google.com> #9Jan 27, 2020 07:20PM

je...@google.com <je...@google.com> #10Jan 27, 2020 07:21PM

au...@google.com <au...@google.com> #11Jan 27, 2020 07:22PM

ap...@google.com <ap...@google.com> #12Jan 28, 2020 07:45PM

je...@google.com <je...@google.com> #13Jan 29, 2020 07:28PM

je...@google.com <je...@google.com> #14Jan 30, 2020 03:33PM

je...@google.com <je...@google.com> #15Jan 30, 2020 03:34PM

je...@google.com <je...@google.com> #16Jan 30, 2020 07:06PM

ap...@google.com <ap...@google.com> #17Jan 30, 2020 08:14PM

ap...@google.com <ap...@google.com> #18Jan 30, 2020 09:51PM

je...@google.com <je...@google.com> #19Jan 31, 2020 04:03PM

ap...@google.com <ap...@google.com> #20Feb 4, 2020 07:38PM

je...@google.com <je...@google.com> #21Feb 5, 2020 09:23PM

je...@google.com <je...@google.com> #22Feb 5, 2020 09:25PM

au...@google.com <au...@google.com> #23Feb 5, 2020 09:32PM

je...@google.com <je...@google.com> #24Feb 5, 2020 09:39PM

ow...@google.com <ow...@google.com> #25Feb 6, 2020 12:04PM

je...@google.com <je...@google.com> #26Feb 6, 2020 05:55PM

je...@google.com <je...@google.com> #27Feb 6, 2020 06:01PM

ap...@google.com <ap...@google.com> #28Feb 6, 2020 06:21PM

ap...@google.com <ap...@google.com> #29Feb 6, 2020 10:10PM

ap...@google.com <ap...@google.com> #30Feb 7, 2020 12:17AM

ap...@google.com <ap...@google.com> #31Feb 10, 2020 10:54PM

je...@google.com <je...@google.com> #32Feb 11, 2020 07:01PM

yb...@google.com <yb...@google.com> #33Feb 11, 2020 07:21PM

je...@google.com <je...@google.com> #34Feb 11, 2020 07:45PM

au...@google.com <au...@google.com> #35Feb 11, 2020 11:11PM

yb...@google.com <yb...@google.com> #36Feb 12, 2020 02:36AM

je...@google.com <je...@google.com> #37Feb 13, 2020 10:47PM

je...@google.com <je...@google.com> #38Feb 13, 2020 11:08PM

ap...@google.com <ap...@google.com> #39Feb 14, 2020 01:01AM

je...@google.com <je...@google.com> #40Feb 18, 2020 06:33PM

yb...@google.com <yb...@google.com> #41Feb 18, 2020 07:27PM

je...@google.com <je...@google.com> #42Feb 18, 2020 08:41PM

je...@google.com <je...@google.com> #43Feb 18, 2020 09:30PM

je...@google.com <je...@google.com> #44Feb 19, 2020 03:58PM

yb...@google.com <yb...@google.com> #45Feb 19, 2020 04:51PM

je...@google.com <je...@google.com> #46Feb 25, 2020 12:47AM

yb...@google.com <yb...@google.com> #47Feb 25, 2020 02:03AM

ow...@google.com <ow...@google.com> #48Feb 25, 2020 12:27PM

ap...@google.com <ap...@google.com> #49Feb 25, 2020 09:55PM

au...@google.com <au...@google.com> #50Feb 25, 2020 09:56PM

je...@google.com <je...@google.com> #51Feb 25, 2020 10:05PM

ap...@google.com <ap...@google.com> #52Feb 25, 2020 11:55PM

ap...@google.com <ap...@google.com> #53Feb 26, 2020 01:30AM

ya...@google.com <ya...@google.com> #54Feb 26, 2020 02:30AM

je...@google.com <je...@google.com> #55Feb 26, 2020 03:08AM

ya...@google.com <ya...@google.com> #56Feb 26, 2020 03:09AM

yb...@google.com <yb...@google.com> #57Feb 26, 2020 03:18AM

ya...@google.com <ya...@google.com> #58Feb 26, 2020 03:43AM

il...@google.com <il...@google.com> #59Feb 26, 2020 06:07PM

ni...@google.com <ni...@google.com> #60Feb 26, 2020 06:42PM

ap...@google.com <ap...@google.com> #61Feb 26, 2020 08:26PM

ap...@google.com <ap...@google.com> #62Feb 27, 2020 09:57PM

ap...@google.com <ap...@google.com> #63Mar 2, 2020 05:39PM

an...@google.com <an...@google.com> #64Mar 2, 2020 09:36PM

ap...@google.com <ap...@google.com> #65Mar 3, 2020 05:51PM

ap...@google.com <ap...@google.com> #66Mar 3, 2020 05:51PM

ap...@google.com <ap...@google.com> #67Mar 3, 2020 05:59PM

ap...@google.com <ap...@google.com> #68Mar 3, 2020 08:42PM

ap...@google.com <ap...@google.com> #69Mar 9, 2020 10:22PM

ap...@google.com <ap...@google.com> #70Mar 23, 2020 11:54PM

je...@google.com <je...@google.com> #71Mar 26, 2020 08:19PM

hu...@google.com <hu...@google.com> #72Mar 27, 2020 11:04AM

je...@google.com <je...@google.com> #73Mar 27, 2020 03:27PM

ap...@google.com <ap...@google.com> #74Aug 28, 2020 07:03PM

ap...@google.com <ap...@google.com> #75May 21, 2021 09:58PM

Add comment

Issue metadata