Room appears to use the wrong Generated annotation when building with JDK 10, [146538330]

Fixed

Bug

Status Update

No update yet.

Description

jl...@gmail.com

created issue #1

Dec 19, 2019 09:42AM

My application started to fail during compilation.
I get the error that the @Generated Annotation can not be found because the package javax.annotation does not exist.

CustomerDao_Impl.java:24: error: package javax.annotation does not exist
import javax.annotation.Generated;

CustomerDao_Impl.java:26: error: cannot find symbol
@Generated("androidx.room.RoomProcessor")

This happens when compiling an Android App on Mac OS with

javac --version
javac 10.0.2

I use version 2.1.0 for room-runtime and room-compiler

In Android Studio the app builds fine.

I found a similar issue in Dagger:

https://github.com/google/dagger/issues/1339

Comments

ad...@google.com <ad...@google.com> Dec 20, 2019 10:35AM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Dec 20, 2019 04:37PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

jl...@gmail.com <jl...@gmail.com> #3Dec 22, 2019 02:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

da...@google.com <da...@google.com> #4Jan 6, 2020 05:38PM

deleted

jl...@gmail.com <jl...@gmail.com> #5Jan 9, 2020 10:12AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Jan 24, 2020 10:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d26e7b29d7b29d77f18a00873ff0446013a0b8ee
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Jan 24 08:28:53 2020

Use javax.annotation.processing.Generated on source versions 9+

This changes makes it so that the Room annotation processor generates
code with the right @Generated annotation when the target source
version is 9 or higher.

Bug: 146538330
Test: Manual test since AndroidX is tied to JDK8
Change-Id: Ief247399c347d0970be77cb38f6e22cc48e8faea

M room/compiler/src/main/kotlin/androidx/room/writer/ClassWriter.kt

https://android-review.googlesource.com/1217401

da...@google.com <da...@google.com> Jan 24, 2020 10:40PM

Marked as fixed.

an...@google.com <an...@google.com> #7Jan 31, 2020 10:00PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/history/all)
Created: 2020-01-31 21:58:40.367179+00:00
Changes: aosp/1217401

be...@bytedance.com <be...@bytedance.com> #8Aug 21, 2020 03:49AM

in room 2.2.5 version
kotlin 1.4.0 version
javac 10.0.2

It happened again