Room appears to use the wrong Generated annotation when building with JDK 10, [146538330]

Fixed

Bug

Status Update

No update yet.

Description

jl...@gmail.com

created issue #1

Dec 19, 2019 09:42AM

My application started to fail during compilation.
I get the error that the @Generated Annotation can not be found because the package javax.annotation does not exist.

CustomerDao_Impl.java:24: error: package javax.annotation does not exist
import javax.annotation.Generated;

CustomerDao_Impl.java:26: error: cannot find symbol
@Generated("androidx.room.RoomProcessor")

This happens when compiling an Android App on Mac OS with

javac --version
javac 10.0.2

I use version 2.1.0 for room-runtime and room-compiler

In Android Studio the app builds fine.

I found a similar issue in Dagger:

https://github.com/google/dagger/issues/1339

Comments

ad...@google.com <ad...@google.com> Dec 20, 2019 10:35AM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Dec 20, 2019 04:37PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

jl...@gmail.com <jl...@gmail.com> #3Dec 22, 2019 02:04PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

da...@google.com <da...@google.com> #4Jan 6, 2020 05:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

jl...@gmail.com <jl...@gmail.com> #5Jan 9, 2020 10:12AM

This happens for me with Kotlin version 1.3.61 and Kotlin version 1.3.60

For compiling we use the following configuration to define the source version:

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all {
kotlinOptions {
jvmTarget = JavaVersion.VERSION_1_8
}
}

ap...@google.com <ap...@google.com> #6Jan 24, 2020 10:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d26e7b29d7b29d77f18a00873ff0446013a0b8ee
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Jan 24 08:28:53 2020

Use javax.annotation.processing.Generated on source versions 9+

This changes makes it so that the Room annotation processor generates
code with the right @Generated annotation when the target source
version is 9 or higher.

Bug: 146538330
Test: Manual test since AndroidX is tied to JDK8
Change-Id: Ief247399c347d0970be77cb38f6e22cc48e8faea

M room/compiler/src/main/kotlin/androidx/room/writer/ClassWriter.kt

https://android-review.googlesource.com/1217401

da...@google.com <da...@google.com> Jan 24, 2020 10:40PM

Marked as fixed.

an...@google.com <an...@google.com> #7Jan 31, 2020 10:00PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/history/all)
Created: 2020-01-31 21:58:40.367179+00:00
Changes: aosp/1217401

be...@bytedance.com <be...@bytedance.com> #8Aug 21, 2020 03:49AM

in room 2.2.5 version
kotlin 1.4.0 version
javac 10.0.2

It happened again