Fixed
Status Update
No update yet.
Comments
yb...@google.com
Thank you for the report and the code causing the issue. I have landed a reproduction which shows that the code thrown an ArrayIndexOutOfBoundsException from the last bitSet.toByteArray()[0] when not processed by R8.
da...@google.com
Project: r8
Branch: main
Author: Søren Gjesse <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: bf9b1962052bf91689120a09deded518e37862a2
Date: Wed Jan 22 09:41:15 2025
ap...@google.com
deleted
da...@google.com
an...@google.com
I'm really sorry, please use the source code below:
public class R8Test {
public byte[] toBytes(boolean on) {
byte[] bytes = new byte[3];
bytes[0] = 1;
BitSet bits = new BitSet(8);
byte[] byteArray = bits.toByteArray();
if (byteArray != null && byteArray.length >= 1) {
bytes[1] = bits.toByteArray()[0];
}
BitSet bitSet = new BitSet(8);
byte[] byteArray2 = bits.toByteArray();
if (byteArray2 != null && byteArray2.length >= 1) {
bytes[2] = bitSet.toByteArray()[0];
}
return bytes;
}
}
Description
Version used: 2.2.3
Devices/Android versions reproduced on: n/a
Android Studio 3.5.3
Build #AI-191.8026.42.35.6010548, built on November 15, 2019
JRE: 1.8.0_202-release-1483-b49-5587405 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 5.3.0-24-generic
Steps to Reproduce:
1. Import the attached project into Android Studio (tested on 3.5.3)
2. Attempt to build the InterfaceSuspend module
Expected Results: A clean build
Actual Results: A build error:
error: Bookstore_Impl is not abstract and does not override abstract method loadCategoryByTransaction(String,Continuation<? super Pair<Category,? extends List<Book>>>) in Bookstore
public final class Bookstore_Impl implements Bookstore {
^
1 error
Here, Bookstore is a Kotlin interface with a @Dao annotation, defining a concrete suspending function that calls two other functions that should get code-generated:
@Dao
interface Bookstore {
@Insert
suspend fun save(category: Category)
@Insert
suspend fun save(vararg books: Book)
suspend fun loadCategoryByTransaction(shortCode: String) =
_loadCategory(shortCode) to _loadBooksInCategory(shortCode)
@Query("SELECT * FROM categories WHERE shortCode = :shortCode")
suspend fun _loadCategory(shortCode: String): Category
@Query("SELECT * FROM books WHERE categoryShortCode = :shortCode")
suspend fun _loadBooksInCategory(shortCode: String): List<Book>
}
If you switch this to be an abstract class, it compiles (see the AbstractSuspend module). If you add @Transaction to the function on the interface, it compiles (see the InterfaceTransaction module), though there's a separate bug with that (to be filed shortly).
Let me know if you need more details -- thanks!