Allow databases to be created from compressed asset files [146911060]

Fixed

Feature Request

androidx-bug-bounty

Status Update

No update yet.

Description

jo...@fueledbycaffeine.com

created issue #1

Dec 27, 2019 09:58PM

Component used: Room
Version used: 2.2.3

We got the ability to create room databases from assets or other files in

b/62185732

which is great. However, in my app I am packaging a GZipped sqlite database to save download space. The database is read-only and contains a moderate amount of data, so the APK size savings is about 1MB. Another app I work on that could benefit from this packages a 10MB sqlite database which gzips down to 3MB.

My current workaround is to manually decompress the gzipped asset into the application's database directory, but there's no reason that the room database builder couldn't handle this step on it's own.

Comments

zh...@gmail.com <zh...@gmail.com> #2Dec 31, 2019 02:22AM

Related ticket: b/152046065

yb...@google.com <yb...@google.com> #3Jul 30, 2020 08:35PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c0fd11cab1b083d043dfd54c8431c4068aeef09a
Author: Matvei Malkov <malkov@google.com>
Date: Wed Nov 04 17:35:35 2020

Add Modifier.focusable

This CL adds Modifier.focusable, which is intended to be a primary way to add focusability to the app (without clicks or with custom clicks), since it contains proper a11y and InteractionState support

Change-Id: I41eb9d67669e19f8a7c20804c836a8c6dc0b5526
RelNote: "Modifier.focusable has need added in foundation. Use this to add focusable behavior to a component, with correct semantics and accessibility."
Bug: 152525426
Bug: 162865824
Bug: 163423216
Test: added

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/FocusableSample.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ScrollableSamples.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Interaction.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt

https://android-review.googlesource.com/1487281

ah...@gmail.com <ah...@gmail.com> #4Jul 31, 2020 05:11PM

focusable and hoverable have been added.

Filed separate bugs for 2d scroll (b/214410040) and 2d draggable (b/214412658), with that let's close this bug and consider new feature reuqests on case-by-case basis.

yb...@google.com <yb...@google.com> #5Jul 31, 2020 08:14PM

awesome, thanks a lot!

ah...@gmail.com <ah...@gmail.com> #6Jul 31, 2020 08:46PM

https://github.com/androidx/androidx/pull/49

ap...@google.com <ap...@google.com> #7Aug 5, 2020 04:07AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3e6792c7521cdf41c295a1c0037137ecf9c7a005
Author: Ahmed El-Helw <ahmedre@gmail.com>
Date: Wed Aug 05 00:03:57 2020

[GH] Support opening gzipped databases.

This patch adds a method for creating a database from a gzipped file.
This is only implemented for external files, since assets are
transparently gzipped and extracted by the build tools.

Test: Added a unit test to SQLiteCopyOpenHelperTest.
Fixes:

b/146911060

This is an imported pull request from

https://github.com/androidx/androidx/pull/49.

Resolves #49
Github-Pr-Head-Sha: 568196d7b1800e9055de0dae7f509008cbc64c71
GitOrigin-RevId: 5de26bc6b6107d6aa2079f53d303e1216879ffa9
Change-Id: Ibd6b85f03748062a1ced22daf250944d5f07ef5b

M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/PrepackageTest.java
A room/integration-tests/testapp/src/main/assets/databases/products_v1.db.zip
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
M room/runtime/src/main/java/androidx/room/SQLiteCopyOpenHelper.java
M room/runtime/src/main/java/androidx/room/SQLiteCopyOpenHelperFactory.java
M room/runtime/src/test/java/androidx/room/BuilderTest.java
M room/runtime/src/test/java/androidx/room/SQLiteCopyOpenHelperTest.kt

https://android-review.googlesource.com/1388184

ap...@google.com <ap...@google.com> #8Aug 5, 2020 04:07AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1263185ef8c50d4059758e382610345a24f82c53
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Fri Jul 31 19:28:39 2020

Minor changes and API files update for aosp/1384212

Additionally add new copyFromInputStream property to
DatabaseConfiguration for consistency.

Fixes:

b/146911060

Relnote: N/A
Test: ./gradlew bOS
Change-Id: I6fca34150c96a7039211ee3db46cf9a714667a9c

M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/PrepackageTest.java
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/DatabaseConfiguration.java
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
M room/runtime/src/main/java/androidx/room/SQLiteCopyOpenHelper.java
M room/runtime/src/main/java/androidx/room/SQLiteCopyOpenHelperFactory.java
M room/testing/src/main/java/androidx/room/testing/MigrationTestHelper.java

https://android-review.googlesource.com/1384013