IllegalStateException > Not allowed to start service Intent ACTION_STOP_FOREGROUND [147249312]

Fixed

Bug

Status Update

No update yet.

Description

ha...@gmail.com

created issue #1

Jan 7, 2020 08:32AM

Component used: androidx.work:work-runtime-ktx
Version used: 2.3.0-beta01
Devices/Android versions reproduced on: Galaxy A7 (Android 9) / Galaxy S10 (Android 10)

versions.build = [
minsdk : 23,
targetsdk : 29,
buildtools: "29.0.2",
]

---

I get a crash after start using the new foreground API in 2.3.0. I'm using `CoroutineWorker` and calling `setForeground()` in its `doWork()` with a notification which has an action created by `WorkManager.getInstance(context).createCancelPendingIntent(id)`. This should stop the job when clicked.

This seemed to work fine but after releasing, it crashes for some users with the following stacktrace (on Android 10; on Android 9 the line is 1666 instead of 1687):

```
Fatal Exception: java.lang.IllegalStateException: Not allowed to start service Intent { act=ACTION_STOP_FOREGROUND cmp=de.loewen.lcsmobile/androidx.work.impl.foreground.SystemForegroundService }: app is in background uid UidRecord{da09b33 u0a309 CEM idle change:cached procs:1 proclist:29769, seq(0,0,0)}
at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1687)
at android.app.ContextImpl.startService(ContextImpl.java:1632)
at android.content.ContextWrapper.startService(ContextWrapper.java:683)
at androidx.work.impl.Processor.stopForegroundService(Processor.java:303)
at androidx.work.impl.Processor.stopForeground(Processor.java:221)
at androidx.work.impl.WorkerWrapper.resolve(WorkerWrapper.java:453)
at androidx.work.impl.WorkerWrapper.setFailedAndResolve(WorkerWrapper.java:519)
at androidx.work.impl.WorkerWrapper.handleResult(WorkerWrapper.java:485)
at androidx.work.impl.WorkerWrapper.onWorkFinished(WorkerWrapper.java:343)
at androidx.work.impl.WorkerWrapper$2.run(WorkerWrapper.java:318)
at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:919)
```

I've looked into the changelog of 2.3.0-beta02 but it doesn't seem like there's already a fix for this problem.

The stacktrace doesn't contain a line of my app, only the workmanager-library so I think its crashing after the users clicks the cancel-action on the notification.

Comments

ra...@google.com <ra...@google.com> #2Jan 7, 2020 07:03PM

Tentatively, the annotation should be something use-case-specific like @OutlinedNewApi that allows alternative build systems (e.g. not R8/D8) to make their own decisions. We'll provide a default Proguard configuration for R8, but it's not guaranteed this will work as intended -- outlining is automatic in newer versions, but it may be disabled.

ra...@google.com <ra...@google.com> #3Jan 8, 2020 11:11PM

Status: Won't Fix (Obsolete)

Just as an FYI, this was enabled in AGP 2 years ago (AGP 7.3 as far as I remember), ag/18426192, so for AGP users it might fine to just remove the rule for @DoNotInline. I like the @OutlinedNewApi to make it clear what this is for other consumers to handle it as they see fit.

ha...@gmail.com <ha...@gmail.com> #4Jan 9, 2020 10:40AM

This article from Morten Krogh-Jespersen suggests it wasn't (perma-)enabled by default until AGP 8.1, which is only <redacted>% of users.

Given the failure mode can include run-time crashes, that's not an acceptable level of usage.

da...@gmail.com <da...@gmail.com> #5Jan 21, 2020 10:08AM

I think you can still include a top-level proguard.txt, and it will be used by versions that do not support the com.android.tools format. E.g. Kotlin Coroutines library does this

da...@gmail.com <da...@gmail.com> #6Jan 21, 2020 11:51AM

Yeah, I that combined with r8-upto is the right approach. comment#4 is in regard to the idea that we should remove the annotations from source instead of gating the rules on R8 version.

ra...@google.com <ra...@google.com> #7Jan 21, 2020 06:25PM

Looping in from offline, any new libraries require a high enough compileSdk that we're going to see a recent-enough AGP. So, we should just remove our manual outlining and use of @DoNotInline.

ra...@google.com <ra...@google.com> #8Jan 21, 2020 06:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit 0c5446468c1e1fc08b1cea04dc57b05c52417ce8
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 13:50:59 2024

Disable class verification failure lint checks

They are no longer needed since we transitively require AGP 8.1.

Bug: 345472586
Test: ./gradlew lintDebug
Change-Id: Icb6ad18297fef4a23071cd849b6e84855d2becd0

M lint-checks/src/main/java/androidx/build/lint/AndroidXIssueRegistry.kt

https://android-review.googlesource.com/3156137

da...@gmail.com <da...@gmail.com> #9Jan 22, 2020 08:26AM

Project: platform/frameworks/support
Branch: androidx-main

commit 722ebe758557abaf7409c052bb2f326782369c84
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:05:38 2024

Remove usage of @DoNotInline for manual NewApi outlines (R thru W)

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: Ia60e0ab9f0fd613883a772c8aa34e27cc986cae8

M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/GridLayoutManager.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/MainActivity.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/activities/systemrouting/source/AudioManagerSystemRoutesSource.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/player/Player.java
M samples/MediaRoutingDemo/src/main/java/com/example/androidx/mediarouting/providers/SampleMediaRouteProvider.java
M security/security-crypto/src/main/java/androidx/security/crypto/MasterKey.java
M security/security-identity-credential/src/main/java/androidx/security/identity/HardwareIdentityCredential.java
M slice/slice-core/src/main/java/androidx/slice/Slice.java
M slice/slice-core/src/main/java/androidx/slice/compat/SliceProviderCompat.java
M sqlite/sqlite-framework/src/androidMain/kotlin/androidx/sqlite/db/framework/FrameworkSQLiteDatabase.android.kt
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/AccessibilityNodeInfoDumper.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/ByMatcher.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/UiDevice.java
M test/uiautomator/uiautomator/src/main/java/androidx/test/uiautomator/UiObject2.java
M testutils/testutils-runtime/src/main/java/androidx/testutils/AndroidFontScaleHelper.kt
M text/text/src/main/java/androidx/compose/ui/text/android/BoringLayoutFactory.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/PaintExtensions.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/StaticLayoutFactory.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextAndroidCanvas.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/selection/SegmentFinder.android.kt
M tracing/tracing/src/main/java/androidx/tracing/TraceApi29Impl.java
M transition/transition/src/main/java/androidx/transition/CanvasUtils.java
M transition/transition/src/main/java/androidx/transition/GhostViewHolder.java
M transition/transition/src/main/java/androidx/transition/ImageViewUtils.java
M transition/transition/src/main/java/androidx/transition/ObjectAnimatorUtils.java
M transition/transition/src/main/java/androidx/transition/PropertyValuesHolderUtils.java
M transition/transition/src/main/java/androidx/transition/Transition.java
M transition/transition/src/main/java/androidx/transition/TransitionUtils.java
M transition/transition/src/main/java/androidx/transition/ViewGroupUtils.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi19.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi21.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi22.java
M transition/transition/src/main/java/androidx/transition/ViewUtilsApi23.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/AnimatedVectorDrawableCompat.java
M versionedparcelable/versionedparcelable/src/main/java/androidx/versionedparcelable/VersionedParcel.java
M wear/protolayout/protolayout-expression-pipeline/src/main/java/androidx/wear/protolayout/expression/pipeline/NumberFormatter.java
M wear/tiles/tiles/src/main/java/androidx/wear/tiles/TileService.java
M wear/watchface/watchface-complications-data/src/main/java/androidx/wear/watchface/utility/TraceEvent.kt
M wear/wear-remote-interactions/src/main/java/androidx/wear/remote/interactions/RemoteInteractionsUtil.kt
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForM.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForN.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForO.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForOMR1.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForP.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForQ.java
M webkit/webkit/src/main/java/androidx/webkit/internal/ApiHelperForTiramisu.java
M window/window/src/main/java/androidx/window/embedding/ExtensionEmbeddingBackend.kt
M window/window/src/main/java/androidx/window/embedding/SplitRule.kt
M window/window/src/main/java/androidx/window/layout/util/ContextCompatHelper.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableRuntimeExtras.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabasePathHelper.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundService.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/DurationApi26.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi21.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi23.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkApi24.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/NetworkRequestCompat.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/ProcessUtils.kt

https://android-review.googlesource.com/3156141

da...@gmail.com <da...@gmail.com> #10Jan 22, 2020 08:27AM

Project: platform/frameworks/support
Branch: androidx-main

commit a3c2cdfa79630ce1b6ccfae79068b331bd86889f
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:07:44 2024

Remove fully-qualified usages of @DoNotInline for manual NewApi outlines

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: I5921633fee80fcbc2c6ee05cb94f5fab0b9a6daf

M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidGraphicsContext.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPaint.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidRenderEffect.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/AndroidGraphicsLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV23.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayerV29.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsViewLayer.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/LayerManager.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/layer/LayerSnapshot.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi29.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.android.kt
M graphics/graphics-core/src/main/java/androidx/graphics/CanvasBufferedRendererV29.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/BufferTransformHintResolver.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/FrontBufferUtils.kt
M graphics/graphics-core/src/main/java/androidx/graphics/lowlatency/LowLatencyCanvasView.kt
M graphics/graphics-core/src/main/java/androidx/graphics/surface/SurfaceControlCompat.kt
M graphics/graphics-core/src/main/java/androidx/graphics/surface/SurfaceControlV33.kt
M graphics/graphics-core/src/main/java/androidx/hardware/SyncFenceCompat.kt
M leanback/leanback/src/main/java/androidx/leanback/widget/GuidedActionsStylist.java

https://android-review.googlesource.com/3156142

da...@gmail.com <da...@gmail.com> #11Jan 22, 2020 08:49AM

Remaining work:

Get the last few @DoNotInline CLs merged
Inline existing NewApi classes
- Or don't? Users running R8 won't see a difference, users not running R8/D8 will get VFY errors
- Write a lint auto-fix to automate this?

ra...@google.com <ra...@google.com> #12Jan 22, 2020 06:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 72d83666a81c444dfc045e292cf52e3ec9c69d8b
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 14:03:53 2024

Remove usage of @DoNotInline for manual NewApi outlines (Cr thru P)

Excludes some privacysandbox libraries because I'm not certain how the
annotation is being used there.

Suppresses flaky PrimitiveInCollection lint failure in Glance.

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: If6b4ccfca0a943b45971a422b58949b13a10bada

M credentials/credentials-play-services-auth/src/main/java/androidx/credentials/playservices/controllers/CreatePublicKeyCredential/PublicKeyCredentialControllerUtility.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginCreateCredentialRequest.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginCreateCredentialResponse.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginGetCredentialRequest.kt
M credentials/credentials/src/main/java/androidx/credentials/provider/BeginGetCredentialResponse.kt
M datastore/datastore/src/androidMain/kotlin/androidx/datastore/migrations/SharedPreferencesMigration.android.kt
M draganddrop/draganddrop/src/main/java/androidx/draganddrop/DropAffordanceHighlighter.java
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/ConcurrencyHelpers.java
M emoji2/emoji2/src/main/java/androidx/emoji2/text/EmojiExclusions.java
M exifinterface/exifinterface/src/main/java/androidx/exifinterface/media/ExifInterfaceUtils.java
M fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.kt
M glance/glance-appwidget/lint-baseline.xml
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/AppWidgetUtils.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/ApplyModifiers.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/GlanceAppWidgetManager.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/GlanceRemoteViewsService.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/LayoutSelection.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/RemoteViewsTranslator.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/WidgetLayout.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/action/ActionTrampoline.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/action/ApplyAction.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/translators/CompoundButtonApi31Impl.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/translators/ImageTranslator.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/translators/TextTranslator.kt
M glance/glance/src/main/java/androidx/glance/session/IdleEventBroadcastReceiver.kt
M glance/glance/src/main/java/androidx/glance/unit/ColorProvider.kt
M health/connect/connect-client/src/main/java/androidx/health/connect/client/HealthConnectClient.kt
M health/connect/connect-client/src/main/java/androidx/health/platform/client/impl/data/SharedMemory27Impl.kt
M input/input-motionprediction/src/main/java/androidx/input/motionprediction/common/PredictionEstimator.java
M leanback/leanback/src/main/java/androidx/leanback/app/FragmentUtil.java
M lifecycle/lifecycle-process/src/main/java/androidx/lifecycle/ProcessLifecycleOwner.kt
M media/media/src/main/java/android/support/v4/media/MediaBrowserCompat.java
M media/media/src/main/java/android/support/v4/media/MediaDescriptionCompat.java
M media/media/src/main/java/android/support/v4/media/session/MediaSessionCompat.java
M media/media/src/main/java/android/support/v4/media/session/PlaybackStateCompat.java
M media/media/src/main/java/androidx/media/AudioFocusRequestCompat.java
M media/media/src/main/java/androidx/media/AudioManagerCompat.java
M media/media/src/main/java/androidx/media/VolumeProviderCompat.java
M media/media/src/main/java/androidx/media/app/NotificationCompat.java
M media/media/src/main/java/androidx/media/session/MediaButtonReceiver.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/app/SystemOutputSwitcherDialogController.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRoute2Provider.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRouter2Utils.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/MediaRouterUtils.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/PlatformMediaRouter1RouteProvider.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/RemotePlaybackClient.java
M mediarouter/mediarouter/src/main/java/androidx/mediarouter/media/RouteListingPreference.java
M preference/preference/src/main/java/androidx/preference/PreferenceCategory.java
M preference/preference/src/main/java/androidx/preference/PreferenceDialogFragment.java
M preference/preference/src/main/java/androidx/preference/PreferenceDialogFragmentCompat.java
M print/print/src/main/java/androidx/print/PrintHelper.java
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/InMemorySdkClassLoaderFactory.kt
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/impl/MigrationUtils.kt
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/impl/SandboxedSdkContextCompat.kt
M privacysandbox/sdkruntime/sdkruntime-client/src/main/java/androidx/privacysandbox/sdkruntime/client/loader/storage/LocalSdkFolderProvider.kt
M privacysandbox/sdkruntime/sdkruntime-core/src/main/java/androidx/privacysandbox/sdkruntime/core/LoadSdkCompatException.kt
M privacysandbox/sdkruntime/sdkruntime-core/src/main/java/androidx/privacysandbox/sdkruntime/core/SandboxedSdkCompat.kt
M privacysandbox/ui/ui-client/src/main/java/androidx/privacysandbox/ui/client/view/SandboxedSdkView.kt
M privacysandbox/ui/ui-provider/src/main/java/androidx/privacysandbox/ui/provider/BinderAdapterDelegate.kt
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileInstallerInitializer.java
M profileinstaller/profileinstaller/src/main/java/androidx/profileinstaller/ProfileVerifier.java

https://android-review.googlesource.com/3156140

ra...@google.com <ra...@google.com> #13Jan 22, 2020 08:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit 10ffa70a46c505e0af76fc71d93af285f7527bdf
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 09 11:02:59 2024

Remove usage of @DoNotInline for manual NewApi outlines (Com thru Cor)

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: Ieb9aecd2af5587c5b82833146fee6e912693ab7b

M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/EdgeEffectCompat.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/EditorInfo.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/HandwritingGesture.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/InputMethodManager.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyCursorAnchorInfoBuilder.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/RecordingInputConnection.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/StatelessInputConnection.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldLayoutStateCache.android.kt
M compose/material/material-ripple/src/androidMain/kotlin/androidx/compose/material/ripple/RippleHostView.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/DynamicTonalPalette.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/AccessibilityServiceStateProvider.android.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunner.android.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/ViewCapture.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidColorFilter.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidColorSpace.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidImageBitmap.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidTileMode.android.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/CanvasUtils.android.kt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/android/WindowCapture.android.kt
M compose/ui/ui-text-google-fonts/src/main/java/androidx/compose/ui/text/googlefonts/HandlerHelper.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontUtils.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidPreloadedFont.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidAccessibilitySpannableString.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidFontListTypeface.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/LocaleExtensions.android.kt
M compose/ui/ui-tooling/src/androidMain/kotlin/androidx/compose/ui/tooling/LayoutlibFontResourceLoader.android.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/viewinterop/ViewInterop.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AndroidSemanticAutofill.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AutofillCallback.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/autofill/AutofillUtils.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/contentcapture/AndroidContentCaptureManager.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/pointer/MotionEventAdapter.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidAccessibilityManager.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidClipboardManager.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidFontResourceLoader.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidTextToolbar.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidViewConfiguration.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/res/ColorResources.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/scrollcapture/ScrollCapture.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/CursorAnchorInfoBuilder.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/window/AndroidPopup.android.kt
M compose/ui/ui/src/main/java/androidx/compose/ui/platform/coreshims/ContentCaptureSessionCompat.java
M compose/ui/ui/src/main/java/androidx/compose/ui/platform/coreshims/ViewCompatShims.java
M compose/ui/ui/src/main/java/androidx/compose/ui/platform/coreshims/ViewStructureCompat.java
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionLayout.kt
M core/core-animation/src/main/java/androidx/core/animation/PathUtils.java
M core/core-i18n/src/main/java/androidx/core/i18n/DateTimeFormatter.kt
M core/core-ktx/src/main/java/androidx/core/content/res/TypedArray.kt
M core/core-ktx/src/main/java/androidx/core/os/Bundle.kt
M core/core-ktx/src/main/java/androidx/core/os/PersistableBundle.kt
M core/core-location-altitude/src/main/java/androidx/core/location/altitude/AltitudeConverterCompat.java
M core/core-remoteviews/src/main/java/androidx/core/widget/AppWidgetManagerCompat.kt
M core/core-remoteviews/src/main/java/androidx/core/widget/RemoteViewsCompat.kt
M core/core-splashscreen/src/main/java/androidx/core/splashscreen/ThemeUtils.kt
M core/core-telecom/src/main/java/androidx/core/telecom/extensions/CallExtensions.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/CallSessionLegacy.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/utils/CallAttributesUtils.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/utils/EndpointUtils.kt
M core/core-telecom/src/main/java/androidx/core/telecom/internal/utils/Utils.kt
M core/core/src/androidTest/java/androidx/core/location/LocationRequestCompatTestApi19.java
M core/core/src/main/java/androidx/core/app/ActivityCompat.java
M core/core/src/main/java/androidx/core/app/ActivityOptionsCompat.java
M core/core/src/main/java/androidx/core/app/AlarmManagerCompat.java
M core/core/src/main/java/androidx/core/app/AppOpsManagerCompat.java
M core/core/src/main/java/androidx/core/app/DialogCompat.java
M core/core/src/main/java/androidx/core/app/GrammaticalInflectionManagerCompat.java
M core/core/src/main/java/androidx/core/app/LocaleManagerCompat.java
M core/core/src/main/java/androidx/core/app/NotificationChannelCompat.java
M core/core/src/main/java/androidx/core/app/NotificationChannelGroupCompat.java
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
M core/core/src/main/java/androidx/core/app/NotificationCompatBuilder.java
M core/core/src/main/java/androidx/core/app/NotificationManagerCompat.java
M core/core/src/main/java/androidx/core/app/PendingIntentCompat.java
M core/core/src/main/java/androidx/core/app/Person.java
M core/core/src/main/java/androidx/core/app/RemoteActionCompat.java
M core/core/src/main/java/androidx/core/app/RemoteInput.java
M core/core/src/main/java/androidx/core/app/ServiceCompat.java
M core/core/src/main/java/androidx/core/content/ContextCompat.java
M core/core/src/main/java/androidx/core/content/FileProvider.java
M core/core/src/main/java/androidx/core/content/IntentCompat.java
M core/core/src/main/java/androidx/core/content/IntentSanitizer.java
M core/core/src/main/java/androidx/core/content/pm/PackageInfoCompat.java
M core/core/src/main/java/androidx/core/content/pm/PermissionInfoCompat.java
M core/core/src/main/java/androidx/core/content/res/FontResourcesParserCompat.java
M core/core/src/main/java/androidx/core/content/res/ResourcesCompat.java
M core/core/src/main/java/androidx/core/database/CursorWindowCompat.java
M core/core/src/main/java/androidx/core/database/sqlite/SQLiteCursorCompat.java
M core/core/src/main/java/androidx/core/graphics/BitmapCompat.java
M core/core/src/main/java/androidx/core/graphics/BlendModeColorFilterCompat.java
M core/core/src/main/java/androidx/core/graphics/BlendModeUtils.java
M core/core/src/main/java/androidx/core/graphics/ColorUtils.java
M core/core/src/main/java/androidx/core/graphics/Insets.java
M core/core/src/main/java/androidx/core/graphics/PaintCompat.java
M core/core/src/main/java/androidx/core/graphics/PathUtils.java
M core/core/src/main/java/androidx/core/graphics/drawable/DrawableCompat.java
M core/core/src/main/java/androidx/core/graphics/drawable/IconCompat.java
M core/core/src/main/java/androidx/core/hardware/fingerprint/FingerprintManagerCompat.java
M core/core/src/main/java/androidx/core/location/GnssStatusWrapper.java
M core/core/src/main/java/androidx/core/location/LocationCompat.java
M core/core/src/main/java/androidx/core/location/LocationManagerCompat.java
M core/core/src/main/java/androidx/core/location/LocationRequestCompat.java
M core/core/src/main/java/androidx/core/net/ConnectivityManagerCompat.java
M core/core/src/main/java/androidx/core/net/TrafficStatsCompat.java
M core/core/src/main/java/androidx/core/os/BuildCompat.kt
M core/core/src/main/java/androidx/core/os/BundleCompat.java
M core/core/src/main/java/androidx/core/os/ConfigurationCompat.java
M core/core/src/main/java/androidx/core/os/EnvironmentCompat.java
M core/core/src/main/java/androidx/core/os/LocaleListCompat.java
M core/core/src/main/java/androidx/core/os/LocaleListCompatWrapper.java
M core/core/src/main/java/androidx/core/os/MessageCompat.java
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
M core/core/src/main/java/androidx/core/os/TraceCompat.java
M core/core/src/main/java/androidx/core/os/UserManagerCompat.java
M core/core/src/main/java/androidx/core/provider/DocumentsContractCompat.java
M core/core/src/main/java/androidx/core/service/quicksettings/TileServiceCompat.java
M core/core/src/main/java/androidx/core/telephony/SubscriptionManagerCompat.java
M core/core/src/main/java/androidx/core/telephony/TelephonyManagerCompat.java
M core/core/src/main/java/androidx/core/text/HtmlCompat.java
M core/core/src/main/java/androidx/core/text/ICUCompat.java
M core/core/src/main/java/androidx/core/text/PrecomputedTextCompat.java
M core/core/src/main/java/androidx/core/text/util/LinkifyCompat.java
M core/core/src/main/java/androidx/core/text/util/LocalePreferences.java
M core/core/src/main/java/androidx/core/util/SizeFCompat.java
M core/core/src/main/java/androidx/core/util/TypedValueCompat.java
M core/core/src/main/java/androidx/core/view/ContentInfoCompat.java
M core/core/src/main/java/androidx/core/view/DisplayCompat.java
M core/core/src/main/java/androidx/core/view/DisplayCutoutCompat.java
M core/core/src/main/java/androidx/core/view/DragAndDropPermissionsCompat.java
M core/core/src/main/java/androidx/core/view/MenuCompat.java
M core/core/src/main/java/androidx/core/view/MenuItemCompat.java
M core/core/src/main/java/androidx/core/view/PointerIconCompat.java
M core/core/src/main/java/androidx/core/view/VelocityTrackerCompat.java
M core/core/src/main/java/androidx/core/view/ViewCompat.java
M core/core/src/main/java/androidx/core/view/ViewConfigurationCompat.java
M core/core/src/main/java/androidx/core/view/ViewGroupCompat.java
M core/core/src/main/java/androidx/core/view/ViewParentCompat.java
M core/core/src/main/java/androidx/core/view/ViewPropertyAnimatorCompat.java
M core/core/src/main/java/androidx/core/view/ViewStructureCompat.java
M core/core/src/main/java/androidx/core/view/WindowCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityEventCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityManagerCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityNodeInfoCompat.java
M core/core/src/main/java/androidx/core/view/accessibility/AccessibilityWindowInfoCompat.java
M core/core/src/main/java/androidx/core/view/animation/PathInterpolatorCompat.java
M core/core/src/main/java/androidx/core/view/contentcapture/ContentCaptureSessionCompat.java
M core/core/src/main/java/androidx/core/view/inputmethod/InputConnectionCompat.java
M core/core/src/main/java/androidx/core/widget/CompoundButtonCompat.java
M core/core/src/main/java/androidx/core/widget/EdgeEffectCompat.java
M core/core/src/main/java/androidx/core/widget/ImageViewCompat.java
M core/core/src/main/java/androidx/core/widget/NestedScrollView.java
M core/core/src/main/java/androidx/core/widget/PopupWindowCompat.java
M core/core/src/main/java/androidx/core/widget/TextViewCompat.java
M core/haptics/haptics/src/main/java/androidx/core/haptics/impl/HapticAttributesConverter.kt
M core/haptics/haptics/src/main/java/androidx/core/haptics/impl/HapticSignalConverter.kt
M core/haptics/haptics/src/main/java/androidx/core/haptics/impl/VibratorWrapperImpl.kt

https://android-review.googlesource.com/3156139

da...@gmail.com <da...@gmail.com> #14Jan 22, 2020 09:03PM

Project: platform/frameworks/support
Branch: androidx-main

commit 12ea61e42c7f29a0f539a069f06507a0f133910d
Author: Alan Viverette <alanv@google.com>
Date: Tue Jul 02 13:55:26 2024

Remove usage of @DoNotInline for manual NewApi outlines (A thru Ca)

Does not include AppSearch because they have downstream changes.

We no longer need manual NewApi outlines, so we can start by letting the
compiler inline the static methods.

Relnote: """Removed manual outlining of access to new platform APIs
since this happens automatically via API modeling when using R8 with
AGP 7.3 or later (e.g. R8 version 3.3) and for all builds when using
AGP 8.1 or later (e.g. D8 version 8.1). Clients who are not using
AGP are advised to update to D8 version 8.1 or later. See
[this article](

https://medium.com/androiddevelopers/mitigating-soft-verification-issues-in-r8-and-d8-7e9e06827dfd)
for more details."""
Bug: 345472586
Test: ./gradlew bOS
Change-Id: I9496cfaeb50a5c484fbee6521b74a0605fb013dc

M activity/activity/src/main/java/androidx/activity/BackEventCompat.kt
M activity/activity/src/main/java/androidx/activity/ComponentActivity.kt
M activity/activity/src/main/java/androidx/activity/OnBackPressedDispatcher.kt
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/resources/Compatibility.java
M appcompat/appcompat-resources/src/main/java/androidx/appcompat/widget/DrawableUtils.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegate.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppCompatDelegateImpl.java
M appcompat/appcompat/src/main/java/androidx/appcompat/app/AppLocalesMetadataHolderService.java
M appcompat/appcompat/src/main/java/androidx/appcompat/view/WindowCallbackWrapper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatReceiveContentHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatSpinner.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextClassifierHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/AppCompatTextViewAutoSizeHelper.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/DropDownListView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/ListPopupWindow.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/MenuPopupWindow.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/SearchView.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/TintTypedArray.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/Toolbar.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/TooltipCompat.java
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/ViewUtils.java
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/integration-tests/macrobenchmark-target/src/main/java/androidx/benchmark/integration/macrobenchmark/target/SingleColorActivity.kt
M biometric/integration-tests/testapp/src/main/java/androidx/biometric/integration/testapp/CryptoUtils.kt
M bluetooth/bluetooth/src/main/java/androidx/bluetooth/AdvertiseParams.kt
M bluetooth/bluetooth/src/main/java/androidx/bluetooth/ScanFilter.kt
M bluetooth/bluetooth/src/main/java/androidx/bluetooth/ScanResult.kt
M browser/browser/src/main/java/androidx/browser/customtabs/Api33Impl.java
M browser/browser/src/main/java/androidx/browser/customtabs/CustomTabsIntent.java
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/EncoderProfilesProviderAdapter.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/compat/ApiCompat.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/impl/CameraInteropStateCallbackRepository.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/internal/DynamicRangeConversions.kt
M camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/internal/DynamicRangeResolver.kt
M camera/camera-camera2-pipe/src/main/java/androidx/camera/camera2/pipe/compat/ApiCompat.kt
M camera/camera-camera2-pipe/src/main/java/androidx/camera/camera2/pipe/compat/CaptureSessionWrapper.kt
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2CaptureRequestBuilder.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/Camera2EncoderProfilesProvider.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/DynamicRangeResolver.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SynchronizedCaptureSessionBaseImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/ApiCompat.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/StreamConfigurationMapCompatBaseImpl.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/params/DynamicRangeConversions.java
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/Bitmap2JpegBytes.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/CameraValidator.java
M camera/camera-core/src/main/java/androidx/camera/core/impl/utils/ContextUtil.java
M camera/camera-effects/src/main/java/androidx/camera/effects/internal/Utils.java
M camera/camera-extensions/src/androidTest/java/androidx/camera/extensions/util/Api21Impl.kt
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/ExtensionsUtils.java
M camera/camera-extensions/src/main/java/androidx/camera/extensions/internal/compat/workaround/CaptureOutputSurfaceForCaptureProcessor.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/CameraUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/TestImageUtil.java
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/WakelockEmptyActivityRule.kt
M camera/camera-testing/src/main/java/androidx/camera/testing/impl/compat/LooperCompat.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api23Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api24Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api26Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api28Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api29Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/Api31Impl.java
M camera/camera-video/src/main/java/androidx/camera/video/internal/encoder/EncoderImpl.java
M camera/camera-view/src/main/java/androidx/camera/view/SurfaceViewImplementation.java
M camera/camera-viewfinder/src/main/java/androidx/camera/viewfinder/SurfaceViewImplementation.java
M camera/integration-tests/avsynctestapp/src/main/java/androidx/camera/integration/avsync/MainActivity.kt
M camera/integration-tests/camerapipetestapp/src/main/java/androidx/camera/integration/camera2/pipe/SimpleCamera.kt
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXActivity.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/CameraXService.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/OpenGLActivity.java
M camera/integration-tests/coretestapp/src/main/java/androidx/camera/integration/core/SurfaceViewRenderSurface.java
M camera/integration-tests/extensionstestapp/src/main/java/androidx/camera/integration/extensions/Camera2ExtensionsActivity.kt
M car/app/app-automotive/src/main/java/androidx/car/app/activity/BaseCarAppActivity.java
M car/app/app-automotive/src/main/java/androidx/car/app/activity/renderer/surface/TemplateSurfaceView.java
M car/app/app-automotive/src/main/java/androidx/car/app/hardware/info/AutomotiveCarInfo.java
M car/app/app/src/main/java/androidx/car/app/CarAppMetadataHolderService.java
M car/app/app/src/main/java/androidx/car/app/CarContext.java
M car/app/app/src/main/java/androidx/car/app/SessionInfoIntentEncoder.java
M car/app/app/src/main/java/androidx/car/app/connection/CarConnectionTypeLiveData.java
M car/app/app/src/main/java/androidx/car/app/model/DateTimeWithZone.java
M car/app/app/src/main/java/androidx/car/app/model/DurationSpan.java
M car/app/app/src/main/java/androidx/car/app/navigation/model/TravelEstimate.java
M car/app/app/src/main/java/androidx/car/app/notification/CarNotificationManager.java
M car/app/app/src/main/java/androidx/car/app/validation/HostValidator.java

https://android-review.googlesource.com/3156138

da...@gmail.com <da...@gmail.com> #15Jan 22, 2020 09:10PM

We still have some @DoNotInline usages lingering because of conflicts with androidx-platform-dev. Once the upstreaming is completed and those are removed, I think we should call it done. Manually inlining the ApiXXImpl classes isn't urgent or really necessary.

ra...@google.com <ra...@google.com> #16Jan 22, 2020 10:16PM

Hi. I've received your bug, you didn't specify what to wait for so I will wait for

b/346290560

to be resolved and then assign the bug to alanv@google.com.

Bugjuggler:

b/346290560

-> assigned to alanv@google.com

da...@gmail.com <da...@gmail.com> #17Jan 23, 2020 05:11AM

Project: platform/frameworks/support
Branch: androidx-main

commit c520a87c6e27a14472cfcf8b03c0d4ea8c1a37c7
Author: Ian Baker <ibaker@google.com>
Date: Thu Jul 18 08:32:31 2024

Remove `@DoNotInline` recommendations from go/androidx-api-guidelines

The associated lint check has been disabled, see

b/345472586

for more details.

PiperOrigin-RevId: 653629895
Change-Id: I186c052a059e5ad30386cd45beb47f24bdafe657

M docs/api_guidelines/compat.md
M docs/api_guidelines/platform_compat.md

https://android-review.googlesource.com/3177449

ey...@gmail.com <ey...@gmail.com> #18Jan 26, 2020 05:39AM

We'll take removing manual outlining on a case-by-case basis. Removing it all at once would be a lot of work for not much gain.