IssueTracker

You'll get extra KEY_DEEP_LINK_IDS ("android-support-nav:controller:deepLinkIds") = [R.id.nav_graph_main] if you have a deep link either 1) to the root of your graph or 2) an implicit deep link to a child of your nav_graph_main on the other apps task stack and the user hits the Up button.

In any case, Navigation should not be crashing when handling a deep link (it should only be printing a INFO log message saying it is ignoring the deep link). We have logic for doing exactly that, but it seems like that is failing when the deep link is exactly to only the root graph's ID such as in your [R.id.nav_graph_main] case.

This has been fixed internally (you should no longer get any crash from handleDeepLink()) and will be available in Navigation 2.3.0-alpha05.

We're looking to do a Navigation 2.2.2 bug fix release and will include this fix in that.

Hello, does anyone know the timeline when to release version 2.3.0-alpha05? Unfortunately we are also encountering this crash in our app. Thank you.

Navigation 2.2.2 and Navigation 2.3.0-alpha05 both contain this fix and were released yesterday.

The crash is gone now, thank you!

After upgrading to 2.2.2 i have crash on finding graph.

I/NavController: Could not find destination com.my.app:id/main_navigation in the navigation graph, ignoring the deep link from Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x1040c000 pkg=com.my.app cmp=com.my.app/com.my.app.MainActivity (has extras) }

This is simple deep link to specified fragment. We have nested NavHostFragment. The fragment i'm deep linking to is in PARENT GRAPH, not the nested one. MainPageFragment have the nested NavHostFragment in it, so i guess the graph found is the nested one and so - does not match one that we are looking for.

<navigation xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    xmlns:tools="http://schemas.android.com/tools"
    android:id="@+id/main_navigation"
    app:startDestination="@id/intro_navigation">
    <fragment
        android:id="@+id/mainPageFragment"
        android:name="com.my.app.MainPageFragment"
        android:label="MainPageFragment">
        <argument
            android:name="fromNotification"
            android:defaultValue="false"
            app:argType="boolean" />
    </fragment>
</navigation>

I created this deep link by builder:

NavDeepLinkBuilder(context)
        .setGraph(R.navigation.main_navigation)
        .setDestination(R.id.mainPageFragment)
        .setArguments(bundleOf("fromNotification" to true))
        .createPendingIntent()

Re #12 - please file a new bug with a sample project that reproduces your issue. It would be expected that you'd see at least one log message if you have nested NavHostFragment instances with different graphs (the nested graph would ignore deep links to the outer one, as expected).

I think that this code breaks down:

NavDestination node = i == 0
                    ? (mGraph.getId() == destinationId ? mGraph : null)
                    : graph.findNode(destinationId, false);

For some reason it assumes that first deeplink have to be in current mGraph. Shouldn't it always scan all graphs to look for proper node?

I have 2 of such logs, each for every graph. I will try to create project that reproduces this and create new bug