Deeplinks without parameters don't match incoming deeplinks with parameters other than the specified ones [147447512]

Fixed

Bug

Status Update

No update yet.

Description

sv...@whisp.de

created issue #1

Jan 10, 2020 02:33PM

Component used: Navigation
Version used: 2.2.0-rc04
Devices/Android versions reproduced on: potentially all

This is kind of a followup to

https://issuetracker.google.com/issues/141482822,

comment #3

.

There seems to be a bug related to the changes introduced in the aforementioned ticket. If I define a simple deeplink like so:

<deepLink
android:id="@+id/deepLinkToSomething"
app:uri="myapp://open/something />

... the deeplink will NOT be executed when I attempt to open an Intent which has the data URI myapp://open/something?someParameter=parameter. The solution to the aforementioned ticket should have made this work by ignoring undefined parameters.

My current local solution (as outlined per

comment #3

in the aforementioned issue): adding a dummy parameter to the uri in the deeplink definition, like:

<deepLink
android:id="@+id/deepLinkToSomething"
app:uri="myapp://open/something?dummy={dummy} />

Then it works just fine.

I suspect it has something to do with how the pattern is compiled in the constructor of NavDeepLink in case there are no parameters.

Comments

il...@google.com <il...@google.com> Jan 10, 2020 06:38PM

Assigned to jb...@google.com.

jo...@jmb.dev <jo...@jmb.dev> #2Jan 18, 2020 12:41AM

Can you attach a sample project that reproduces your issue?

il...@google.com <il...@google.com> #3Jan 22, 2020 12:31AM

I'm experiencing this issue in a commercial non-open source project so I'd have to provide extracted code fragments. The menu file for instance looks similar to this:

<menu>
    <item
        android:id="@+id/destination_one" />

    <item
        android:id="@+id/destination_two" />

    <item
        android:id="@+id/destination_three" />

    <item
        android:id="@+id/destination_four" />
</menu>

The menu item ids match the top level destination ids as for instance destination_one as required by the NavigationUI library.

The xml layout file of the main activity (there is only one activity) looks pretty much like this:

<androidx.coordinatorlayout.widget.CoordinatorLayout>

    <androidx.constraintlayout.widget.ConstraintLayout>

        <androidx.fragment.app.FragmentContainerView
            android:id="@+id/navigation_host_fragment"
            android:name="androidx.navigation.fragment.NavHostFragment"
            android:layout_width="match_parent"
            android:layout_height="0dp"
            app:defaultNavHost="true"
            app:layout_constraintBottom_toTopOf="@id/bottom_navigation"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toTopOf="parent"
            app:navGraph="@navigation/main_navigation" />

        <com.google.android.material.bottomnavigation.BottomNavigationView
            android:id="@+id/bottom_navigation"
            android:layout_width="match_parent"
            android:layout_height="wrap_content"
            app:layout_constraintBottom_toBottomOf="parent"
            app:layout_constraintEnd_toEndOf="parent"
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toBottomOf="@id/navigation_host_fragment"
            app:menu="@menu/main_menu" />
    </androidx.constraintlayout.widget.ConstraintLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>

The main_navigation is the first navigation graph I posted in the original post. The behavior I described above only affects the first bottomNavigation item which corresponds to the top level navGraph's startDestination.

ap...@google.com <ap...@google.com> #4Jan 22, 2020 01:23AM

Yeah, what we're looking for is a full project (i.e., take a brand new project in Android Studio, put your few bits of code in, and make sure your problem reproduces) as there are a lot of little pieces that can make a difference here.

jb...@google.com <jb...@google.com> #5Jan 22, 2020 01:23AM

Marked as fixed.

https://github.com/postfixNotation/NavigationUI

Of course the logic of my project is more sophisticated but this reproduces the issue quite well. If you click the first BottomNavigation item N times you need N+1 system back navigation triggers to leave the app.

an...@google.com <an...@google.com> #6Jan 23, 2020 08:41PM

So first, we plan to get rid of these APIs in the future. The only behavior for NavigationUI will be to always save and restore the state of the back stack. Luckily, NavigationUI is purposely built only on publicly available APIs so you could always copy our code and make your custom adjustments for whatever your desired behavior is.

The source of the bug is here in NavController. Since we are navigating to the graph and the currentDestination is the start destination on the graph their ids don't match and we never actually do the singleTop operation causing multiple of the same destination to be added to the back stack.

We need to add a fix to ensure we take into account the proper destination on our side, but as I mentioned those APIs will go away in the future. So if you wanted to proactively create your own API, you could make your API navigate directly to the start destination instead of the graph. That would allow you to not wait on our release and ensure you always have your desired behavior going forward.

Issue 147447512