R8 causes issues with aar specified proguard.txt [147470785]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 11, 2020 04:00AM

The Environment:
Current version is: 1.4.94 (build 390954928f0db9c3b888a367f7f128ce3bbfb160 from go/r8bot (luci-r8-ci-archive-0-5g74)).
Android studio 3.5.3
---------------------------------------
THE FOLLOWING LOG

AGPBI: {"kind":"error","text":"Expected list element at D:\\development\\.gradle\\caches\\transforms-2\\files-2.1\\4xxxxxxxxxxxxxxxxx\\proguard.txt:40:50\n-keepattributes Exceptions,InnerClasses,Signature,...\n ^","sources":[{"file":"D:\\development\\.gradle\\caches\\transforms-2\\files-2.1\\4b28c9d5bca91a0d7c9621ce982d9f50\\proguard.txt","position":{"startLine":39,"startColumn":50,"startOffset":1294,"endColumn":51,"endOffset":1295}}],"tool":"D8"}
----------------------------------------
The FOLLOWING attachment is the confusion rule of AAR

proguard.txt

2.2 KB

View

Download

Comments

js...@google.com <js...@google.com> #2Jan 11, 2020 06:02AM

Status: Won't Fix (Intended Behavior)

Thank you for the report. In your proguard rules:

-keepattributes SourceFile,LineNumberTable
-keepattributes Exceptions,InnerClasses,Signature,...

Please remove ,..., i.e.,

-keepattributes SourceFile,LineNumberTable
-keepattributes Exceptions,InnerClasses,Signature

Here are some references.

https://www.guardsquare.com/en/products/proguard/manual/usage#keepattributes

-keepattributes [attribute_filter]
...
The optional filter is a comma-separated list of attribute names that Java virtual machines and ProGuard support. Attribute names can contain ?, *, and ** wildcards, and they can be preceded by the ! negator.
...

https://www.guardsquare.com/en/products/proguard/manual/usage/attributes which shows what wild cards are supported: ? and *.

[Deleted User] <[Deleted User]> #3Jan 13, 2020 01:48AM

thank you，I know the cause of the issue.

ag...@google.com <ag...@google.com> #4Jan 13, 2020 07:27AM

Status: Assigned (reopened)

Thanks for the report. Since Proguard allows this syntax we should experiment with it and see if it is just ignored or how it is interpreted. Since we have no easy way of excluding shrinker configuration files from aars at this point, users of these aars will have to repackage the aar themselves to workaround it. To make it easier for developers we should probably allow this?

mk...@google.com <mk...@google.com> #5Jan 13, 2020 07:54AM

Reassigned to mk...@google.com.

Will take a look

ap...@google.com <ap...@google.com> #6Jan 13, 2020 11:24AM

Project: r8
Branch: master

commit 6503a93c65d023270ea52a30ad76c19dd8b668b6
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Jan 13 11:41:29 2020

Allow for '.' for patterns when parsing -keepattributes

PG allow for patterns that has '.' in them when parsing
-keepattributes. We should ensure not to throw an error since
developers can add such rules to their libraries.

Bug: 147470785
Change-Id: I54845ecae12d608faf95294eadec461b848c823d

M src/main/java/com/android/tools/r8/shaking/ProguardConfigurationParser.java
A src/test/java/com/android/tools/r8/shaking/attributes/KeepAttributesDotsTest.java

https://r8-review.googlesource.com/47321

ap...@google.com <ap...@google.com> #7Jan 13, 2020 02:40PM

Project: r8
Branch: master

commit d433ca92d445d857852f61117c02c9eccbf5491c
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Jan 13 14:28:19 2020

Fix proguard configuration parser test to allow classname in attribute

Bug: 147470785
Change-Id: I5ca875ba9e5601168893efeb71a341dd33acef25

M src/test/java/com/android/tools/r8/shaking/ProguardConfigurationParserTest.java

https://r8-review.googlesource.com/47361

mk...@google.com <mk...@google.com> Jan 13, 2020 03:13PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #8Jan 16, 2020 07:03AM

Project: r8
Branch: 2.0

commit 3df603d82316846021d557954be5e1f5b3c98aa3
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 15 16:12:54 2020

Version 2.0.15

Cherry-pick: Fix version test when we are on a release branch
CL:

https://r8-review.googlesource.com/47564

Cherry-pick: Reland "Do not rewrite generic signatures in target of
merged classes"
CL:

https://r8-review.googlesource.com/47512

Cherry-pick: Do not classinline when root is a static get and is used with a monitor
CL:

https://r8-review.googlesource.com/47280

Cherry-pick: Allow for '.' for patterns when parsing -keepattributes
CL:

https://r8-review.googlesource.com/47321

Cherry-pick: Fix proguard configuration parser test to allow classname in attribute
CL:

https://r8-review.googlesource.com/47361

Bug: 147386014
Bug: 147411673
Bug: 147470785
Change-Id: If56d14012b6121ab76416ea7d8a8dda78d02136e

M src/main/java/com/android/tools/r8/Version.java
M src/main/java/com/android/tools/r8/ir/optimize/classinliner/ClassInlinerEligibilityInfo.java
M src/main/java/com/android/tools/r8/ir/optimize/classinliner/InlineCandidateProcessor.java
M src/main/java/com/android/tools/r8/ir/optimize/info/MethodOptimizationInfoCollector.java
M src/main/java/com/android/tools/r8/ir/optimize/info/ParameterUsagesInfo.java
M src/main/java/com/android/tools/r8/naming/ClassNameMinifier.java
M src/main/java/com/android/tools/r8/naming/signature/GenericSignatureAction.java
M src/main/java/com/android/tools/r8/naming/signature/GenericSignatureParser.java
M src/main/java/com/android/tools/r8/naming/signature/GenericSignatureRewriter.java
M src/main/java/com/android/tools/r8/shaking/ProguardConfigurationParser.java
M src/main/java/com/android/tools/r8/shaking/VerticalClassMerger.java
M src/main/java/com/android/tools/r8/utils/IteratorUtils.java
M src/test/java/com/android/tools/r8/VersionTests.java
A src/test/java/com/android/tools/r8/ir/optimize/classinliner/ClassInlinerStaticGetDirectMonitorTest.java
A src/test/java/com/android/tools/r8/ir/optimize/classinliner/ClassInlinerStaticGetExtraMethodMonitorTest.java
A src/test/java/com/android/tools/r8/ir/optimize/classinliner/ClassInlinerStaticGetMonitorTest.java
M src/test/java/com/android/tools/r8/naming/GenericSignatureParserTest.java
A src/test/java/com/android/tools/r8/naming/signature/SignatureOfMergedClassesTest.java
A src/test/java/com/android/tools/r8/naming/signature/merging/I.java
A src/test/java/com/android/tools/r8/naming/signature/merging/ImplI.java
A src/test/java/com/android/tools/r8/naming/signature/merging/ImplK.java
A src/test/java/com/android/tools/r8/naming/signature/merging/InterfaceToKeep.java
A src/test/java/com/android/tools/r8/naming/signature/merging/J.java
A src/test/java/com/android/tools/r8/naming/signature/merging/K.java
M src/test/java/com/android/tools/r8/shaking/ProguardConfigurationParserTest.java
A src/test/java/com/android/tools/r8/shaking/attributes/KeepAttributesDotsTest.java
M src/test/java/com/android/tools/r8/utils/codeinspector/CodeInspector.java

https://r8-review.googlesource.com/47610

mk...@google.com <mk...@google.com> Jan 20, 2020 01:48PM

Marked as fixed.