navigation-ui ProGuard rules were not changed when Navigation moved to AndroidX [147610424]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Jan 13, 2020 09:44PM

Component used: Navigation Version used: 2.2.0-rc04

https://issuetracker.google.com/issues/123449431 added ProGuard rules to navigation-ui to ensure that the back button remains functional with minifyEnabled.

However, those rules were written in the Support Library time and jetifier would convert them to the appropriate AndroidX versions when using Navigation 1.X with an AndroidX project:

# setProgress is called via an ObjectAnimator in AbstractAppBarOnDestinationChangedListener
-keepclassmembers class android.support.v7.graphics.drawable.DrawerArrowDrawable {
    void setProgress(float);
}

Since Navigation moved to 2.X and is now part of AndroidX, Jetifier does not apply any transformations and navigation-ui's ProGuard rules need to be updated to reflect the appropriate AndroidX package name for DrawerArrowDrawable (androidx.appcompat.graphics.drawable.DrawerArrowDrawable).

Comments

jb...@google.com <jb...@google.com> #2Jan 14, 2020 06:39PM

Accepted by jb...@google.com.

The old rule works correctly, if jetifier is enabled (add android.enableJetifier=true to the gradle.properties file). But the rule package should be updated so that this is not required since Navigation now lives in androidx.

ap...@google.com <ap...@google.com> #3Jan 15, 2020 04:03AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 569ef82c1c7ec719efd4811d28e7801967efffc0
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Jan 14 10:44:02 2020

Updated ArrowDrawable navigation-ui proguard rule

The proguard rule to keep the DrawerArrowDrawable class in minified
release builds was written before Navigation was moved to androidx. That
means for it to work on Navigation release that are in androidx,
jetifier needs to be enabled for the project. Now that navigation has
moved, we should adjust the rule so that jetifier is not required it to
work.

Test: Tested in sample app
Bug: 147610424
Change-Id: Iaac0c6aab4aa6340decbeeed2967a91133fe02b6

M navigation/navigation-ui/proguard-rules.pro

https://android-review.googlesource.com/1208323

jb...@google.com <jb...@google.com> #4Jan 15, 2020 05:31PM

Marked as fixed.

This issue has been fixed internally and will be available in the Navigation 2.2.1 release.

an...@google.com <an...@google.com> #5Jan 23, 2020 08:41PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6205454677704704/#/history/all)
Created: 2020-01-23 20:38:51.868922+00:00
Changes: aosp/1208323

Issue 147610424

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Jan 14, 2020 06:39PM

ap...@google.com <ap...@google.com> #3Jan 15, 2020 04:03AM

jb...@google.com <jb...@google.com> #4Jan 15, 2020 05:31PM

an...@google.com <an...@google.com> #5Jan 23, 2020 08:41PM

Add comment

Issue metadata